samba.git
13 years agos4:ldb: change version to 1.1.0 after adding new functions: ldb-1.1.0
Stefan Metzmacher [Sat, 9 Apr 2011 09:33:03 +0000 (11:33 +0200)]
s4:ldb: change version to 1.1.0 after adding new functions:

ldb_ldif_parse_modrdn()
ldb_req_set_custom_flags()
ldb_req_get_custom_flags()

Signed-off-by: Simo Sorce <idra@samba.org>
metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Apr 21 17:15:16 CEST 2011 on sn-devel-104

13 years agoldb: add custom flags and functions for the application that wants to manipulate...
Matthieu Patou [Wed, 20 Apr 2011 16:26:47 +0000 (20:26 +0400)]
ldb: add custom flags and functions for the application that wants to manipulate them

Signed-off-by: Simo Sorce <idra@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
13 years agos4:ldb/tests: add tests for ldbmodify and 'modrdn'
Stefan Metzmacher [Wed, 6 Apr 2011 18:14:54 +0000 (20:14 +0200)]
s4:ldb/tests: add tests for ldbmodify and 'modrdn'

Signed-off-by: Simo Sorce <idra@samba.org>
metze

13 years agos4:ldb/tools: add support for "modrdn" to ldbmodify
Stefan Metzmacher [Tue, 5 Apr 2011 12:42:06 +0000 (14:42 +0200)]
s4:ldb/tools: add support for "modrdn" to ldbmodify

Signed-off-by: Simo Sorce <idra@samba.org>
metze

13 years agos4:ldb/ldif: add support for "modrdn"
Stefan Metzmacher [Tue, 5 Apr 2011 12:41:27 +0000 (14:41 +0200)]
s4:ldb/ldif: add support for "modrdn"

This add a ldb_ldif_parse_modrdn() helper function to parse
the information out of a ldb_message structure.

Signed-off-by: Simo Sorce <idra@samba.org>
metze

13 years agos3-vfs: rename open function to open_fn.
Günther Deschner [Wed, 20 Apr 2011 20:55:25 +0000 (22:55 +0200)]
s3-vfs: rename open function to open_fn.

This should finally fix the AIX build and allow to remove AIX specific ifdefs.

Guenther

Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 21 02:01:20 CEST 2011 on sn-devel-104

13 years agos3-build: move MAP_FILE define to the only place used.
Günther Deschner [Wed, 20 Apr 2011 16:21:25 +0000 (18:21 +0200)]
s3-build: move MAP_FILE define to the only place used.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Apr 20 19:16:47 CEST 2011 on sn-devel-104

13 years agos3-smbd: fix the AIX 5.3 build.
Günther Deschner [Wed, 20 Apr 2011 15:54:24 +0000 (17:54 +0200)]
s3-smbd: fix the AIX 5.3 build.

(AIX defines open to be open64)

Guenther

13 years agos4-smbtorture: restructure documentname handling in spoolss test a bit.
Günther Deschner [Wed, 20 Apr 2011 15:53:43 +0000 (17:53 +0200)]
s4-smbtorture: restructure documentname handling in spoolss test a bit.

Guenther

13 years agos3-spoolss: fix debug statement in spoolss_addprinterex_level_2().
Günther Deschner [Wed, 20 Apr 2011 15:19:15 +0000 (17:19 +0200)]
s3-spoolss: fix debug statement in spoolss_addprinterex_level_2().

Guenther

13 years agolib/util/charset Always set *converted_size even on failure
Andrew Bartlett [Thu, 14 Apr 2011 07:22:53 +0000 (17:22 +1000)]
lib/util/charset Always set *converted_size even on failure

The caller may wish to inspect the partially converted string.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed Apr 20 05:17:48 CEST 2011 on sn-devel-104

13 years agolib/util/charset create _handle functions for convert_string() et al
Andrew Bartlett [Tue, 12 Apr 2011 04:36:17 +0000 (14:36 +1000)]
lib/util/charset create _handle functions for convert_string() et al

This is now API compatible with the existing code in lib/util/charset

lazy_initialize_conv() is no longer called as init_iconv() is called
when the smb.conf is processed, and get_conv_handle() will auto-init
with defaults if required.

load_case_tables_library() is no longer requried as all binaries and
libraries already load these in their entry points, as otherwise all
the other string functions would fail.

Andrew Bartlett

13 years agolibcli/auth Move PAC parsing and verification in common.
Andrew Bartlett [Wed, 20 Apr 2011 02:05:27 +0000 (12:05 +1000)]
libcli/auth Move PAC parsing and verification in common.

This uses the source3 PAC code (originally from Samba4) with some
small changes to restore functionality needed by the torture tests,
and to have a common API.

Andrew Bartlett

13 years agolibcli/auth: Move more kerberos wrapping in common
Andrew Bartlett [Wed, 20 Apr 2011 02:03:48 +0000 (12:03 +1000)]
libcli/auth: Move more kerberos wrapping in common

These functions are required to get the krb5 PAC parsing and
verfication in common.

Andrew Bartlett

13 years agos3-gse: Allow the GSSAPI wrapper to load a keytab using gss_krb5_import_cred()
Andrew Bartlett [Fri, 15 Apr 2011 22:50:53 +0000 (08:50 +1000)]
s3-gse: Allow the GSSAPI wrapper to load a keytab using gss_krb5_import_cred()

This Heimdal function does not set the global state, and allows the
GSSAPI server to progress further when compiled against Heimdal (such
as in the top level build).

The ability to specify a keytab has been removed from the API as it is
unused, and and the Heimdal function (avoiding setting global
variables) works with an open keytab.

Andrew Bartlett

13 years agotdb_backup: avoid transaction on backup file, use lockall
Simo Sorce [Sun, 10 Apr 2011 02:21:35 +0000 (22:21 -0400)]
tdb_backup: avoid transaction on backup file, use lockall

Transactions have the side effect of generating bigger files.
By removing the transaction files get as much as 30% smaller.

Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Tue Apr 19 23:34:37 CEST 2011 on sn-devel-104

13 years agoFix Bug #8099 setpwent() actually does endpwent() and vice versa on FreeBSD
Sergey Korsak [Mon, 18 Apr 2011 12:48:47 +0000 (14:48 +0200)]
Fix Bug #8099 setpwent() actually does endpwent() and vice versa on FreeBSD

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Apr 19 19:15:14 CEST 2011 on sn-devel-104

13 years agotdb: make sure we skip over recovery area correctly.
Rusty Russell [Tue, 19 Apr 2011 11:30:59 +0000 (21:00 +0930)]
tdb: make sure we skip over recovery area correctly.

If it's really the recovery area, we can trust the rec_len field, and
don't have to go groping for bitpatterns.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue Apr 19 14:15:22 CEST 2011 on sn-devel-104

13 years agotdb_expand: limit the expansion with huge records
Simo Sorce [Mon, 18 Apr 2011 12:45:11 +0000 (22:15 +0930)]
tdb_expand: limit the expansion with huge records

ldb can create huge records when saving indexes.
Limit the tdb expansion to avoid consuming a lot of memory for
no good reason if the record being saved is huge.

13 years agotdb: tdb_repack() only when it's worthwhile.
Rusty Russell [Mon, 18 Apr 2011 12:45:11 +0000 (22:15 +0930)]
tdb: tdb_repack() only when it's worthwhile.

tdb_repack() is expensive and consumes memory, so we can spend some
effort to see if it's worthwhile.  In particular, tdbbackup doesn't
need to repack: it started with an empty database!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
13 years agotdb: fix transaction recovery area for converted tdbs.
Rusty Russell [Mon, 18 Apr 2011 12:45:11 +0000 (22:15 +0930)]
tdb: fix transaction recovery area for converted tdbs.

This is why macros are dangerous; these were converting the pointers, not the
things pointed to!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
13 years agoselftest Consolidate server wall clock time limits
Andrew Bartlett [Tue, 19 Apr 2011 03:50:40 +0000 (13:50 +1000)]
selftest Consolidate server wall clock time limits

This helps ensure that we don't have the Samba3 servers stop before
the full make test is finished.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Apr 19 09:03:07 CEST 2011 on sn-devel-104

13 years agoselftest: move warning about invalid environments up to selftest.pl
Andrew Bartlett [Tue, 19 Apr 2011 02:43:54 +0000 (12:43 +1000)]
selftest: move warning about invalid environments up to selftest.pl

13 years agoselftest: Don't specify SELFTEST_TARGET as an env variable
Andrew Bartlett [Tue, 19 Apr 2011 01:59:28 +0000 (11:59 +1000)]
selftest: Don't specify SELFTEST_TARGET as an env variable

It is much more reliable to specify it as a direct parameter, and this
is needed for the combined 'make test'.

Andrew Bartlett

13 years agoselftest Test for socket_wrapper support in combined samba target as well
Andrew Bartlett [Tue, 19 Apr 2011 01:58:50 +0000 (11:58 +1000)]
selftest Test for socket_wrapper support in combined samba target as well

13 years agoselftest: Add hooks to enable a combined selftest run.
Andrew Bartlett [Mon, 18 Apr 2011 08:59:00 +0000 (18:59 +1000)]
selftest: Add hooks to enable a combined selftest run.

Andrew Bartlett

13 years agos4-selftest Rename Samba4 'member' test environment to s4member
Andrew Bartlett [Mon, 18 Apr 2011 08:57:22 +0000 (18:57 +1000)]
s4-selftest Rename Samba4 'member' test environment to s4member

This will avoid a conflict with the s3 'member' environment.

Andrew Bartlett

13 years agos4-selftest: Move Samba4 test interfaces out of the way of the Samba3 tests.
Andrew Bartlett [Mon, 18 Apr 2011 08:56:41 +0000 (18:56 +1000)]
s4-selftest: Move Samba4 test interfaces out of the way of the Samba3 tests.

This avoids a conflict when we merge the test suites.

13 years agos3-selftest Fix interface localktest6 listens on.
Andrew Bartlett [Mon, 18 Apr 2011 08:55:35 +0000 (18:55 +1000)]
s3-selftest Fix interface localktest6 listens on.

Andrew Bartlett

13 years agoselftest Add combined 'Samba' target module
Andrew Bartlett [Mon, 18 Apr 2011 07:38:35 +0000 (17:38 +1000)]
selftest Add combined 'Samba' target module

To work around environment variable handling, the initialisation of
NSS_WRAPPER_WINBIND_SO_PATH is pushed in to Samba3.pm (the s3 autoconf
build still overrides this)

Andrew Bartlett

13 years agos4-selftest: Avoid duplicating the servers IP in the provision() sub arguments.
Andrew Bartlett [Mon, 18 Apr 2011 06:09:30 +0000 (16:09 +1000)]
s4-selftest: Avoid duplicating the servers IP in the provision() sub arguments.

This should make it easier to change the IP address.

Andrew Bartlett

13 years agos3-selftest Rename s3 DC environment to s3dc
Andrew Bartlett [Mon, 18 Apr 2011 05:28:40 +0000 (15:28 +1000)]
s3-selftest Rename s3 DC environment to s3dc

This should avoid a clash with the s4 DC environment in a future
combined 'make test'.

Andrew Bartlett

13 years agos4-selftest: Stop creating netbios aliases everywhere
Andrew Bartlett [Mon, 18 Apr 2011 04:34:40 +0000 (14:34 +1000)]
s4-selftest: Stop creating netbios aliases everywhere

This reduces some of the clutter when we have quite so many server
configurations starting.

The one case that actually needs an alias (dc environment for the
test_nmblookup.sh test) will still keep it.

Andrew Bartlett

13 years agoselftest: put the target on the environment
Andrew Bartlett [Mon, 18 Apr 2011 03:44:36 +0000 (13:44 +1000)]
selftest: put the target on the environment

This will allow us to have a 'switch' target type that creates
environments from Samba3 or Samba4 as required.

Andrew Bartlett

13 years agolib/socket_wrapper: allow up to 32 interfaces for a bigger 'make test'
Andrew Bartlett [Tue, 19 Apr 2011 00:02:55 +0000 (10:02 +1000)]
lib/socket_wrapper: allow up to 32 interfaces for a bigger 'make test'

The combined s3/s4 'make test' needs more interfaces.

Andrew Bartlett

13 years agoFix bug 8088 - rpccli_samr_chng_pswd_auth_crap segfaults if any input blobs are null.
Jeremy Allison [Mon, 18 Apr 2011 21:32:11 +0000 (14:32 -0700)]
Fix bug 8088 - rpccli_samr_chng_pswd_auth_crap segfaults if any input blobs are null.

Correct fix - ensure we have enough length, and correctly null out
passed in structs if not.

Jeremy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Apr 19 00:17:08 CEST 2011 on sn-devel-104

13 years agos3 waf: Mimic the autoconf check for netgrent
Kai Blin [Mon, 18 Apr 2011 12:55:51 +0000 (14:55 +0200)]
s3 waf: Mimic the autoconf check for netgrent

The autoconf check for netgrent headers makes sure that the compiler flag used
(-Werror-implicit-function-declaration) is recognized by the compiler before
using it for the test. Mimic this behaviour in the waf checks.
Thanks to gd for noticing this.

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Mon Apr 18 16:24:15 CEST 2011 on sn-devel-104

13 years agos3 autobuild: Fix CFLAG check for netgrent tests
Kai Blin [Mon, 18 Apr 2011 12:48:47 +0000 (14:48 +0200)]
s3 autobuild: Fix CFLAG check for netgrent tests

In 45ac8ffd I accidently added the wrong flag check. Fix this.
Thanks to gd for noticing.

Signed-off-by: Günther Deschner <gd@samba.org>
13 years agos3: Fix the build of vfs_gpfs.c
Volker Lendecke [Mon, 18 Apr 2011 11:53:51 +0000 (13:53 +0200)]
s3: Fix the build of vfs_gpfs.c

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Mon Apr 18 14:40:07 CEST 2011 on sn-devel-104

13 years agosamba-tool: fix machinepw command so that we use the full path to the secret database...
Matthieu Patou [Sun, 17 Apr 2011 10:15:40 +0000 (14:15 +0400)]
samba-tool: fix machinepw command so that we use the full path to the secret database and raise an error if secret can't be found

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Apr 17 13:12:27 CEST 2011 on sn-devel-104

13 years agos3: Use \0 instead of NULL when 0-terminating a string
Volker Lendecke [Sun, 17 Apr 2011 09:32:28 +0000 (11:32 +0200)]
s3: Use \0 instead of NULL when 0-terminating a string

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sun Apr 17 12:26:15 CEST 2011 on sn-devel-104

13 years agos3: guest sesssetup is only 13 words
Volker Lendecke [Sat, 2 Apr 2011 21:53:27 +0000 (23:53 +0200)]
s3: guest sesssetup is only 13 words
(cherry picked from commit 69650a2aaa8649570261df7efccb35ad76d7cfc1)

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat Apr 16 16:20:08 CEST 2011 on sn-devel-104

13 years agos3: Remove an unused variable
Volker Lendecke [Sat, 16 Apr 2011 13:27:53 +0000 (15:27 +0200)]
s3: Remove an unused variable

13 years agos3: Use tevent_req_nterror properly in a few places
Volker Lendecke [Sat, 2 Apr 2011 14:02:23 +0000 (16:02 +0200)]
s3: Use tevent_req_nterror properly in a few places

13 years agoRemove broken link.
Jelmer Vernooij [Sat, 16 Apr 2011 11:46:07 +0000 (13:46 +0200)]
Remove broken link.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sat Apr 16 14:59:15 CEST 2011 on sn-devel-104

13 years agoutil: Build samba-util without unresolved symbols.
Brad Hards [Thu, 14 Apr 2011 06:12:19 +0000 (16:12 +1000)]
util: Build samba-util without unresolved symbols.

This is useful for the Samba4 case where external users otherwise need to link to
(private) libsamba-util-common.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sat Apr 16 12:29:33 CEST 2011 on sn-devel-104

13 years agos4-heimdal: Allow any kvno to match when searching the keytab.
Andrew Bartlett [Sat, 16 Apr 2011 05:44:23 +0000 (15:44 +1000)]
s4-heimdal: Allow any kvno to match when searching the keytab.

Windows does not use a KVNO when it checks it's passwords, and MIT
doesn't check the KVNO when no acceptor identity is specified (looping
over all keys in the keytab).

Andrew Bartlett

13 years agos3-gse Allow GSSAPI wrapper to compile against Heimdal
Andrew Bartlett [Fri, 15 Apr 2011 23:22:08 +0000 (09:22 +1000)]
s3-gse Allow GSSAPI wrapper to compile against Heimdal

13 years agoselftest: Allow the top level build to run the samba4 or samba3 tests
Andrew Bartlett [Fri, 15 Apr 2011 22:47:50 +0000 (08:47 +1000)]
selftest: Allow the top level build to run the samba4 or samba3 tests

This is selected with for example

./buildtools/bin/waf test --target=samba3

Andrew Bartlett

13 years agos4-heimdal_build: Add extra HAVE defines needed for the source3 krb5 code
Andrew Bartlett [Fri, 15 Apr 2011 22:46:25 +0000 (08:46 +1000)]
s4-heimdal_build: Add extra HAVE defines needed for the source3 krb5 code

13 years agoselftest Remove selftest of the test subsystem
Andrew Bartlett [Fri, 15 Apr 2011 06:58:50 +0000 (16:58 +1000)]
selftest Remove selftest of the test subsystem

The intereactions between selftest.pl and the target are now too
complex to unit test like this any more.

Andrew Bartlett

13 years agoselftest: Move Samba4 selftest wscript to the top level
Andrew Bartlett [Fri, 15 Apr 2011 06:42:35 +0000 (16:42 +1000)]
selftest: Move Samba4 selftest wscript to the top level

13 years agoselftest Add binary mappings for samba3 selftest
Andrew Bartlett [Fri, 15 Apr 2011 06:39:53 +0000 (16:39 +1000)]
selftest Add binary mappings for samba3 selftest

This will help us have a top level 'make test', working around the
fact that the --eanble-s3build has different names for some of these
binaries, without fixing the names forever (we can just change the
mapping later).

Andrew Bartlett

13 years agoselftest: Start using the binary mapping at the python layer as well
Andrew Bartlett [Fri, 15 Apr 2011 05:17:58 +0000 (15:17 +1000)]
selftest: Start using the binary mapping at the python layer as well

13 years agoselftest: Remove duplication between BUILDIR and BINDIR
Andrew Bartlett [Fri, 15 Apr 2011 02:41:22 +0000 (12:41 +1000)]
selftest: Remove duplication between BUILDIR and BINDIR

Just have BINDIR, and have it default to ./bin

Andrew Bartlett

13 years agoselftest: Remove unused BUILDDIR_ABS environment variable
Andrew Bartlett [Fri, 15 Apr 2011 02:28:21 +0000 (12:28 +1000)]
selftest: Remove unused BUILDDIR_ABS environment variable

13 years agoselftest: Provide a single bindir_path function across all targets
Andrew Bartlett [Fri, 15 Apr 2011 02:27:30 +0000 (12:27 +1000)]
selftest: Provide a single bindir_path function across all targets

This will allow a mapping to be made between things like smbtorture4
-> smbtorture that is correct for the different build environments.

Andrew Bartlett

13 years agoTrying to track down the SMB2 error. Add an invariant test.
Jeremy Allison [Fri, 15 Apr 2011 23:30:17 +0000 (16:30 -0700)]
Trying to track down the SMB2 error. Add an invariant test.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Apr 16 02:15:38 CEST 2011 on sn-devel-104

13 years agoUse handle based xattr set if available.
Jeremy Allison [Fri, 15 Apr 2011 17:49:34 +0000 (10:49 -0700)]
Use handle based xattr set if available.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Apr 15 22:11:12 CEST 2011 on sn-devel-104

13 years agoEnsure vfs_chown_fsp() is safe against races.
Jeremy Allison [Fri, 15 Apr 2011 19:21:39 +0000 (12:21 -0700)]
Ensure vfs_chown_fsp() is safe against races.

13 years agos3-waf: only LIBNMB needs to linked against -lresolv.
Günther Deschner [Fri, 15 Apr 2011 13:36:58 +0000 (15:36 +0200)]
s3-waf: only LIBNMB needs to linked against -lresolv.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 15 17:02:16 CEST 2011 on sn-devel-104

13 years agos4-dsdb: Add more information on why we don't check the SD control
Matthieu Patou [Thu, 14 Apr 2011 19:03:50 +0000 (23:03 +0400)]
s4-dsdb: Add more information on why we don't check the SD control

Signed-off-by: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Apr 15 16:16:27 CEST 2011 on sn-devel-104

13 years agos4-dsdb: If current attribute list is empty use the one from the request
Matthieu Patou [Thu, 14 Apr 2011 18:02:48 +0000 (22:02 +0400)]
s4-dsdb: If current attribute list is empty use the one from the request

This will avoid overwritting attribute list made by upper modules.

Signed-off-by: Nadezhda Ivanova <nivanova@samba.org>
13 years agos3-build: fix the --with-profiling-data build on mac os x.
Günther Deschner [Fri, 15 Apr 2011 10:39:15 +0000 (12:39 +0200)]
s3-build: fix the --with-profiling-data build on mac os x.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri Apr 15 13:33:43 CEST 2011 on sn-devel-104

13 years agos3-waf: try to fix the non-ldap-but-krb5 build.
Günther Deschner [Fri, 15 Apr 2011 10:37:55 +0000 (12:37 +0200)]
s3-waf: try to fix the non-ldap-but-krb5 build.

Guenther

13 years agos3: Fix bug 8066, wrong output in smbget
Volker Lendecke [Thu, 7 Apr 2011 20:03:49 +0000 (22:03 +0200)]
s3: Fix bug 8066, wrong output in smbget

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Fri Apr 15 09:32:55 CEST 2011 on sn-devel-104

13 years agos3-krb5 Move #ifdef HAVE_KRB5 above #include of libcli/auth/krb5_wrap.h
Andrew Bartlett [Thu, 14 Apr 2011 22:29:45 +0000 (08:29 +1000)]
s3-krb5 Move #ifdef HAVE_KRB5 above #include of libcli/auth/krb5_wrap.h

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Apr 15 01:22:51 CEST 2011 on sn-devel-104

13 years agoEnsure change_dir_owner_to_parent() can't be raced.
Jeremy Allison [Thu, 14 Apr 2011 20:56:05 +0000 (13:56 -0700)]
Ensure change_dir_owner_to_parent() can't be raced.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 14 23:39:55 CEST 2011 on sn-devel-104

13 years agoFix bug #8083 - "inherit owner = yes" doesn't interact correctly with vfs_acl_xattr...
Jeremy Allison [Thu, 14 Apr 2011 20:20:08 +0000 (13:20 -0700)]
Fix bug #8083 - "inherit owner = yes" doesn't interact correctly with vfs_acl_xattr or vfs_acl_tdb module.

If "inherit owner = yes", pass in the directory owner and group
owner as the target for CREATOR_OWNER and CREATOR_GROUP substitutions,
and also as the owner and primary group of the new security descriptor
being applied to the object.

Jeremy.

13 years agoOptimization for change_file_owner_to_parent() and change_dir_owner_to_parent()
Jeremy Allison [Thu, 14 Apr 2011 19:49:58 +0000 (12:49 -0700)]
Optimization for change_file_owner_to_parent() and change_dir_owner_to_parent()

Don't do the chown if the owner is already correct.

13 years agos3: Fix Coverity ID 2471: UNINIT
Volker Lendecke [Tue, 12 Apr 2011 08:48:03 +0000 (10:48 +0200)]
s3: Fix Coverity ID 2471: UNINIT

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr 14 16:22:58 CEST 2011 on sn-devel-104

13 years agos3: Fix smbd with the async echo responder
Volker Lendecke [Thu, 14 Apr 2011 12:05:43 +0000 (14:05 +0200)]
s3: Fix smbd with the async echo responder

We need to read from the echo socket, pass the socket to read
from down to the read routines

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 14 15:34:36 CEST 2011 on sn-devel-104

13 years agos3-build: make sure we pick up system tdb and talloc via #include.
Günther Deschner [Thu, 14 Apr 2011 09:43:31 +0000 (11:43 +0200)]
s3-build: make sure we pick up system tdb and talloc via #include.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr 14 12:56:28 CEST 2011 on sn-devel-104

13 years agos3-includes: move readahead prototype to its only user.
Günther Deschner [Wed, 13 Apr 2011 22:52:45 +0000 (00:52 +0200)]
s3-includes: move readahead prototype to its only user.

Guenther

13 years agos3: Fix a typo
Volker Lendecke [Thu, 14 Apr 2011 09:06:00 +0000 (11:06 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Apr 14 11:55:56 CEST 2011 on sn-devel-104

13 years agolibcli/auth Fix compile on hosts without krb5
Andrew Bartlett [Thu, 14 Apr 2011 08:21:45 +0000 (18:21 +1000)]
libcli/auth Fix compile on hosts without krb5

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 14 11:08:49 CEST 2011 on sn-devel-104

13 years agolib/util Move alpha_strcpy() from s3 into common code
Andrew Bartlett [Thu, 14 Apr 2011 05:48:00 +0000 (15:48 +1000)]
lib/util Move alpha_strcpy() from s3 into common code

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 14 09:21:59 CEST 2011 on sn-devel-104

13 years agos3-auth Rename smb_krb5_open_keytab to avoid a conflict with s3
Andrew Bartlett [Thu, 14 Apr 2011 05:42:42 +0000 (15:42 +1000)]
s3-auth Rename smb_krb5_open_keytab to avoid a conflict with s3

The s3 function doesn't use the keytab_container concept.

Andrew Bartlett

13 years agolibcli/auth Move krb5 wrapper functions from s3 into common
Andrew Bartlett [Thu, 14 Apr 2011 05:40:28 +0000 (15:40 +1000)]
libcli/auth Move krb5 wrapper functions from s3 into common

This requires a small rework of the build system to ensure that the
correct #define statements are made in both the s3 and top level
builds.  We now define the various HAVE_ macros in config.h at all
times, using heimdal_build/wscript_configure when that is in use.

Andrew Bartlett

13 years agos3-lib Remove very unused (#if 0) strncpyn
Andrew Bartlett [Thu, 14 Apr 2011 02:50:19 +0000 (12:50 +1000)]
s3-lib Remove very unused (#if 0) strncpyn

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 14 06:27:31 CEST 2011 on sn-devel-104

13 years agos3-lib Remove unused string_append
Andrew Bartlett [Thu, 14 Apr 2011 02:47:45 +0000 (12:47 +1000)]
s3-lib Remove unused string_append

13 years agos3-lib Move unix_strlower and unix_strupper to their only users.
Andrew Bartlett [Thu, 14 Apr 2011 02:42:52 +0000 (12:42 +1000)]
s3-lib Move unix_strlower and unix_strupper to their only users.

13 years agos3-lib Remove unused str_ascii_charnum()
Andrew Bartlett [Thu, 14 Apr 2011 02:34:51 +0000 (12:34 +1000)]
s3-lib Remove unused str_ascii_charnum()

13 years agos3-lib Move strisnormal to it's only user in mangle_hash.c
Andrew Bartlett [Thu, 14 Apr 2011 02:31:18 +0000 (12:31 +1000)]
s3-lib Move strisnormal to it's only user in mangle_hash.c

13 years agolibcli/ldap Re-add ldap_ndr.h as a public header
Andrew Bartlett [Thu, 14 Apr 2011 02:12:00 +0000 (12:12 +1000)]
libcli/ldap Re-add ldap_ndr.h as a public header

as noticed by Brad Hards

Andrew Bartlett

13 years agos4/libcli: do not use netbios name in NTLMv2 blobs w/o spnego
Christian Ambach [Thu, 7 Apr 2011 12:05:04 +0000 (14:05 +0200)]
s4/libcli: do not use netbios name in NTLMv2 blobs w/o spnego

I have seen domain controllers rejecting NTLMv2 blobs presented to
NetrLogonSamLogonEx with LOGON_FAILURE when the MsvAvNbComputerName
was a FQDN or an IP address

I have not seen this field in NTLMv2 blobs send by Windows clients
when extended security was not available, so omitting the field
makes Samba similar to Windows.

This prevents errors with some smbtorture testcases that disable
spnego and when a target name is specified that is not a valid
netbios name.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Apr 14 02:19:08 CEST 2011 on sn-devel-104

13 years agolibcli: allow exclusion of netbios name in NTLMV2 blob
Christian Ambach [Thu, 7 Apr 2011 12:01:50 +0000 (14:01 +0200)]
libcli: allow exclusion of netbios name in NTLMV2 blob

when no hostname is given, leave away the MsvAvNbComputerName part
of the ntlmv2 blob

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos4/libcli: do not announce NT error code support when it is disabled
Christian Ambach [Wed, 9 Mar 2011 12:48:06 +0000 (13:48 +0100)]
s4/libcli: do not announce NT error code support when it is disabled

when the support of NT error codes has been disabled in the options of a
CLI connection, support for them should not be announced during
protocol negotiation

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
13 years agos3: only include smb profiling where needed.
Günther Deschner [Wed, 13 Apr 2011 22:36:23 +0000 (00:36 +0200)]
s3: only include smb profiling where needed.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Apr 14 01:31:39 CEST 2011 on sn-devel-104

13 years agos3-waf: add --with-profiling-data configure option.
Günther Deschner [Wed, 13 Apr 2011 22:17:29 +0000 (00:17 +0200)]
s3-waf: add --with-profiling-data configure option.

Guenther

13 years agos3: fix the build of --with-profiling-data.
Günther Deschner [Wed, 13 Apr 2011 22:04:08 +0000 (00:04 +0200)]
s3: fix the build of --with-profiling-data.

Guenther

13 years agos3-includes: only include acl prototypes when needed.
Günther Deschner [Wed, 13 Apr 2011 21:48:33 +0000 (23:48 +0200)]
s3-includes: only include acl prototypes when needed.

Guenther

13 years agos3-includes: absolutely no need to globally include debugparse.h
Günther Deschner [Wed, 13 Apr 2011 21:34:51 +0000 (23:34 +0200)]
s3-includes: absolutely no need to globally include debugparse.h

Guenther

13 years agos3-includes: include lib/util/debug.h headers in includes.h not smb.h
Günther Deschner [Wed, 13 Apr 2011 21:34:25 +0000 (23:34 +0200)]
s3-includes: include lib/util/debug.h headers in includes.h not smb.h

Guenther

13 years agos3-includes: remove unused schema_types enum.
Günther Deschner [Wed, 13 Apr 2011 21:33:49 +0000 (23:33 +0200)]
s3-includes: remove unused schema_types enum.

Guenther

13 years agos3-includes: move struct pipe_open_rec to srvsvc rpc server.
Günther Deschner [Wed, 13 Apr 2011 21:03:56 +0000 (23:03 +0200)]
s3-includes: move struct pipe_open_rec to srvsvc rpc server.

Guenther

13 years agoFix WAF build for sids2xids.
Jeremy Allison [Wed, 13 Apr 2011 21:49:49 +0000 (14:49 -0700)]
Fix WAF build for sids2xids.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Apr 14 00:33:53 CEST 2011 on sn-devel-104

13 years agos3: Add a test for sid2xids
Volker Lendecke [Mon, 11 Apr 2011 15:26:35 +0000 (17:26 +0200)]
s3: Add a test for sid2xids

Signed-off-by: Jeremy Allison <jra@samba.org>
13 years agos3: Add some debug to winbindd_sids_to_xids
Volker Lendecke [Tue, 12 Apr 2011 11:32:20 +0000 (13:32 +0200)]
s3: Add some debug to winbindd_sids_to_xids

Signed-off-by: Jeremy Allison <jra@samba.org>
13 years agos3: Use wbcSidsToUnixIds in create_local_token
Volker Lendecke [Wed, 23 Mar 2011 17:31:38 +0000 (18:31 +0100)]
s3: Use wbcSidsToUnixIds in create_local_token

Signed-off-by: Jeremy Allison <jra@samba.org>