samba.git
14 years agoWHATSNEW: Update changes since 3.5.0pre1. samba-3.5.0pre2
Karolin Seeger [Tue, 15 Dec 2009 07:26:11 +0000 (08:26 +0100)]
WHATSNEW: Update changes since 3.5.0pre1.

Karolin
(cherry picked from commit c289e6e3f0a1faf1dcd39d1af7825335af8a89ca)

14 years agos3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL
Volker Lendecke [Mon, 14 Dec 2009 15:48:38 +0000 (16:48 +0100)]
s3: Allow up to 20480 entries in LookupSids, as mandated by the official IDL

Seen in the wild by putting >1000 users into BUILTIN\Users
(cherry picked from commit 477edb8bdf3def827c398c4fc01dffd2071ea77e)

14 years agospoolss: fix spoolss_PrinterData size calculation.
Günther Deschner [Sat, 12 Dec 2009 01:52:41 +0000 (02:52 +0100)]
spoolss: fix spoolss_PrinterData size calculation.

Currently we were crashing in EnumPrinterDataEx when an e.g. an empty (NULL)
string for a separator file was returned.

Guenther
(cherry picked from commit e316624ddb8d4e178b03b315bfafd793e6c297c8)
(cherry picked from commit 4520862918ba2cff025b15d84922fbb08d8abbf6)

14 years agospoolss: trivial fix for spoolss_FormInfo2 IDL.
Günther Deschner [Sat, 12 Dec 2009 01:51:44 +0000 (02:51 +0100)]
spoolss: trivial fix for spoolss_FormInfo2 IDL.

Guenther
(cherry picked from commit 5ae61cfbc281f346fd3712a975c5796f9cfbc6c2)
(cherry picked from commit 43ff4f2628882f9fa51bbe37f6cbe776f62241a3)

14 years agos4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS.
Günther Deschner [Sat, 12 Dec 2009 00:51:13 +0000 (01:51 +0100)]
s4-smbtorture: check whether a returned buffer size is a multiple of 4 in RPC-SPOOLSS.

This gives a good indication where our IDL (and the s3 spoolss implementation) is still wrong.

Guenther
(cherry picked from commit 801fbd05691819ce9afadf4817bf1bf8ccc28a02)
(cherry picked from commit 73da0de2eaa2dec3ef1ebeee9dccaf81201dc7ba)

14 years agos3-selftest: enable RPC-SAMBA3-WINREG.
Günther Deschner [Thu, 10 Dec 2009 19:38:32 +0000 (20:38 +0100)]
s3-selftest: enable RPC-SAMBA3-WINREG.

Very strange we didn't run it before.

Guenther
(cherry picked from commit 31202a9dab330ed939b4ea71349c816707adff95)
(cherry picked from commit 4e218472de4c5a2b79fd6c8115e8877d253c33b5)

14 years agos3-rpcclient: allow to set offered size for enumkey command.
Günther Deschner [Wed, 9 Dec 2009 14:49:46 +0000 (15:49 +0100)]
s3-rpcclient: allow to set offered size for enumkey command.

Guenther
(cherry picked from commit c2618d2c6f8657c30cd0f68777d3f37e64172191)
(cherry picked from commit ee7944ed987bd0e4dc1315ffcac09fd2fd37bfe9)

14 years agos4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test.
Günther Deschner [Wed, 2 Dec 2009 23:35:03 +0000 (00:35 +0100)]
s4-smbtorture: add more spoolss_EnumPrinterKey tests for local NDR test.

Guenther
(cherry picked from commit dc71d1c29de521c5034fd7ebf4657610d62c2c3c)
(cherry picked from commit 2f49b911249b71c5aa68d14203e322c750acaef2)

14 years agospoolss: remove unused spoolss_StringArray2.
Günther Deschner [Thu, 10 Dec 2009 13:23:49 +0000 (14:23 +0100)]
spoolss: remove unused spoolss_StringArray2.

Guenther
(cherry picked from commit 835e7d6c98406725dc9dab891d3025b9a11b7eb9)
(cherry picked from commit 3db86bea7b4f6168b482a3f243500ffe9a3fc35a)

14 years agos4-smbtorture: fix and extend enum printerkey test.
Günther Deschner [Thu, 10 Dec 2009 13:21:12 +0000 (14:21 +0100)]
s4-smbtorture: fix and extend enum printerkey test.

Guenther
(cherry picked from commit ce33967f4a6a762e97a87513df7d33716db689fb)
(cherry picked from commit c3943161f7dd5d0c42b50f7689a2032652dc8ff6)

14 years agos3-spoolss: fix enumprinter key client and server.
Günther Deschner [Thu, 10 Dec 2009 13:20:22 +0000 (14:20 +0100)]
s3-spoolss: fix enumprinter key client and server.

Guenther
(cherry picked from commit f20effc437970d826c5bd4f047ff47e23e7a1a73)
(cherry picked from commit fc1dd12c4ac9eb2994023c4e748c12b0b41e5841)

14 years agos3: re-run make samba3-idl.
Günther Deschner [Thu, 10 Dec 2009 13:27:33 +0000 (14:27 +0100)]
s3: re-run make samba3-idl.

Guenther
(cherry picked from commit fa413d167bc3ea9aff3dcff97152ef07a1173939)
(cherry picked from commit 537e06a33e130bb8f638fe76f7c80668d801ec25)

14 years agospoolss: use spoolss_KeyNames in spoolss_EnumPrinterKey.
Günther Deschner [Thu, 10 Dec 2009 13:19:28 +0000 (14:19 +0100)]
spoolss: use spoolss_KeyNames in spoolss_EnumPrinterKey.

Guenther
(cherry picked from commit 0ecb7f6ab28d7b7c1844554289f5ae8e876b1dcf)
(cherry picked from commit 081456f03789f1f5e10bf1361fe5d5fa776c8fa4)

14 years agospoolss: add spoolss_KeyNames union.
Günther Deschner [Thu, 10 Dec 2009 13:18:46 +0000 (14:18 +0100)]
spoolss: add spoolss_KeyNames union.

Guenther
(cherry picked from commit cf2561473f7bd0bcef5c562c1e901d4ad17e6ee3)
(cherry picked from commit 0668b8bd9c37de6df1d2af05b04ea2da441c8b20)

14 years agos4-smbtorture: enhance spoolss_EnumPrinterKey torture test.
Günther Deschner [Wed, 9 Dec 2009 14:31:51 +0000 (15:31 +0100)]
s4-smbtorture: enhance spoolss_EnumPrinterKey torture test.

This demonstrates that s3 still does not have that call implemented correctly.

Guenther
(cherry picked from commit d2f13dd6882079f82d45847eda72c75d6de55a21)
(cherry picked from commit d9a3bc084dafa7616c617fcaae5ed78fd27c3521)

14 years agos3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code.
Günther Deschner [Tue, 8 Dec 2009 13:46:10 +0000 (14:46 +0100)]
s3-spoolss: use SPOOLSS_ARCHITECTURE_ALL in driver enum server code.

Guenther
(cherry picked from commit e14fb8f913e35db96d8d7985e505f96150d9ce6b)
(cherry picked from commit 085f4137fbbceb8297dadcea6cf17cc73553cf00)

14 years agospoolss: add more spoolss architectures to IDL.
Günther Deschner [Tue, 1 Dec 2009 23:59:21 +0000 (00:59 +0100)]
spoolss: add more spoolss architectures to IDL.

Guenther
(cherry picked from commit fb3b0987f7f9d7026701ab8b3034ff6084ae2143)
(cherry picked from commit df1b90465c7b78c6d85cc59d087d21fd76880ad8)

14 years agospoolss: fix spoolss_DriverInfo8 IDL.
Günther Deschner [Mon, 7 Dec 2009 17:55:08 +0000 (18:55 +0100)]
spoolss: fix spoolss_DriverInfo8 IDL.

found by RPC-SPOOLSS torture teset.

Guenther
(cherry picked from commit efdd60fd9d0b36f924ef467040a1c5e1de5e68c2)

14 years agos4-smbtorture: make level 8 the reference for PrinterDriverEnum test.
Günther Deschner [Mon, 7 Dec 2009 18:26:45 +0000 (19:26 +0100)]
s4-smbtorture: make level 8 the reference for PrinterDriverEnum test.

Guenther
(cherry picked from commit 5e8e5dfe889a63747ffbd9429d8115e1715f53e6)
(cherry picked from commit c65e5dec09c14454b6d5ae22bb8aa21c414e36d7)

14 years agos3-spoolss: cleanup _spoolss_EnumPrinterDrivers().
Günther Deschner [Mon, 7 Dec 2009 15:19:26 +0000 (16:19 +0100)]
s3-spoolss: cleanup _spoolss_EnumPrinterDrivers().

Guenther
(cherry picked from commit 7770d1492bad12e778f9f4e0503dcf00983b2bb1)
(cherry picked from commit 9524600b322b271dcf23c2caa3996d7c2cb29824)

14 years agos3-spoolss: remove unused architecture from fill_printer_driver_info1().
Günther Deschner [Mon, 7 Dec 2009 15:18:55 +0000 (16:18 +0100)]
s3-spoolss: remove unused architecture from fill_printer_driver_info1().

Guenther
(cherry picked from commit 0efbd932b63af0232547571b249fa54de5e1bce2)
(cherry picked from commit 3dbb7c7c2b8be45f55431fde0999d2bef312d60a)

14 years agos3-spoolss: remove ridiculous amount of duplicate driver code.
Günther Deschner [Thu, 3 Dec 2009 18:42:22 +0000 (19:42 +0100)]
s3-spoolss: remove ridiculous amount of duplicate driver code.

Guenther
(cherry picked from commit af08962c94b8f91c8a509881dece5720e914bc45)
(cherry picked from commit c466ca9ad382bbc0e5617e3e3de9143620c9e7ff)

14 years agos3-spoolss: fully support level 8 drivers.
Günther Deschner [Thu, 3 Dec 2009 18:11:53 +0000 (19:11 +0100)]
s3-spoolss: fully support level 8 drivers.

Guenther
(cherry picked from commit 1c9eba40ae8b329182fc3c4f073d1f18b8bad986)
(cherry picked from commit 0263b52bee6bdc038b6440c3883bfd6aaac76409)

14 years agos3-spoolss: use driver level info8 everywhere in spoolss server internally.
Günther Deschner [Fri, 27 Nov 2009 00:49:08 +0000 (01:49 +0100)]
s3-spoolss: use driver level info8 everywhere in spoolss server internally.

Guenther
(cherry picked from commit 35c50dcce35622b6f2806b9ae7f6ff6b54b6cbbf)
(cherry picked from commit 222f0bc0c233f33ae0d4dbdc5e4937c20cb47eaf)

14 years agos4-smbtorture: fill in COMPARE_STRING_ARRAY macro in spoolss driver test.
Günther Deschner [Tue, 8 Dec 2009 09:21:28 +0000 (10:21 +0100)]
s4-smbtorture: fill in COMPARE_STRING_ARRAY macro in spoolss driver test.

Guenther
(cherry picked from commit 35c067782b1dcd354dd825af3e853adf4c74e1d1)
(cherry picked from commit 52361a5c66773e2032b5b9a67b5c3d47ea0c3430)

14 years agos3:docs: Fix 'make manpages3'.
Karolin Seeger [Mon, 14 Dec 2009 07:58:50 +0000 (08:58 +0100)]
s3:docs: Fix 'make manpages3'.

Karolin
(cherry picked from commit f740bdc47bb53dc6d17e48e1ad9c6f5fdd9ff102)
(cherry picked from commit d8b3be2ecff99218e10616b1e3391830da5d55f5)

14 years agoWHATSNEW: Update changes since Samba 3.5.0pre1.
Karolin Seeger [Mon, 14 Dec 2009 07:39:54 +0000 (08:39 +0100)]
WHATSNEW: Update changes since Samba 3.5.0pre1.

Karolin
(cherry picked from commit 8804b13c96dd0d8334762f968a349d1e432a1acc)

14 years agos3: Fix a very embarrassing build failure
Volker Lendecke [Sat, 12 Dec 2009 15:58:31 +0000 (16:58 +0100)]
s3: Fix a very embarrassing build failure
(cherry picked from commit d2453d9a944e2d8ecebeecb94014057dd4fc0fd6)

14 years agos3:docs: document ldap deref
Björn Jacke [Fri, 11 Dec 2009 12:28:31 +0000 (13:28 +0100)]
s3:docs: document ldap deref
(cherry picked from commit 54d072b83c53f393253052efd5197b48fac61acb)

14 years agos3: add LDAP Alias Dereferencing support
Björn Jacke [Thu, 10 Dec 2009 20:00:26 +0000 (21:00 +0100)]
s3: add LDAP Alias Dereferencing support

Thanks to Dan Cox for initial patch for 3.0. This closes #2350.

The default for "ldap deref" is "auto" which means the LDAP library's default
behaviour will be used and samba does not set any dereferencing parameter by
itself.
(cherry picked from commit 8adbc166b230b37ff18ba70f2280a9a729240ff1)

14 years agos3: keep subsecond times on cross-filesystem moves and don't follow links
Björn Jacke [Wed, 9 Dec 2009 01:06:17 +0000 (02:06 +0100)]
s3: keep subsecond times on cross-filesystem moves and don't follow links
(cherry picked from commit faccec7b97b469b170932f27d8b7e0baf985a909)

14 years agos3:packaging: Fix version detection.
Karolin Seeger [Thu, 10 Dec 2009 13:57:08 +0000 (14:57 +0100)]
s3:packaging: Fix version detection.

Adapted from 728b01fc03.
Thanks god I was not root! It would have delted /*!

Karolin
(cherry picked from commit 0604c696a05773a439538d88f1b45aa6637766a7)
(cherry picked from commit fd30552aab88572b2d5944b9b87ee8ca76d29b35)

14 years agos3:packaging: Fix source dir.
Karolin Seeger [Thu, 10 Dec 2009 13:26:58 +0000 (14:26 +0100)]
s3:packaging: Fix source dir.

Karolin
(cherry picked from commit 85e79a2a03e8c1c6275363c39b0fa71283214562)
(cherry picked from commit 1ed3172d10ca96816ec548996953579ec55da660)

14 years agos3:packaging: Fix typo in comment.
Karolin Seeger [Thu, 10 Dec 2009 13:08:43 +0000 (14:08 +0100)]
s3:packaging: Fix typo in comment.

Karolin
(cherry picked from commit b5011ba2c897fa177f1e22dde075055b9ffd271d)
(cherry picked from commit 3b812b134d819097df51bb20bdb4fd856f4ad00d)

14 years agos3: check for PAM_RADIO_TYPE.
Bo Yang [Thu, 10 Dec 2009 11:29:24 +0000 (19:29 +0800)]
s3: check for PAM_RADIO_TYPE.

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit c7e3a2dc319cc6504356be7fa7970917404a69b5)
(cherry picked from commit fa572721577732c1b5d1cd32de4479a34c895919)

14 years agos3: Fix build on non-linux platform.
Bo Yang [Thu, 10 Dec 2009 09:20:03 +0000 (17:20 +0800)]
s3: Fix build on non-linux platform.

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit b386c3311d8c05ccbd075ab86be2ddace335b73b)
(cherry picked from commit 9a522cd96d66f6a6cf5f483fb8928982bbe95ea4)

14 years agos3: Give the user a chance to change password when password will expire soon.
Bo Yang [Thu, 10 Dec 2009 06:30:13 +0000 (14:30 +0800)]
s3: Give the user a chance to change password when password will expire soon.

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit f7723293a07d1b7a4f3476939590fa8db6080d06)
(cherry picked from commit 7097f6101e52220f7ff0ef821efa5b1810b2604d)

14 years agos3:doc: make dos filetimes description less contradictory
Björn Jacke [Tue, 8 Dec 2009 20:32:51 +0000 (21:32 +0100)]
s3:doc: make dos filetimes description less contradictory
(cherry picked from commit 2a6391bc43cf2550731039bf158d561b307c9c58)

14 years agos3: make sys_posix_fallocate more generic
Björn Jacke [Tue, 8 Dec 2009 20:13:19 +0000 (21:13 +0100)]
s3: make sys_posix_fallocate more generic

this is in preparation for other preallocation methods to be introduced.
(cherry picked from commit 39be2d18a24176b9300834a0552180cdfb11ca5f)

14 years agos3: allocate only "new" space, not "old" sparse space in the posix_fallocate path
Björn Jacke [Tue, 8 Dec 2009 09:30:03 +0000 (10:30 +0100)]
s3: allocate only "new" space, not "old" sparse space in the posix_fallocate path

this makes the posix_fallocate path work analogous to the manual allocate path.
(cherry picked from commit e9fb2807037919a598e17d24def4897e0cbfe19c)

14 years agoWHATSNEW: Add changes since 3.5.0pre1.
Karolin Seeger [Tue, 8 Dec 2009 09:54:26 +0000 (10:54 +0100)]
WHATSNEW: Add changes since 3.5.0pre1.

Karolin
(cherry picked from commit a2c4f88b3e4329bf82f3236b0972babfe8df4532)

14 years agos3: check if glibc has broken posix_fallocate
Björn Jacke [Fri, 4 Dec 2009 22:26:47 +0000 (23:26 +0100)]
s3: check if glibc has broken posix_fallocate
(cherry picked from commit 5062e190ed27e16145d9275533b6dd5bcb10209e)

14 years agopackaging(RHEL-CTDB): clean some commented out lines from the files sections
Michael Adam [Mon, 7 Dec 2009 13:27:28 +0000 (14:27 +0100)]
packaging(RHEL-CTDB): clean some commented out lines from the files sections

Michael
(cherry picked from commit a18692ddcffbe3faf1abc50091c9481e53e8c801)

14 years agopackaging(RHEL-CTDB): explicitly list library versions in samba-winbind-32bit
Michael Adam [Mon, 7 Dec 2009 13:26:03 +0000 (14:26 +0100)]
packaging(RHEL-CTDB): explicitly list library versions in samba-winbind-32bit

Michael
(cherry picked from commit 0cc9a21c6f352765c1a3760d5f8eebd4dc6f8b8e)

14 years agopackaging(RHEL-CTDB): explicitly list library versions in samba-common
Michael Adam [Mon, 7 Dec 2009 13:25:32 +0000 (14:25 +0100)]
packaging(RHEL-CTDB): explicitly list library versions in samba-common

Michael
(cherry picked from commit a135a15a2bb5c56089715b842754c34b3ba9d55e)

14 years agopackaging(RHEL-CTDB): explicitly list all packaged idmap/nss-info/charset modules
Michael Adam [Mon, 7 Dec 2009 13:20:24 +0000 (14:20 +0100)]
packaging(RHEL-CTDB): explicitly list all packaged idmap/nss-info/charset modules

in the samba-common package.
This is to  better be able to catch regressions or
build problems.

Michael
(cherry picked from commit ae0e6ab4c7bfd1547f0b0252a66523b9ab47f9c7)

14 years agopackaging(RHEL-CTDB): explicitly list all the vfs modules in the main package
Michael Adam [Mon, 7 Dec 2009 13:16:15 +0000 (14:16 +0100)]
packaging(RHEL-CTDB): explicitly list all the vfs modules in the main package

Instead of the wildcard list, to better control regressions or
build problems.

Michael
(cherry picked from commit d420b308c1640d96fd9d2b8fe2b4b8ac5071b38d)

14 years agopackaging(RHEL-CTDB): add some checks to test the built smbd
Michael Adam [Mon, 7 Dec 2009 13:12:05 +0000 (14:12 +0100)]
packaging(RHEL-CTDB): add some checks to test the built smbd

Test whether some required features have been built into smbd.
Can be extended...

Michael
(cherry picked from commit c6435cd8b36320b27a2a9940380daa776536e3e6)

14 years agopackaging(RHEL-CTDB): make everything instead of all in the build stage
Michael Adam [Mon, 7 Dec 2009 13:11:32 +0000 (14:11 +0100)]
packaging(RHEL-CTDB): make everything instead of all in the build stage

Michael
(cherry picked from commit 1aec01077944b6a2762624895bac42333ca36963)

14 years agoparent_sd can never be null in this function, so don't
Jeremy Allison [Mon, 7 Dec 2009 22:41:09 +0000 (14:41 -0800)]
parent_sd can never be null in this function, so don't
check for it.

Jeremy.
(cherry picked from commit a24631007ea4dcf25e777070d783608f988a5f94)
(cherry picked from commit eea09855f381d435b76298069b67e2d331b41f8c)

14 years agoHopefullt final fix for 6802 - acl_xattr.c module: A created folder does not properly...
Jeremy Allison [Mon, 7 Dec 2009 22:36:12 +0000 (14:36 -0800)]
Hopefullt final fix for 6802 - acl_xattr.c module: A created folder does not properly inherit permissions from parent and 6938 - No hook exists to check creation rights when using acl_xattr module

Volker was right (dammit :-). It's much easier to catch
this case in the create_file() vfs call instead of trying
to do everything inside open() and mkdir(). Hook all these
functions to gain the desired effect.
Jeremy.
(cherry picked from commit 12bac42a93cd6afd3cd29460b97bbd61852a9d44)
(cherry picked from commit aab1e424db3134db2d78553d51859dc79d1a8831)

14 years agos3: let gencache_init() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:46:34 +0000 (16:46 +0100)]
s3: let gencache_init() use tdb_check()

If the check fails we try to clear the tdb and start
with an empty cache.

metze
(cherry picked from commit 909cd2617fa1c170183664af1fc4253af2dc2f21)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1a17c8ffe0f17138e45b57a82d5b4a3c73628bca)

14 years agos3: let netsamlogon_cache_init() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:34:08 +0000 (16:34 +0100)]
s3: let netsamlogon_cache_init() use tdb_check()

If the check fails we try to unlink the old file and
start with an empty cache.

metze
(cherry picked from commit 8f19c08072a7a6036d59cf6c2ca6ce17c74b7635)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 8f737c3cd154f394f821b0e34ced3f84ff8773c4)

14 years agos3: let tdb_validate_child() use tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:32:42 +0000 (16:32 +0100)]
s3: let tdb_validate_child() use tdb_check()

metze
(cherry picked from commit 6f6608c2aa6122c87ea1e8a937708d08e6c5785e)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 66847adf072606e6519a1de1ede3aa26d9e041ba)

14 years agos3: require tdb 1.1.7 with tdb_check()
Stefan Metzmacher [Fri, 4 Dec 2009 15:59:39 +0000 (16:59 +0100)]
s3: require tdb 1.1.7 with tdb_check()

metze
(cherry picked from commit 886fe5b92082c2d18f97ff0bdcced52d38f344ca)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 7a16b95703bf063b2c02133c97a06f7ab0e85963)

14 years agos3:docs: Document "directory name cache size".
Karolin Seeger [Mon, 7 Dec 2009 15:28:30 +0000 (16:28 +0100)]
s3:docs: Document "directory name cache size".

Karolin
(cherry picked from commit 5055ba140d03189a3c8181d57ad920e68c6e387c)
(cherry picked from commit a9077c77b7119fb15cbc74d9b160a363932b0bde)

14 years agos3: de-deprecate "write cache size" to prevent its removal without a proper alternative
Volker Lendecke [Mon, 7 Dec 2009 15:24:08 +0000 (16:24 +0100)]
s3: de-deprecate "write cache size" to prevent its removal without a proper alternative
(cherry picked from commit 950857f6ba7f0ff4e238b600fc0e6c10c972e582)

14 years agocreate-tarball: Readd RFCs (fixes the merged build).
Karolin Seeger [Mon, 7 Dec 2009 15:06:29 +0000 (16:06 +0100)]
create-tarball: Readd RFCs (fixes the merged build).

See http://lists.samba.org/archive/samba-technical/2009-December/068235.html
for more information.

Karolin
(cherry picked from commit 08b692828ed6a9929dc6098fabc8aa47a0e32f93)

14 years agos4-smbtorture: disable some spoolss printerdata tests which s3 does not pass at the...
Günther Deschner [Mon, 7 Dec 2009 13:38:24 +0000 (14:38 +0100)]
s4-smbtorture: disable some spoolss printerdata tests which s3 does not pass at the moment.

Guenther
(cherry picked from commit 8de6f7178c220d0a529ed91f87760e8d172448d2)
(cherry picked from commit 5dde3686d951db49ae6a06a31dc43fd5c0d3162f)

14 years agos3: fix net and rpcclient after setprinterdataex changes.
Günther Deschner [Mon, 7 Dec 2009 10:54:26 +0000 (11:54 +0100)]
s3: fix net and rpcclient after setprinterdataex changes.

Guenther
(cherry picked from commit c85ed0054e67413ffcd169c405ee4feda3555628)
(cherry picked from commit 3f3c04e963d5532340b306ea4e875df2b03985d4)

14 years agos4-smbtorture: fix RPC-SPOOLSS after _spoolss_SetPrinterDataEx IDL change.
Günther Deschner [Fri, 4 Dec 2009 23:58:45 +0000 (00:58 +0100)]
s4-smbtorture: fix RPC-SPOOLSS after _spoolss_SetPrinterDataEx IDL change.

Guenther
(cherry picked from commit 123d8d1c2c8ea214fa1a216c92ca1a3fc1b4d6d0)
(cherry picked from commit f67637b63dce30b07fc95bd80ace36c9defbbb23)

14 years agos3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.
Günther Deschner [Mon, 7 Dec 2009 10:28:56 +0000 (11:28 +0100)]
s3-spoolss: let _spoolss_DeletePrinterData call into _spoolss_DeletePrinterDataEx.

Guenther
(cherry picked from commit ef9d6580efc55ee040458b7cd76ebdc2e1276e98)
(cherry picked from commit 50df20e01590533dbd086393ddf95835db2b71ac)

14 years agos3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:56:55 +0000 (00:56 +0100)]
s3-spoolss: let _spoolss_SetPrinterData call into _spoolss_SetPrinterDataEx.

Guenther
(cherry picked from commit 167dca0cbf18baf40dd923f6f92421123d34b5a3)
(cherry picked from commit a987a9f33a9acba97764d1b43c106727ff653da3)

14 years agos3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:52:28 +0000 (00:52 +0100)]
s3-spoolss: let _spoolss_GetPrinterData call into _spoolss_GetPrinterDataEx.

Guenther
(cherry picked from commit 778124ea32ecc9d2404ef6abd8af9d14e6320f3a)
(cherry picked from commit 41232506678c06b64f193a0fae76b2bca862bd3f)

14 years agospoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.
Günther Deschner [Fri, 4 Dec 2009 23:50:18 +0000 (00:50 +0100)]
spoolss: rework spoolss_GetPrinterDataEx and spoolss_SetPrinterDataEx.

Guenther
(cherry picked from commit 08823166a13d5ec3027b0c5a0db5e684b8e3c3b6)
(cherry picked from commit b35133dcc618e169045e078c53873bf0694f74f0)

14 years agos3-spoolss: a default printer should have at least a "PrintDriverData" key.
Günther Deschner [Fri, 4 Dec 2009 16:22:25 +0000 (17:22 +0100)]
s3-spoolss: a default printer should have at least a "PrintDriverData" key.

Guenther
(cherry picked from commit a367b2b5df30b92ccacc4fc15c07c1fd955c7d5b)
(cherry picked from commit 8af757fe7c95ffba02d00d010fa5360943724574)

14 years agos3-winreg: fill in some inline comments.
Günther Deschner [Fri, 4 Dec 2009 12:33:49 +0000 (13:33 +0100)]
s3-winreg: fill in some inline comments.

Guenther
(cherry picked from commit 1bc83b984d6f074a5a7c7d3e7f6de4a2278fee4c)
(cherry picked from commit 7c646c39d7b05fa3c98edf012bca0e8057e70d57)

14 years agos3-winreg: remove trailing whitespace.
Günther Deschner [Fri, 4 Dec 2009 12:29:08 +0000 (13:29 +0100)]
s3-winreg: remove trailing whitespace.

Guenther
(cherry picked from commit 5d46530053fa7728d1d4903a3d92f238202ab0d8)
(cherry picked from commit d9717f661ed06e833ba895831f59424476ed4831)

14 years agos4-smbtorture: heavily expand printerdata tests in RPC-SPOOLSS.
Günther Deschner [Fri, 4 Dec 2009 01:54:33 +0000 (02:54 +0100)]
s4-smbtorture: heavily expand printerdata tests in RPC-SPOOLSS.

Including new tests for:
- spoolss_SetPrinterDataEx
- spoolss_DeletePrinterDataEx
- spoolss_DeletePrinterKey

Guenther
(cherry picked from commit 02fe8630395879ffa761d75c7d7b75fc7cda5e4c)
(cherry picked from commit 32bec5e5f09eec603b4fc366707bbd320dc804a3)

14 years agos3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx.
Günther Deschner [Thu, 3 Dec 2009 22:23:36 +0000 (23:23 +0100)]
s3-spoolss: handle SEC_FLAG_MAXIMUM_ALLOWED in spoolss_OpenPrinterEx.

In case someone (smbtorture4) requests SEC_FLAG_MAXIMUM_ALLOWED, translate it
to a request of PRINTER_ACCESS_ADMINISTER.

Guenther
(cherry picked from commit 459a968fb4d6f96ea7f310f331d3547e2e466d6a)
(cherry picked from commit e96c22d8d16a520c2ee9f49f71c26d1cb86f148f)

14 years agos4-smbtorture: check more WERRORs in RPC-SPOOLSS.
Günther Deschner [Thu, 3 Dec 2009 21:38:38 +0000 (22:38 +0100)]
s4-smbtorture: check more WERRORs in RPC-SPOOLSS.

Guenther
(cherry picked from commit 2f0548fd98ccbe9695d4e6ae0e21e5ceca76ac68)
(cherry picked from commit cfd570a0128db42429a48ab6001f20d99d8dbfeb)

14 years agos4-smbtorture: call test_EnumPrinterDrivers with architecture in RPC-SPOOLSS.
Günther Deschner [Thu, 3 Dec 2009 21:05:35 +0000 (22:05 +0100)]
s4-smbtorture: call test_EnumPrinterDrivers with architecture in RPC-SPOOLSS.

Guenther
(cherry picked from commit 4e20a6f83b981ae0948ce1b9ec0a39162b38b512)
(cherry picked from commit 3f0de03ca9d6e075e10943d9e511134231809b16)

14 years agos3:auth: Fix typo in debug message.
Karolin Seeger [Mon, 7 Dec 2009 13:38:18 +0000 (14:38 +0100)]
s3:auth: Fix typo in debug message.

Karolin
(cherry picked from commit 71018ebe5303ca6e0f3e3e4b96ae45fb32d3e195)
(cherry picked from commit 626ae39f3952087e05cbcd42a049119860072bc8)

14 years agoexamples: Fix the build of the example VFS modules.
Karolin Seeger [Mon, 7 Dec 2009 09:15:49 +0000 (10:15 +0100)]
examples: Fix the build of the example VFS modules.

Karolin
(cherry picked from commit fe01e0e1a5a07ddefdc09f24d44c7e66886405b8)
(cherry picked from commit cef50766b3e622c12890811cd048ba4cec36bb96)

14 years agostreamline some log levels for invalid servicenames
Christian Ambach [Wed, 2 Dec 2009 19:06:37 +0000 (20:06 +0100)]
streamline some log levels for invalid servicenames

I don't think we need to log the fact that a user gave a wrong sharename in Explorer with the highest log level.
The level of this was not very consistent:
service.c: DEBUG(3,("find_service() failed to find service %s\n", service));
service.c: DEBUG(0,("%s (%s) couldn't find service %s\n",
smb2_tcon.c: DEBUG(1,("smbd_smb2_tree_connect: couldn't find service %s\n",

This changes the last two to 3 as the first one.

Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
(cherry picked from commit 1ae8145c66bcfc79ce5e554a057b410339868b8f)

14 years agos3: Fix a const discard warning
Volker Lendecke [Sun, 6 Dec 2009 11:50:51 +0000 (12:50 +0100)]
s3: Fix a const discard warning
(cherry picked from commit d8a40f1227132d49051ddbc2bb9727ee3956d86c)

14 years agos3: talloc_array_length deals file with a NULL argument
Volker Lendecke [Sun, 6 Dec 2009 11:50:25 +0000 (12:50 +0100)]
s3: talloc_array_length deals file with a NULL argument
(cherry picked from commit 0249e477edee01ba4185db8ffada537e8bae8e79)

14 years agos3: Small simplification: qsort deals fine with just one entry
Volker Lendecke [Sun, 6 Dec 2009 11:49:46 +0000 (12:49 +0100)]
s3: Small simplification: qsort deals fine with just one entry
(cherry picked from commit 3c5e571a2f1b6d32b735e26949b9739fc960c22b)

14 years agos3: Simplify usr_info_cmp by calling timeval_compare()
Volker Lendecke [Sun, 6 Dec 2009 11:49:09 +0000 (12:49 +0100)]
s3: Simplify usr_info_cmp by calling timeval_compare()
(cherry picked from commit 4b3ad2547c452dd9493fe63e056346a5f7561a37)

14 years agos3: Add rpcclient wkssvc_enumerateusers
Volker Lendecke [Sun, 6 Dec 2009 11:40:44 +0000 (12:40 +0100)]
s3: Add rpcclient wkssvc_enumerateusers
(cherry picked from commit d8c52227224771cbe55a469eec7530f91dc18e26)

14 years agos3: Complete support for NetWkstaGetInfo/NetWkstaEnumUsers
Ian Puleston [Sun, 22 Nov 2009 23:00:00 +0000 (00:00 +0100)]
s3: Complete support for NetWkstaGetInfo/NetWkstaEnumUsers
(cherry picked from commit 381cf92adb3710d350e39f4a5cd72265a67e3b0a)

14 years agos3: First cut at _wkssvc_NetWkstaEnumUsers
Volker Lendecke [Mon, 3 Aug 2009 15:27:11 +0000 (17:27 +0200)]
s3: First cut at _wkssvc_NetWkstaEnumUsers

This needs access checks!
(cherry picked from commit 34fc32b9a71334217e4661525ed466d5d57642d2)

14 years agos3: Support NetWkstaGetInfo 101 and 102
Volker Lendecke [Mon, 3 Aug 2009 14:52:01 +0000 (16:52 +0200)]
s3: Support NetWkstaGetInfo 101 and 102
(cherry picked from commit 7ead9dd7e8eece7b09d33fdc2ed0f83da0b41e7d)

14 years agopackaging(RHEL-CTDB): package dbwrap_tool and dbwrap_torture in the common pkg
Michael Adam [Fri, 4 Dec 2009 22:29:22 +0000 (23:29 +0100)]
packaging(RHEL-CTDB): package dbwrap_tool and dbwrap_torture in the common pkg

Michael
(cherry picked from commit ef33b60d1a22d7200c3047ca817cd78f3f9dea07)

14 years agos3:dbwrap_ctdb: increase the number of commit retries 5-->100
Michael Adam [Fri, 4 Dec 2009 13:53:05 +0000 (14:53 +0100)]
s3:dbwrap_ctdb: increase the number of commit retries 5-->100

This is to cope with timeouts when recoveries and transactions collide.
Maybe 100 is too hight, but 10 or even 20 have been too low in a
very busy environment.

Michael
(cherry picked from commit 97eb53b432e8b16e55b0dccac7acbb2e40467dc6)

14 years agos3:dbwrap_ctdb: increase the rsn of the __transaction_lock__ when storing
Michael Adam [Fri, 4 Dec 2009 13:49:53 +0000 (14:49 +0100)]
s3:dbwrap_ctdb: increase the rsn of the __transaction_lock__ when storing

so that it is correctly handled by recoveries.
Also set the dmaster explicitly.

Michael
(cherry picked from commit 8e4f774bff9926567006cdc263fa76fd8b703b63)

14 years agos3: Fix explicit stat64 support
Volker Lendecke [Sat, 5 Dec 2009 13:27:04 +0000 (14:27 +0100)]
s3: Fix explicit stat64 support
(cherry picked from commit c81f6e519e1f976fce0896fa7b9e29c412411e13)

14 years agoMake Samba3 pass the RAW-LOCK test as Windows.
Jeremy Allison [Fri, 4 Dec 2009 22:04:08 +0000 (14:04 -0800)]
Make Samba3 pass the RAW-LOCK test as Windows.

Implement the win7 NT_STATUS_INVALID_LOCK_RANGE.
Make smbd behave as Windows does in canceling locks.

Jeremy.
(cherry picked from commit 32915ceefc718621e2e9b17fee97da82744ab67a)
(cherry picked from commit 3ec654de706f4bd2576245333cc98105388a3c10)

14 years agos3: bug #6967: Prevent glibc error on net ads join:
Jim McDonough [Fri, 4 Dec 2009 17:31:53 +0000 (12:31 -0500)]
s3: bug #6967: Prevent glibc error on net ads join:
 talloc()ed memory should not be SAFE_FREE()ed.

Signed-off-by: Jim McDonough <jmcd@samba.org>
(cherry picked from commit 242d1179f92666e7548cb2f26695a0306e20d64c)

14 years agos3 aclocal.m4: Fix iconv checks, clean up m4 code
Kai Blin [Fri, 4 Dec 2009 08:47:25 +0000 (09:47 +0100)]
s3 aclocal.m4: Fix iconv checks, clean up m4 code

The check for iconv requiring giconv.h and libgiconv as well as
the check for iconv requiring biconv.h and libbiconv were using the wrong
variable to check for previous successful test results. This caused the checks
to always fall back to libbiconv on systems where that library was available.

In the course of fixing this, I had to clean up the indentation in that piece of
code, and I also rewrote/added some comments.

Many thanks to Tsurutani Naoki <turutani@scphys.kyoto-u.ac.jp> for the initial
patch and diagnosis.
(cherry picked from commit f5aff324cb9d965bbc75634596c3c40ffc588183)
(cherry picked from commit 217a02b4a6432b1e232fe8dd0b022bc85ab47e56)

14 years agoMake sure we're not using the old smb_fname data.
Jeremy Allison [Fri, 4 Dec 2009 01:44:38 +0000 (17:44 -0800)]
Make sure we're not using the old smb_fname data.

Jeremy.
(cherry picked from commit 66c968778d74280bf36342e76c80b617e47ebde5)
(cherry picked from commit d0aaff97a20adf6b4c8406f2a21d45018cf5b2cb)

14 years agoRemove smb_fname duplicates that just keep the same information as in fsp->fsp_name.
Jeremy Allison [Fri, 4 Dec 2009 00:45:35 +0000 (16:45 -0800)]
Remove smb_fname duplicates that just keep the same information as in fsp->fsp_name.

Moving towards making VFS_OPEN/VFS_MKDIR/VFS_RMDIR
handle based...
Jeremy.
(cherry picked from commit 3fe7dfd1d90374a2e06e1683b8f2c702c471c833)
(cherry picked from commit cb1f641d2b9c758cc4dc8b4edb10f27543ae7a98)

14 years agoRefactor reply_rmdir to use handle based code. All
Jeremy Allison [Thu, 3 Dec 2009 21:01:10 +0000 (13:01 -0800)]
Refactor reply_rmdir to use handle based code. All
calls are now handle based. Put rmdir into close.c
and make it private.
Jeremy.
(cherry picked from commit 91e0bdd86c9c14f6b9b190db8ce6ec162ce79692)
(cherry picked from commit b9e71c705242a02fc70bbe8db7b88fdd76179663)

14 years agoѕ3: remove superfluous option check
Björn Jacke [Thu, 3 Dec 2009 01:32:47 +0000 (02:32 +0100)]
ѕ3: remove superfluous option check

this function is only called when strict alloc is set, no reason to check that twice.
(cherry picked from commit f39f894ed45a3cfbbc73fe67364f18908e8260fe)

14 years agos3: Fix crash in winbindd;(bug#6879).
Bo Yang [Fri, 4 Dec 2009 04:53:38 +0000 (12:53 +0800)]
s3: Fix crash in winbindd;(bug#6879).

Signed-off-by: Bo Yang <boyang@samba.org>
(cherry picked from commit cdb68bd2b61147df77b7f2de3fb4e29be07e7bd9)
(cherry picked from commit 3c4f74bbcbe7c9c7e50865adac2db70e48a2d82f)

14 years agoRemove unneeded argument from can_set_delete_on_close(). Ensure
Jeremy Allison [Thu, 3 Dec 2009 02:06:40 +0000 (18:06 -0800)]
Remove unneeded argument from can_set_delete_on_close(). Ensure
can_set_delete_on_close() is correctly called before any setting
of the disposition bit (clean up the do_unlink() call).
Jeremy.
(cherry picked from commit dfcc4115ddc7c3bf7a69d7eb747c096cd217b8a6)
(cherry picked from commit baa4727b243ff2dfb78d3dd5fd29c8e9a3667c56)

14 years agos3-selftest: run LOCAL-NDR when running make selftest.
Günther Deschner [Wed, 2 Dec 2009 23:46:47 +0000 (00:46 +0100)]
s3-selftest: run LOCAL-NDR when running make selftest.

Guenther
(cherry picked from commit 9a3d9abdd8e9737245e3cdd7f31d453c2062dba9)
(cherry picked from commit bd99ed71ed29012bddb815169166d7165e6167a7)

14 years agos4-smbtorture: be very strict in checking spools_EnumPrinterKey results.
Günther Deschner [Wed, 2 Dec 2009 22:38:05 +0000 (23:38 +0100)]
s4-smbtorture: be very strict in checking spools_EnumPrinterKey results.

Guenther
(cherry picked from commit 450211b61016a4fed71eb116c1b526af0f365f13)
(cherry picked from commit 6b8158ddfdce65e32ca39d8cc2c1d7b215cd22ff)

14 years agospoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.
Günther Deschner [Wed, 2 Dec 2009 20:26:10 +0000 (21:26 +0100)]
spoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.

This call is just driving me nuts :-)

Guenther
(cherry picked from commit f32ccc321a5467401781a0e2d4621175b6256368)
(cherry picked from commit 0005a36b14808b67a4b97376b8305bd3145ea90a)

14 years agosamba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.
Günther Deschner [Wed, 2 Dec 2009 13:25:31 +0000 (14:25 +0100)]
samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.

This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.

Guenther
(cherry picked from commit 5f60855ba2eb822dcb867378ff09278c42931b89)
(cherry picked from commit 91e9afbcd65500a37f947442955d9ca3e080982e)