From a282455978eb28855317ec6b667436f9c0edda02 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 16 Mar 2011 18:50:02 +0100 Subject: [PATCH] s3: Fix Coverity ID 1012, CHECKED_RETURN This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO. --- source3/rpc_server/lsa/srv_lsa_nt.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/source3/rpc_server/lsa/srv_lsa_nt.c b/source3/rpc_server/lsa/srv_lsa_nt.c index eeea5163b2a..0f0bbe159be 100644 --- a/source3/rpc_server/lsa/srv_lsa_nt.c +++ b/source3/rpc_server/lsa/srv_lsa_nt.c @@ -184,7 +184,7 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx, int dom_idx; const char *full_name; const char *domain; - enum lsa_SidType type = SID_NAME_UNKNOWN; + enum lsa_SidType type; /* Split name into domain and user component */ @@ -199,11 +199,10 @@ static NTSTATUS lookup_lsa_rids(TALLOC_CTX *mem_ctx, DEBUG(5, ("lookup_lsa_rids: looking up name %s\n", full_name)); - /* We can ignore the result of lookup_name, it will not touch - "type" if it's not successful */ - - lookup_name(mem_ctx, full_name, flags, &domain, NULL, - &sid, &type); + if (!lookup_name(mem_ctx, full_name, flags, &domain, NULL, + &sid, &type)) { + type = SID_NAME_UNKNOWN; + } switch (type) { case SID_NAME_USER: -- 2.34.1