lib/ldb Remove talloc_free() that causes double-free in callbacks.
authorAndrew Bartlett <abartlet@samba.org>
Thu, 16 Dec 2010 11:28:45 +0000 (22:28 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 18 Dec 2010 00:34:18 +0000 (01:34 +0100)
commit656c828b9fcd8538b1503f86f8ac499837d7fc59
tree6a1c42cf3638bb8664674ada054f22113fc5ddd9
parent6967cf27eb94f9097c302bc2807f430ca4a641f2
lib/ldb Remove talloc_free() that causes double-free in callbacks.

This partially reverts 0941099a, which was a little over-eager in
fixing what were presumed to be memory leaks.

It is always the callbacks responsiblity to free the ares, but if they
don't then the end of the request should handle the cleanup.
Attempting to talloc_free() here will result (as it did in the
descriptor module) in a double-free error if the callback does free
it, and no other caller of ldb_module_send_entry() has this behaviour.

Andrew Bartlett
source4/lib/ldb/ldb_tdb/ldb_index.c