From: Volker Lendecke <vl@samba.org>
Date: Wed, 3 Feb 2010 06:37:29 +0000 (+0100)
Subject: s3: Simplify the code a bit: Catch (len==0) early
X-Git-Tag: tdb-1.2.1~37
X-Git-Url: http://git.samba.org/samba.git/?p=samba.git;a=commitdiff_plain;h=e00e6a2c96760b4c64a3a0badefdb582caabd31a

s3: Simplify the code a bit: Catch (len==0) early
---

diff --git a/source3/modules/vfs_expand_msdfs.c b/source3/modules/vfs_expand_msdfs.c
index 177ebdb928b..0772215a284 100644
--- a/source3/modules/vfs_expand_msdfs.c
+++ b/source3/modules/vfs_expand_msdfs.c
@@ -187,7 +187,7 @@ static int expand_msdfs_readlink(struct vfs_handle_struct *handle,
 	result = SMB_VFS_NEXT_READLINK(handle, path, target,
 				       PATH_MAX);
 
-	if (result < 0)
+	if (result <= 0)
 		return result;
 
 	target[result] = '\0';
@@ -202,12 +202,9 @@ static int expand_msdfs_readlink(struct vfs_handle_struct *handle,
 	}
 
 	len = MIN(bufsiz, strlen(target));
-	if (len) {
-		memcpy(buf, target, len);
-	} else {
-		errno = ENOENT;
-		return -1;
-	}
+
+	memcpy(buf, target, len);
+
 	TALLOC_FREE(target);
 	return len;
 }