From: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Date: Tue, 29 Sep 2009 09:49:50 +0000 (+0200)
Subject: s4/srvsvc: deactivate a "ntvfs_connect" with a wrong parameter
X-Git-Tag: talloc-2.0.1~175
X-Git-Url: http://git.samba.org/samba.git/?p=samba.git;a=commitdiff_plain;h=f390daef475126b4ff5a3d0ffd2babbd87d4c22b

s4/srvsvc: deactivate a "ntvfs_connect" with a wrong parameter

In the srvsvc code for s4 (NTVFS module) there exists a call to "ntvfs_connect"
which is performed with a totally wrong argument. Since I'm not able to fix
this, I commented it out and added a "FIXME" comment.
---

diff --git a/source4/rpc_server/srvsvc/srvsvc_ntvfs.c b/source4/rpc_server/srvsvc/srvsvc_ntvfs.c
index f1cb35bdd89..15bd749ad1b 100644
--- a/source4/rpc_server/srvsvc/srvsvc_ntvfs.c
+++ b/source4/rpc_server/srvsvc/srvsvc_ntvfs.c
@@ -128,7 +128,9 @@ NTSTATUS srvsvc_create_ntvfs_context(struct dcesrv_call_state *dce_call,
 	NT_STATUS_HAVE_NO_MEMORY(ntvfs_req);
 
 	/* Invoke NTVFS connection hook */
-	status = ntvfs_connect(ntvfs_req, scfg->name);
+	/* FIXME: Here is the right parameter missing!
+         * status = ntvfs_connect(ntvfs_req, <TODO>); */
+	status = NT_STATUS_UNSUCCESSFUL; /* return this for now */
 	if (!NT_STATUS_IS_OK(status)) {
 		DEBUG(0,("srvsvc_create_ntvfs_context: NTVFS ntvfs_connect() failed!\n"));
 		return status;