Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:38:17 +0000 (12:38 +0200)]
s4:WAF buildsystem - support out of "source4" directory builds
Bug: https://bugzilla.samba.org/show_bug.cgi?id=4081
With this patch we are able to invoke s4 builds from the outside of the
"source4" directory (but the target remains the "source4/bin" path).
One constraint: all commands: "autogen-waf.sh", "configure", "make" have to be
run from the same directory!
Regarding "make": you have to run it using "make -C <source4 path> [targets]" if
the invoke directory is not "source4" itself.
Andrew Tridgell [Thu, 8 Apr 2010 12:10:22 +0000 (22:10 +1000)]
build: we need this isinstance() check for distcheck
Jelmer, this works around a bug in waf distcheck that will be fixed
soon. We really need the isinstance() check for now.
Andrew Tridgell [Thu, 8 Apr 2010 12:01:27 +0000 (22:01 +1000)]
build: the exceptions here are not useful
they just make the failure hard to spot
Andrew Tridgell [Thu, 8 Apr 2010 11:46:20 +0000 (21:46 +1000)]
build: make the handling of relative paths a bit saner
This should fix a problem that Anatoliy has struck with the PIDL
rules. It also brings us much closer to a working build for a true out
of tree build (ie. with waf configure -b /tmp/build)
Stefan Metzmacher [Thu, 8 Apr 2010 10:45:54 +0000 (12:45 +0200)]
s3:winbindd: make "smbcontrol winbindd validate-cache" reliable again
commit
73577205cf81644e7fe853eaf3e6459f7f443096
(s3:winbindd: fix problems with SIGCHLD handling (bug #7317))
broke this.
metze
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:25:34 +0000 (12:25 +0200)]
s4:registry - "patchfile_preg.c" - fix the read operation of the data length on big-endian platforms
Matthias Dieter Wallnöfer [Thu, 8 Apr 2010 10:20:51 +0000 (12:20 +0200)]
s4:registry - "patchfile_preg.c" - use "sizeof(uint32_t)" for some size specifications
Looks nicer.
Jelmer Vernooij [Thu, 8 Apr 2010 10:19:51 +0000 (12:19 +0200)]
s4-net: Simplify SamDB connect code.
Jelmer Vernooij [Thu, 8 Apr 2010 01:26:39 +0000 (03:26 +0200)]
s4-python: Move set_global_schema to pydsdb.
Jelmer Vernooij [Wed, 7 Apr 2010 21:57:23 +0000 (23:57 +0200)]
s4-waf: Add dist target.
Volker Lendecke [Thu, 8 Apr 2010 08:40:40 +0000 (10:40 +0200)]
s3: Fix a typo
Andrew Bartlett [Wed, 7 Apr 2010 00:42:37 +0000 (10:42 +1000)]
tsocket_bsd: Always use a real length for the sa_socklen, and keep it around
The previous code assumed the OS would happily accept sizeof(struct
sockaddr_storage). It seems some versions of Solaris do not like
this.
Andrew Bartlett
Stefan Metzmacher [Wed, 7 Apr 2010 13:21:32 +0000 (15:21 +0200)]
Revert "socket-wrapper: not all systems have FIONREAD defined"
This reverts commit
710aa773d54509de34404f9992c5058ddfa45f3b.
We rely on FIONREAD in a lot of other parts in the code,
so there's no need to have an ifdef for it in the socket_wrapper code.
On tru64 FIONREAD is defined in <sys/ioctl.h>
and we include <sys/ioctl.h> via "system/network.h".
Tridge: maybe a HAVE_SYS_IOCTL_H was missing at the time you tried
it on tru64?
If we find a platform that doesn't support it,
we need to bail out at configure time or
provide a replacement in libreplace.
metze
Jeremy Allison [Thu, 8 Apr 2010 02:00:44 +0000 (19:00 -0700)]
Start to plumb smb2 into the oplock system. Calls dummy functions for now.
Jeremy.
Günther Deschner [Wed, 7 Apr 2010 21:40:17 +0000 (23:40 +0200)]
s4-smbtorture: minor typo in SetJob test in RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 7 Apr 2010 21:36:48 +0000 (23:36 +0200)]
s3-spoolss: Fix an issue in _spoolss_DeleteForm.
Found by torture test.
Guenther
Günther Deschner [Wed, 7 Apr 2010 21:36:15 +0000 (23:36 +0200)]
s3-spoolss: Fix some issues in _spoolss_AddForm.
Found by torture test.
Guenther
Günther Deschner [Wed, 7 Apr 2010 21:34:36 +0000 (23:34 +0200)]
s3-spoolss: Fix potential memleak in _spoolss_AddForm and _spoolss_SetForm.
Guenther
Thomas Nagy [Wed, 7 Apr 2010 21:45:46 +0000 (07:45 +1000)]
build: allow the waf build to work with python 3.0 and 3.1
Python 3.x is a bit fussier about print statements and indentation.
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 21:00:42 +0000 (23:00 +0200)]
LDB:sample_module - reintroduce accidentally removed "ldb_msg_add_fmt" statement
Obviously this is really needed by the "samba4.ldb" test.
Jelmer Vernooij [Wed, 7 Apr 2010 20:52:28 +0000 (22:52 +0200)]
s4-waf: Fix 'waf dist' app name.
Jelmer Vernooij [Wed, 7 Apr 2010 20:17:34 +0000 (22:17 +0200)]
Move configure_check_unused script to root scriptdir, as it is useful
for both s3 and s4.
Jelmer Vernooij [Wed, 7 Apr 2010 20:15:27 +0000 (22:15 +0200)]
s4: Remove unused pkg-config replacement in perl.
Jelmer Vernooij [Wed, 7 Apr 2010 20:13:34 +0000 (22:13 +0200)]
update-external: Support updating dnspython.
Volker Lendecke [Wed, 7 Apr 2010 20:28:28 +0000 (22:28 +0200)]
s3: Fix bug 7327 -- Build fails while building without kerberos
libsmb/clikrb5.c has a dummy implementation for the non-kerberos case
Jelmer Vernooij [Wed, 7 Apr 2010 15:54:57 +0000 (17:54 +0200)]
selftest: Display minutes and hours for duration.
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 18:40:06 +0000 (20:40 +0200)]
LDB:python bindings - also empty LDB message elements should have a python representation
Bug found by ekacnet (see technical mailing list).
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 18:14:46 +0000 (20:14 +0200)]
s4:registry - "regf backend" - fix it up regarding REG_DWORD/REG_DWORD_BIG_ENDIAN_VALUES
This is needed to make it platform independently work (also on big endian
platforms as little endian).
Also add a size check before storing a DWORD.
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 16:54:42 +0000 (18:54 +0200)]
s4:winbind/wb_server.c - fix indentation
Jeremy Allison [Wed, 7 Apr 2010 17:33:02 +0000 (10:33 -0700)]
Test using (-1) for tid and sessionid in compound related requests.
Jeremy.
Jeremy Allison [Wed, 7 Apr 2010 17:32:01 +0000 (10:32 -0700)]
On compound requests, MS-SMB2 says clients MAY use 0xFFFFFFFF for compound tid and 0xFFFFFFFFFFFFFFFF for compound sessionid values. Cope with this.
Jeremy.
Jeremy Allison [Wed, 7 Apr 2010 17:31:43 +0000 (10:31 -0700)]
Don't forget to initialize *p_creds_requested.
Jeremy.
Jelmer Vernooij [Wed, 7 Apr 2010 10:11:12 +0000 (12:11 +0200)]
s4-samdb: Allow skipping global schema.
Jelmer Vernooij [Wed, 7 Apr 2010 10:10:09 +0000 (12:10 +0200)]
s4-provision: Proper handling of exceptions, use SamDB class but skip global schema.
Jelmer Vernooij [Sun, 4 Apr 2010 01:30:03 +0000 (03:30 +0200)]
s4-python: Move samdb_ntds_objectGUID to pydsdb.
Jelmer Vernooij [Sun, 4 Apr 2010 01:08:05 +0000 (03:08 +0200)]
urgent_replication: Use standard comments rather than docstrings.
Andreas Schneider [Thu, 1 Apr 2010 10:45:58 +0000 (12:45 +0200)]
s3-spoolss: Added a winreg_getform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Thu, 1 Apr 2010 09:51:59 +0000 (11:51 +0200)]
s3-spoolss: Added a winreg_setform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 31 Mar 2010 13:31:21 +0000 (15:31 +0200)]
s3-spoolss: Added a winreg_deleteform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 31 Mar 2010 11:04:04 +0000 (13:04 +0200)]
s3-spoolss: Added a winreg_addform1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 31 Mar 2010 11:03:09 +0000 (13:03 +0200)]
s3-spoolss: Added a winreg_enumforms1 function.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 30 Mar 2010 12:46:32 +0000 (14:46 +0200)]
s3-spoolss: Fixed winreg_printer_openkey to be used in a more generic way.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Tue, 6 Apr 2010 15:01:15 +0000 (17:01 +0200)]
s3-spoolss: Added a delete_printer_key function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Wed, 17 Mar 2010 14:59:10 +0000 (15:59 +0100)]
s3-spoolss: Added a enum_printer_key function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 15 Mar 2010 11:30:05 +0000 (12:30 +0100)]
s3-spoolss: Added a delete_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Fri, 12 Mar 2010 16:31:21 +0000 (17:31 +0100)]
s3-spoolss: Added a enum_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 15 Mar 2010 11:27:51 +0000 (12:27 +0100)]
s3-spoolss: Added a get_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 15 Mar 2010 11:24:59 +0000 (12:24 +0100)]
s3-spoolss: Added a set_printer_dataex function using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Andreas Schneider [Mon, 15 Mar 2010 11:24:40 +0000 (12:24 +0100)]
s3-spoolss: Added a function to open a regkey using the winreg pipe.
Signed-off-by: Günther Deschner <gd@samba.org>
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 13:02:23 +0000 (15:02 +0200)]
s4:WHATSNEW4.txt - further updates and corrections
Some are inspired by ekacnet.
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 12:33:09 +0000 (14:33 +0200)]
s4:pyregistry.c - fix indentation
Matthias Dieter Wallnöfer [Wed, 7 Apr 2010 12:20:18 +0000 (14:20 +0200)]
s4:provision - add a comment which explains why "paths.dns_keytab" is stored without path reference
Günther Deschner [Wed, 7 Apr 2010 12:56:07 +0000 (14:56 +0200)]
s4-smbtorture: test for invalid form flags in RPC-SPOOLSS.
Guenther
Günther Deschner [Wed, 7 Apr 2010 12:38:31 +0000 (14:38 +0200)]
s3-rpcclient: allow to define server_unc in cmd_srvsvc_srv_query_info().
Guenther
Günther Deschner [Wed, 7 Apr 2010 12:37:30 +0000 (14:37 +0200)]
s4-smbtorture: test all types and also use a wellknown builtin form name in RPC-SPOOLSS.
Guenther
Björn Jacke [Wed, 7 Apr 2010 10:21:07 +0000 (12:21 +0200)]
s3: add comment about what the FSCTL_QUERY_ALLOCATED_RANGES currently does
Günther Deschner [Tue, 6 Apr 2010 22:39:17 +0000 (00:39 +0200)]
s4-smbtorture: merge badname spoolss openprinter tests.
Guenther
Günther Deschner [Tue, 6 Apr 2010 22:38:02 +0000 (00:38 +0200)]
s4-smbtorture: avoid passing down a full test_spoolss_context to directory
spoolss tests when not used.
Guenther
Jeremy Allison [Tue, 6 Apr 2010 23:31:26 +0000 (16:31 -0700)]
Ensure we total up the correct number of creds requested in a compound request.
Jeremy Allison [Tue, 6 Apr 2010 22:43:35 +0000 (15:43 -0700)]
Parameterize "smb2 max read", "smb2 max write", "smb2 max trans".
Set to 64k by default.
Jeremy.
Jelmer Vernooij [Tue, 6 Apr 2010 22:32:24 +0000 (00:32 +0200)]
Support 'make test TESTS=foo' again.
Jelmer Vernooij [Tue, 6 Apr 2010 22:26:28 +0000 (00:26 +0200)]
s4-python: Use standard infrastructure for finding included testtools, subunit and iso8601.
Günther Deschner [Tue, 6 Apr 2010 11:23:22 +0000 (13:23 +0200)]
s4-smbtorture: more work on forms tests in RPC-SPOOLSS.
Guenther
Matthias Dieter Wallnöfer [Tue, 6 Apr 2010 12:52:38 +0000 (14:52 +0200)]
s4:param/secrets.c - add some "char *" casts
Also this quiets some warnings.
Matthias Dieter Wallnöfer [Tue, 6 Apr 2010 12:36:06 +0000 (14:36 +0200)]
s4:net tool - add a "discard_const_p" to suppress the "PySys_SetArgv" warning
Matthias Dieter Wallnöfer [Tue, 6 Apr 2010 12:32:27 +0000 (14:32 +0200)]
s4:torture - remove unused variables
Matthias Dieter Wallnöfer [Tue, 6 Apr 2010 12:26:20 +0000 (14:26 +0200)]
s4:auth/ntlm/auth_developer.c - "fixed_challenge_get_challenge" - fix the assignment of the challenge
This is a string buffer and not a DATA_BLOB.
Matthias Dieter Wallnöfer [Tue, 6 Apr 2010 12:09:38 +0000 (14:09 +0200)]
LDB:sample_module.c - remove code parts which generate warnings
Btw: The use of the "ldb_msg_add_fmt" operation directly on the request message
object is strongly discouraged. Better is to make a shallow copy of this message
and attach it to a new child request which is handled by the following modules.
Jelmer Vernooij [Tue, 6 Apr 2010 12:24:24 +0000 (14:24 +0200)]
s4-python: Fix compilation of samba._ldb.
Christian Ambach [Mon, 5 Apr 2010 12:12:52 +0000 (14:12 +0200)]
fix a segfault in the notify subsystem
When the notify_array cannot be loaded correctly,
do not keep the half-baked parsing results in the global variable.
This can lead to segfaults next time notify_load is entered and
the seqnum has not changed. This has been seen in a case
where mixed smbd versions were running in a CTDB cluster
(versions with and w/o commit
c216d1e6 that changed the
notify_entry structure).
There will be missed notifications until all smbds are at the
same software level, but this should be acceptable and is better
than crashing and interrupting client operations.
This fix cleans up the notify_array, removes the unparseable data
from the TDB and returns a fresh notify_array that can be worked
with.
The NDR_PRINT_DEBUG had to be moved to only be called when the
parsing succeeded, it was seen to cause additional segfaults.
The status variable is intentionally left to NT_STATUS_OK to not
make callers abort and report errors to the clients and make them
disconnect.
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Jelmer Vernooij [Sun, 4 Apr 2010 00:20:52 +0000 (02:20 +0200)]
s4-python: Move set_session_info to PySambaLdb.
Jelmer Vernooij [Sun, 4 Apr 2010 00:07:46 +0000 (02:07 +0200)]
s4-python: Move register_samba_handlers to PySambaLdb.
Jelmer Vernooij [Sun, 4 Apr 2010 00:01:47 +0000 (02:01 +0200)]
s4-python: Move ldb_set_utf8_casefold to pyldb-samba.
Jelmer Vernooij [Sat, 3 Apr 2010 23:54:57 +0000 (01:54 +0200)]
s4-python: Move set_opaque_integer to pyldb.
Jelmer Vernooij [Sat, 3 Apr 2010 23:51:04 +0000 (01:51 +0200)]
Move glue.set_credentials hack to samba.Ldb.
Jelmer Vernooij [Sat, 3 Apr 2010 23:48:35 +0000 (01:48 +0200)]
Add C-based Samba-specific subclass of Ldb.
Andrew Tridgell [Tue, 6 Apr 2010 10:48:15 +0000 (20:48 +1000)]
s4-build: remove any 'makefile' that may have been left by the waf build
this allows ./autogen.sh to be used to switch back to the old build
system after trying the waf build
Andrew Tridgell [Tue, 6 Apr 2010 09:31:39 +0000 (19:31 +1000)]
build: use a target_in_list() function for more flexible builtin control
Andrew Tridgell [Mon, 5 Apr 2010 08:16:47 +0000 (18:16 +1000)]
build: cope with binaries with subdir prefixes (for s3 waf build)
Andrew Tridgell [Mon, 5 Apr 2010 01:41:37 +0000 (11:41 +1000)]
s4-waf: don't need TOUCH_FILE() any more
Andrew Tridgell [Mon, 5 Apr 2010 01:26:45 +0000 (11:26 +1000)]
build: run distcheck in testwaf.sh
Andrew Tridgell [Mon, 5 Apr 2010 01:26:24 +0000 (11:26 +1000)]
s4-waf: add subdir argument to distcheck for source4
Andrew Tridgell [Mon, 5 Apr 2010 01:25:54 +0000 (11:25 +1000)]
build: update version of waf to add subdir argument to distcheck
Andrew Tridgell [Mon, 5 Apr 2010 01:25:20 +0000 (11:25 +1000)]
s4-waf: replace TOUCH_FILE() with normal install rules
this allows it to work with 'waf uninstall'
Andrew Tridgell [Mon, 5 Apr 2010 01:23:28 +0000 (11:23 +1000)]
build: simpler symlink_bin and symlink_lib methods
Andrew Tridgell [Sun, 4 Apr 2010 23:58:23 +0000 (09:58 +1000)]
s4-waf: fixed waf distcheck for our standalone libs and s4
Andrew Tridgell [Sun, 4 Apr 2010 12:11:30 +0000 (22:11 +1000)]
s4-waf: added simple 'waf test' support for tdb, talloc and ldb
Andrew Tridgell [Sun, 4 Apr 2010 11:29:34 +0000 (21:29 +1000)]
s4-waf: added python_dsdb from merge with master
Andrew Tridgell [Sun, 4 Apr 2010 11:14:21 +0000 (21:14 +1000)]
build: fixed LOAD_ENVIRONMENT for out of tree builds
Andrew Tridgell [Sun, 4 Apr 2010 08:31:54 +0000 (18:31 +1000)]
s4-waf: autogen-waf.sh for the standalone library builds
Andrew Tridgell [Sun, 4 Apr 2010 08:27:30 +0000 (18:27 +1000)]
s4-waf: new autogen-waf.sh
this one will work with the tdb, talloc, etc directories
Andrew Tridgell [Sun, 4 Apr 2010 03:16:49 +0000 (13:16 +1000)]
s4-waf: use a common pattern for finding buildtools and libs
Andrew Tridgell [Sun, 4 Apr 2010 03:08:05 +0000 (13:08 +1000)]
s4-waf: move to a universal method of recursing into subdirs
This works with both standalone lib builds and bundled builds
Andrew Tridgell [Sun, 4 Apr 2010 01:40:05 +0000 (11:40 +1000)]
s4-waf: fixed finding of buildtools and srcdir
Andrew Tridgell [Sun, 4 Apr 2010 01:02:15 +0000 (11:02 +1000)]
ldb-waf: fixed buildtools path
Andrew Tridgell [Sun, 4 Apr 2010 01:00:42 +0000 (11:00 +1000)]
s4-waf: avoid having to run waf configure before waf dist
This should be useful for building tarballs from a clean checkout
Andrew Tridgell [Sun, 4 Apr 2010 00:23:43 +0000 (10:23 +1000)]
build: nicer error msg when git ls-files fails
Andrew Tridgell [Sun, 4 Apr 2010 00:18:39 +0000 (10:18 +1000)]
s4-waf: allow standalone tarball build of libraries
Andrew Tridgell [Sun, 4 Apr 2010 00:06:34 +0000 (10:06 +1000)]
s4-waf: added 'waf dist' to our standalone libs as well
Andrew Tridgell [Sat, 3 Apr 2010 23:57:33 +0000 (09:57 +1000)]
s4-waf: added 'waf dist' to build the tarball