s3:rpc_server: handle everything but AUTH_TYPE_NONE as gensec in verify_final
[obnox/samba/samba-obnox.git] / source3 / rpc_server / srv_pipe.c
index a6e43b65ec07c529965c7f3cd0fd293ca1478bc2..aaf58871d3ecb9c7949a141c6850ee83a82dd566 100644 (file)
 #include "includes.h"
 #include "system/filesys.h"
 #include "srv_pipe_internal.h"
-#include "../librpc/gen_ndr/ndr_schannel.h"
-#include "../libcli/auth/schannel.h"
-#include "../libcli/auth/spnego.h"
-#include "dcesrv_ntlmssp.h"
-#include "dcesrv_gssapi.h"
-#include "dcesrv_spnego.h"
+#include "../librpc/gen_ndr/dcerpc.h"
+#include "../librpc/rpc/rpc_common.h"
+#include "dcesrv_auth_generic.h"
 #include "rpc_server.h"
 #include "rpc_dce.h"
 #include "smbd/smbd.h"
 #include "auth.h"
 #include "ntdomain.h"
 #include "rpc_server/srv_pipe.h"
+#include "rpc_server/rpc_contexts.h"
+#include "lib/param/param.h"
+#include "librpc/ndr/ndr_table.h"
+#include "auth/gensec/gensec.h"
+#include "librpc/ndr/ndr_dcerpc.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_RPC_SRV
@@ -202,7 +204,7 @@ bool create_next_pdu(struct pipes_struct *p)
         * the pipe gets closed. JRA.
         */
        if (p->fault_state) {
-               setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR));
+               setup_fault_pdu(p, NT_STATUS(p->fault_state));
                return true;
        }
 
@@ -334,13 +336,15 @@ static bool check_bind_req(struct pipes_struct *p,
                           uint32_t context_id)
 {
        struct pipe_rpc_fns *context_fns;
+       bool ok;
 
        DEBUG(3,("check_bind_req for %s\n",
-                get_pipe_name_from_syntax(talloc_tos(), abstract)));
+                ndr_interface_name(&abstract->uuid,
+                                   abstract->if_version)));
 
        /* we have to check all now since win2k introduced a new UUID on the lsaprpc pipe */
        if (rpc_srv_pipe_exists_by_id(abstract) &&
-          ndr_syntax_id_equal(transfer, &ndr_transfer_syntax)) {
+          ndr_syntax_id_equal(transfer, &ndr_transfer_syntax_ndr)) {
                DEBUG(3, ("check_bind_req: %s -> %s rpc service\n",
                          rpc_srv_get_pipe_cli_name(abstract),
                          rpc_srv_get_pipe_srv_name(abstract)));
@@ -348,10 +352,16 @@ static bool check_bind_req(struct pipes_struct *p,
                return false;
        }
 
-       context_fns = SMB_MALLOC_P(struct pipe_rpc_fns);
+       ok = init_pipe_handles(p, abstract);
+       if (!ok) {
+               DEBUG(1, ("Failed to init pipe handles!\n"));
+               return false;
+       }
+
+       context_fns = talloc(p, struct pipe_rpc_fns);
        if (context_fns == NULL) {
-               DEBUG(0,("check_bind_req: malloc() failed!\n"));
-               return False;
+               DEBUG(0,("check_bind_req: talloc() failed!\n"));
+               return false;
        }
 
        context_fns->next = context_fns->prev = NULL;
@@ -369,22 +379,13 @@ static bool check_bind_req(struct pipes_struct *p,
 
 /**
  * Is a named pipe known?
- * @param[in] cli_filename     The pipe name requested by the client
+ * @param[in] pipename         Just the filename
  * @result                     Do we want to serve this?
  */
-bool is_known_pipename(const char *cli_filename, struct ndr_syntax_id *syntax)
+bool is_known_pipename(const char *pipename, struct ndr_syntax_id *syntax)
 {
-       const char *pipename = cli_filename;
        NTSTATUS status;
 
-       if (strnequal(pipename, "\\PIPE\\", 6)) {
-               pipename += 5;
-       }
-
-       if (*pipename == '\\') {
-               pipename += 1;
-       }
-
        if (lp_disable_spoolss() && strequal(pipename, "spoolss")) {
                DEBUG(10, ("refusing spoolss access\n"));
                return false;
@@ -396,7 +397,7 @@ bool is_known_pipename(const char *cli_filename, struct ndr_syntax_id *syntax)
 
        status = smb_probe_module("rpc", pipename);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("is_known_pipename: %s unknown\n", cli_filename));
+               DEBUG(10, ("is_known_pipename: %s unknown\n", pipename));
                return false;
        }
        DEBUG(10, ("is_known_pipename: %s loaded dynamically\n", pipename));
@@ -414,183 +415,28 @@ bool is_known_pipename(const char *cli_filename, struct ndr_syntax_id *syntax)
        return false;
 }
 
-/*******************************************************************
- Handle the first part of a SPNEGO bind auth.
-*******************************************************************/
-
-static bool pipe_spnego_auth_bind(struct pipes_struct *p,
-                                 TALLOC_CTX *mem_ctx,
-                                 struct dcerpc_auth *auth_info,
-                                 DATA_BLOB *response)
-{
-       struct spnego_context *spnego_ctx;
-       NTSTATUS status;
-
-       status = spnego_server_auth_start(p,
-                                         (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_INTEGRITY),
-                                         (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_PRIVACY),
-                                         true,
-                                         &auth_info->credentials,
-                                         response,
-                                         &spnego_ctx);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed SPNEGO negotiate (%s)\n",
-                         nt_errstr(status)));
-               return false;
-       }
-
-       /* Make sure data is bound to the memctx, to be freed the caller */
-       talloc_steal(mem_ctx, response->data);
-
-       p->auth.auth_ctx = spnego_ctx;
-       p->auth.auth_type = DCERPC_AUTH_TYPE_SPNEGO;
-
-       DEBUG(10, ("SPNEGO auth started\n"));
-
-       return true;
-}
-
-/*******************************************************************
- Handle an schannel bind auth.
-*******************************************************************/
-
-static bool pipe_schannel_auth_bind(struct pipes_struct *p,
-                                   TALLOC_CTX *mem_ctx,
-                                   struct dcerpc_auth *auth_info,
-                                   DATA_BLOB *response)
-{
-       struct NL_AUTH_MESSAGE neg;
-       struct NL_AUTH_MESSAGE reply;
-       bool ret;
-       NTSTATUS status;
-       struct netlogon_creds_CredentialState *creds;
-       enum ndr_err_code ndr_err;
-       struct schannel_state *schannel_auth;
-
-       ndr_err = ndr_pull_struct_blob(
-                       &auth_info->credentials, mem_ctx, &neg,
-                       (ndr_pull_flags_fn_t)ndr_pull_NL_AUTH_MESSAGE);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               DEBUG(0,("pipe_schannel_auth_bind: Could not unmarshal SCHANNEL auth neg\n"));
-               return false;
-       }
-
-       if (DEBUGLEVEL >= 10) {
-               NDR_PRINT_DEBUG(NL_AUTH_MESSAGE, &neg);
-       }
-
-       if (!(neg.Flags & NL_FLAG_OEM_NETBIOS_COMPUTER_NAME)) {
-               DEBUG(0,("pipe_schannel_auth_bind: Did not receive netbios computer name\n"));
-               return false;
-       }
-
-       /*
-        * The neg.oem_netbios_computer.a key here must match the remote computer name
-        * given in the DOM_CLNT_SRV.uni_comp_name used on all netlogon pipe
-        * operations that use credentials.
-        */
-
-       become_root();
-       status = schannel_get_creds_state(p, lp_private_dir(),
-                                           neg.oem_netbios_computer.a, &creds);
-       unbecome_root();
-
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("pipe_schannel_auth_bind: Attempt to bind using schannel without successful serverauth2\n"));
-               return False;
-       }
-
-       schannel_auth = talloc(p, struct schannel_state);
-       if (!schannel_auth) {
-               TALLOC_FREE(creds);
-               return False;
-       }
-
-       schannel_auth->state = SCHANNEL_STATE_START;
-       schannel_auth->seq_num = 0;
-       schannel_auth->initiator = false;
-       schannel_auth->creds = creds;
-
-       /*
-        * JRA. Should we also copy the schannel session key into the pipe session key p->session_key
-        * here ? We do that for NTLMSSP, but the session key is already set up from the vuser
-        * struct of the person who opened the pipe. I need to test this further. JRA.
-        *
-        * VL. As we are mapping this to guest set the generic key
-        * "SystemLibraryDTC" key here. It's a bit difficult to test against
-        * W2k3, as it does not allow schannel binds against SAMR and LSA
-        * anymore.
-        */
-
-       ret = session_info_set_session_key(p->session_info, generic_session_key());
-
-       if (!ret) {
-               DEBUG(0, ("session_info_set_session_key failed\n"));
-               return false;
-       }
-
-       /*** SCHANNEL verifier ***/
-
-       reply.MessageType                       = NL_NEGOTIATE_RESPONSE;
-       reply.Flags                             = 0;
-       reply.Buffer.dummy                      = 5; /* ??? actually I don't think
-                                                     * this has any meaning
-                                                     * here - gd */
-
-       ndr_err = ndr_push_struct_blob(response, mem_ctx, &reply,
-                      (ndr_push_flags_fn_t)ndr_push_NL_AUTH_MESSAGE);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               DEBUG(0,("Failed to marshall NL_AUTH_MESSAGE.\n"));
-               return false;
-       }
-
-       if (DEBUGLEVEL >= 10) {
-               NDR_PRINT_DEBUG(NL_AUTH_MESSAGE, &reply);
-       }
-
-       DEBUG(10,("pipe_schannel_auth_bind: schannel auth: domain [%s] myname [%s]\n",
-               neg.oem_netbios_domain.a, neg.oem_netbios_computer.a));
-
-       /* We're finished with this bind - no more packets. */
-       p->auth.auth_ctx = schannel_auth;
-       p->auth.auth_type = DCERPC_AUTH_TYPE_SCHANNEL;
-
-       p->pipe_bound = True;
-
-       return True;
-}
-
 /*******************************************************************
  Handle an NTLMSSP bind auth.
 *******************************************************************/
 
-static bool pipe_ntlmssp_auth_bind(struct pipes_struct *p,
-                                  TALLOC_CTX *mem_ctx,
+static bool pipe_auth_generic_bind(struct pipes_struct *p,
+                                  struct ncacn_packet *pkt,
                                   struct dcerpc_auth *auth_info,
                                   DATA_BLOB *response)
 {
-       struct auth_ntlmssp_state *ntlmssp_state = NULL;
+       TALLOC_CTX *mem_ctx = pkt;
+       struct gensec_security *gensec_security = NULL;
         NTSTATUS status;
 
-       if (strncmp((char *)auth_info->credentials.data, "NTLMSSP", 7) != 0) {
-               DEBUG(0, ("Failed to read NTLMSSP in blob\n"));
-                return false;
-        }
-
-       /* We have an NTLMSSP blob. */
-       status = ntlmssp_server_auth_start(p,
-                                          (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_INTEGRITY),
-                                          (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_PRIVACY),
-                                          true,
-                                          &auth_info->credentials,
-                                          response,
-                                          &ntlmssp_state);
+       status = auth_generic_server_authtype_start(p,
+                                                   auth_info->auth_type,
+                                                   auth_info->auth_level,
+                                                   &auth_info->credentials,
+                                                   response,
+                                                   p->remote_address,
+                                                   &gensec_security);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_OK)) {
-               DEBUG(0, (__location__ ": auth_ntlmssp_start failed: %s\n",
+               DEBUG(0, (__location__ ": auth_generic_server_authtype_start failed: %s\n",
                          nt_errstr(status)));
                return false;
        }
@@ -598,10 +444,19 @@ static bool pipe_ntlmssp_auth_bind(struct pipes_struct *p,
        /* Make sure data is bound to the memctx, to be freed the caller */
        talloc_steal(mem_ctx, response->data);
 
-       p->auth.auth_ctx = ntlmssp_state;
-       p->auth.auth_type = DCERPC_AUTH_TYPE_NTLMSSP;
+       p->auth.auth_ctx = gensec_security;
+       p->auth.auth_type = auth_info->auth_type;
 
-       DEBUG(10, (__location__ ": NTLMSSP auth started\n"));
+       if (pkt->pfc_flags & DCERPC_PFC_FLAG_SUPPORT_HEADER_SIGN) {
+               p->auth.client_hdr_signing = true;
+               p->auth.hdr_signing = gensec_have_feature(gensec_security,
+                                               GENSEC_FEATURE_SIGN_PKT_HEADER);
+       }
+
+       if (p->auth.hdr_signing) {
+               gensec_want_feature(gensec_security,
+                                   GENSEC_FEATURE_SIGN_PKT_HEADER);
+       }
 
        return true;
 }
@@ -613,38 +468,34 @@ static bool pipe_ntlmssp_auth_bind(struct pipes_struct *p,
  the pipe struct.
 *******************************************************************/
 
-static bool pipe_ntlmssp_verify_final(TALLOC_CTX *mem_ctx,
-                               struct auth_ntlmssp_state *ntlmssp_ctx,
+static bool pipe_auth_generic_verify_final(TALLOC_CTX *mem_ctx,
+                               struct gensec_security *gensec_security,
                                enum dcerpc_AuthLevel auth_level,
-                               struct client_address *client_id,
-                               struct ndr_syntax_id *syntax,
-                               struct auth_serversupplied_info **session_info)
+                               struct auth_session_info **session_info)
 {
        NTSTATUS status;
        bool ret;
 
-       DEBUG(5, (__location__ ": pipe %s checking user details\n",
-                get_pipe_name_from_syntax(talloc_tos(), syntax)));
+       DEBUG(5, (__location__ ": checking user details\n"));
 
        /* Finally - if the pipe negotiated integrity (sign) or privacy (seal)
           ensure the underlying NTLMSSP flags are also set. If not we should
           refuse the bind. */
 
-       status = ntlmssp_server_check_flags(ntlmssp_ctx,
+       status = auth_generic_server_check_flags(gensec_security,
                                            (auth_level ==
                                                DCERPC_AUTH_LEVEL_INTEGRITY),
                                            (auth_level ==
                                                DCERPC_AUTH_LEVEL_PRIVACY));
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, (__location__ ": Client failed to negotatie proper "
-                         "security for pipe %s\n",
-                         get_pipe_name_from_syntax(talloc_tos(), syntax)));
+                         "security for rpc connection\n"));
                return false;
        }
 
        TALLOC_FREE(*session_info);
 
-       status = ntlmssp_server_get_user_info(ntlmssp_ctx,
+       status = auth_generic_server_get_user_info(gensec_security,
                                                mem_ctx, session_info);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, (__location__ ": failed to obtain the server info "
@@ -672,163 +523,26 @@ static bool pipe_ntlmssp_verify_final(TALLOC_CTX *mem_ctx,
        return true;
 }
 
-/*******************************************************************
- Handle a GSSAPI bind auth.
-*******************************************************************/
-
-static bool pipe_gssapi_auth_bind(struct pipes_struct *p,
-                                 TALLOC_CTX *mem_ctx,
-                                 struct dcerpc_auth *auth_info,
-                                 DATA_BLOB *response)
-{
-        NTSTATUS status;
-       struct gse_context *gse_ctx = NULL;
-
-       status = gssapi_server_auth_start(p,
-                                         (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_INTEGRITY),
-                                         (auth_info->auth_level ==
-                                               DCERPC_AUTH_LEVEL_PRIVACY),
-                                         true,
-                                         &auth_info->credentials,
-                                         response,
-                                         &gse_ctx);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to init dcerpc gssapi server (%s)\n",
-                         nt_errstr(status)));
-               goto err;
-       }
-
-       /* Make sure data is bound to the memctx, to be freed the caller */
-       talloc_steal(mem_ctx, response->data);
-
-       p->auth.auth_ctx = gse_ctx;
-       p->auth.auth_type = DCERPC_AUTH_TYPE_KRB5;
-
-       DEBUG(10, ("KRB5 auth started\n"));
-
-       return true;
-
-err:
-       TALLOC_FREE(gse_ctx);
-       return false;
-}
-
-static NTSTATUS pipe_gssapi_verify_final(TALLOC_CTX *mem_ctx,
-                                        struct gse_context *gse_ctx,
-                                        struct client_address *client_id,
-                                        struct auth_serversupplied_info **session_info)
+static NTSTATUS pipe_auth_verify_final(struct pipes_struct *p)
 {
-       NTSTATUS status;
-       bool bret;
+       struct gensec_security *gensec_security;
+       bool ok;
 
-       /* Finally - if the pipe negotiated integrity (sign) or privacy (seal)
-          ensure the underlying flags are also set. If not we should
-          refuse the bind. */
-
-       status = gssapi_server_check_flags(gse_ctx);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Requested Security Layers not honored!\n"));
-               return status;
+       if (p->auth.auth_type == DCERPC_AUTH_TYPE_NONE) {
+               p->pipe_bound = true;
+               return NT_STATUS_OK;
        }
 
-       status = gssapi_server_get_user_info(gse_ctx, mem_ctx,
-                                            client_id, session_info);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, (__location__ ": failed to obtain the server info "
-                         "for authenticated user: %s\n", nt_errstr(status)));
-               return status;
+       gensec_security = talloc_get_type(p->auth.auth_ctx,
+                                         struct gensec_security);
+       if (gensec_security == NULL) {
+               return NT_STATUS_INTERNAL_ERROR;
        }
 
-       /*
-        * We're an authenticated bind over smb, so the session key needs to
-        * be set to "SystemLibraryDTC". Weird, but this is what Windows
-        * does. See the RPC-SAMBA3SESSIONKEY.
-        */
-
-       bret = session_info_set_session_key((*session_info), generic_session_key());
-       if (!bret) {
-               return NT_STATUS_ACCESS_DENIED;
-       }
-
-       return NT_STATUS_OK;
-}
-
-static NTSTATUS pipe_auth_verify_final(struct pipes_struct *p)
-{
-       enum spnego_mech auth_type;
-       struct auth_ntlmssp_state *ntlmssp_ctx;
-       struct spnego_context *spnego_ctx;
-       struct gse_context *gse_ctx;
-       void *mech_ctx;
-       NTSTATUS status;
-
-       switch (p->auth.auth_type) {
-       case DCERPC_AUTH_TYPE_NTLMSSP:
-               ntlmssp_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                   struct auth_ntlmssp_state);
-               if (!pipe_ntlmssp_verify_final(p, ntlmssp_ctx,
-                                               p->auth.auth_level,
-                                               p->client_id, &p->syntax,
-                                               &p->session_info)) {
-                       return NT_STATUS_ACCESS_DENIED;
-               }
-               break;
-       case DCERPC_AUTH_TYPE_KRB5:
-               gse_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                               struct gse_context);
-               status = pipe_gssapi_verify_final(p, gse_ctx,
-                                                 p->client_id,
-                                                 &p->session_info);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(1, ("gssapi bind failed with: %s",
-                                 nt_errstr(status)));
-                       return status;
-               }
-               break;
-       case DCERPC_AUTH_TYPE_SPNEGO:
-               spnego_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                  struct spnego_context);
-               status = spnego_get_negotiated_mech(spnego_ctx,
-                                                   &auth_type, &mech_ctx);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("Bad SPNEGO state (%s)\n",
-                                 nt_errstr(status)));
-                       return status;
-               }
-               switch(auth_type) {
-               case SPNEGO_KRB5:
-                       gse_ctx = talloc_get_type_abort(mech_ctx,
-                                                       struct gse_context);
-                       status = pipe_gssapi_verify_final(p, gse_ctx,
-                                                         p->client_id,
-                                                         &p->session_info);
-                       if (!NT_STATUS_IS_OK(status)) {
-                               DEBUG(1, ("gssapi bind failed with: %s",
-                                         nt_errstr(status)));
-                               return status;
-                       }
-                       break;
-               case SPNEGO_NTLMSSP:
-                       ntlmssp_ctx = talloc_get_type_abort(mech_ctx,
-                                               struct auth_ntlmssp_state);
-                       if (!pipe_ntlmssp_verify_final(p, ntlmssp_ctx,
-                                                       p->auth.auth_level,
-                                                       p->client_id,
-                                                       &p->syntax,
-                                                       &p->session_info)) {
-                               return NT_STATUS_ACCESS_DENIED;
-                       }
-                       break;
-               default:
-                       DEBUG(0, (__location__ ": incorrect spnego type "
-                                 "(%d).\n", auth_type));
-                       return NT_STATUS_ACCESS_DENIED;
-               }
-               break;
-       default:
-               DEBUG(0, (__location__ ": incorrect auth type (%u).\n",
-                         (unsigned int)p->auth.auth_type));
+       ok = pipe_auth_generic_verify_final(p, gensec_security,
+                                           p->auth.auth_level,
+                                           &p->session_info);
+       if (!ok) {
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -849,16 +563,16 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
        unsigned int auth_type = DCERPC_AUTH_TYPE_NONE;
        NTSTATUS status;
        struct ndr_syntax_id id;
+       uint8_t pfc_flags = 0;
        union dcerpc_payload u;
        struct dcerpc_ack_ctx bind_ack_ctx;
        DATA_BLOB auth_resp = data_blob_null;
        DATA_BLOB auth_blob = data_blob_null;
+       const struct ndr_interface_table *table;
 
        /* No rebinds on a bound pipe - use alter context. */
        if (p->pipe_bound) {
-               DEBUG(2,("api_pipe_bind_req: rejecting bind request on bound "
-                        "pipe %s.\n",
-                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
+               DEBUG(2,("Rejecting bind request on bound rpc connection\n"));
                return setup_bind_nak(p, pkt);
        }
 
@@ -872,39 +586,45 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
         * that this is a pipe name we support.
         */
        id = pkt->u.bind.ctx_list[0].abstract_syntax;
+
+       table = ndr_table_by_uuid(&id.uuid);
+       if (table == NULL) {
+               DEBUG(0,("unknown interface\n"));
+               return false;
+       }
+
        if (rpc_srv_pipe_exists_by_id(&id)) {
-               DEBUG(3, ("api_pipe_bind_req: \\PIPE\\%s -> \\PIPE\\%s\n",
-                       rpc_srv_get_pipe_cli_name(&id),
-                       rpc_srv_get_pipe_srv_name(&id)));
+               DEBUG(3, ("api_pipe_bind_req: %s -> %s rpc service\n",
+                         rpc_srv_get_pipe_cli_name(&id),
+                         rpc_srv_get_pipe_srv_name(&id)));
        } else {
                status = smb_probe_module(
-                       "rpc", get_pipe_name_from_syntax(
-                               talloc_tos(),
-                               &pkt->u.bind.ctx_list[0].abstract_syntax));
+                       "rpc", dcerpc_default_transport_endpoint(pkt,
+                               NCACN_NP, table));
 
                if (NT_STATUS_IS_ERR(status)) {
-                       DEBUG(3,("api_pipe_bind_req: Unknown pipe name %s in bind request.\n",
-                                get_pipe_name_from_syntax(
-                                       talloc_tos(),
-                                       &pkt->u.bind.ctx_list[0].abstract_syntax)));
+                       DEBUG(3,("api_pipe_bind_req: Unknown rpc service name "
+                                 "%s in bind request.\n",
+                                ndr_interface_name(&id.uuid,
+                                                   id.if_version)));
 
                        return setup_bind_nak(p, pkt);
                }
 
                if (rpc_srv_get_pipe_interface_by_cli_name(
-                               get_pipe_name_from_syntax(talloc_tos(),
-                                                         &p->syntax),
+                               dcerpc_default_transport_endpoint(pkt,
+                                       NCACN_NP, table),
                                &id)) {
-                       DEBUG(3, ("api_pipe_bind_req: \\PIPE\\%s -> \\PIPE\\%s\n",
-                               rpc_srv_get_pipe_cli_name(&id),
-                               rpc_srv_get_pipe_srv_name(&id)));
+                       DEBUG(3, ("api_pipe_bind_req: %s -> %s rpc service\n",
+                                 rpc_srv_get_pipe_cli_name(&id),
+                                 rpc_srv_get_pipe_srv_name(&id)));
                } else {
                        DEBUG(0, ("module %s doesn't provide functions for "
                                  "pipe %s!\n",
-                                 get_pipe_name_from_syntax(talloc_tos(),
-                                                           &p->syntax),
-                                 get_pipe_name_from_syntax(talloc_tos(),
-                                                           &p->syntax)));
+                                 ndr_interface_name(&id.uuid,
+                                                    id.if_version),
+                                 ndr_interface_name(&id.uuid,
+                                                    id.if_version)));
                        return setup_bind_nak(p, pkt);
                }
        }
@@ -933,14 +653,14 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
                        pkt->u.bind.ctx_list[0].context_id)) {
 
                bind_ack_ctx.result = 0;
-               bind_ack_ctx.reason = 0;
+               bind_ack_ctx.reason.value = 0;
                bind_ack_ctx.syntax = pkt->u.bind.ctx_list[0].transfer_syntaxes[0];
        } else {
                p->pipe_bound = False;
                /* Rejection reason: abstract syntax not supported */
                bind_ack_ctx.result = DCERPC_BIND_PROVIDER_REJECT;
-               bind_ack_ctx.reason = DCERPC_BIND_REASON_ASYNTAX;
-               bind_ack_ctx.syntax = null_ndr_syntax_id;
+               bind_ack_ctx.reason.value = DCERPC_BIND_REASON_ASYNTAX;
+               bind_ack_ctx.syntax = ndr_syntax_id_null;
        }
 
        /*
@@ -992,30 +712,29 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
 
                switch (auth_type) {
                case DCERPC_AUTH_TYPE_NTLMSSP:
-                       if (!pipe_ntlmssp_auth_bind(p, pkt,
-                                               &auth_info, &auth_resp)) {
+                       if (!pipe_auth_generic_bind(p, pkt,
+                                                   &auth_info, &auth_resp)) {
                                goto err_exit;
                        }
                        assoc_gid = 0x7a77;
                        break;
 
                case DCERPC_AUTH_TYPE_SCHANNEL:
-                       if (!pipe_schannel_auth_bind(p, pkt,
-                                               &auth_info, &auth_resp)) {
+                       if (!pipe_auth_generic_bind(p, pkt,
+                                                   &auth_info, &auth_resp)) {
                                goto err_exit;
                        }
-                       break;
-
-               case DCERPC_AUTH_TYPE_SPNEGO:
-                       if (!pipe_spnego_auth_bind(p, pkt,
-                                               &auth_info, &auth_resp)) {
+                       if (!session_info_set_session_key(p->session_info, generic_session_key())) {
+                               DEBUG(0, ("session_info_set_session_key failed\n"));
                                goto err_exit;
                        }
+                       p->pipe_bound = true;
                        break;
 
+               case DCERPC_AUTH_TYPE_SPNEGO:
                case DCERPC_AUTH_TYPE_KRB5:
-                       if (!pipe_gssapi_auth_bind(p, pkt,
-                                               &auth_info, &auth_resp)) {
+                       if (!pipe_auth_generic_bind(p, pkt,
+                                                   &auth_info, &auth_resp)) {
                                goto err_exit;
                        }
                        break;
@@ -1089,10 +808,15 @@ static bool api_pipe_bind_req(struct pipes_struct *p,
         * header and are never sending more than one PDU here.
         */
 
+       pfc_flags = DCERPC_PFC_FLAG_FIRST | DCERPC_PFC_FLAG_LAST;
+
+       if (p->auth.hdr_signing) {
+               pfc_flags |= DCERPC_PFC_FLAG_SUPPORT_HEADER_SIGN;
+       }
+
        status = dcerpc_push_ncacn_packet(p->mem_ctx,
                                          DCERPC_PKT_BIND_ACK,
-                                         DCERPC_PFC_FLAG_FIRST |
-                                               DCERPC_PFC_FLAG_LAST,
+                                         pfc_flags,
                                          auth_resp.length,
                                          pkt->call_id,
                                          &u,
@@ -1156,15 +880,13 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
 {
        struct dcerpc_auth auth_info;
        DATA_BLOB response = data_blob_null;
-       struct auth_ntlmssp_state *ntlmssp_ctx;
-       struct spnego_context *spnego_ctx;
-       struct gse_context *gse_ctx;
+       struct gensec_security *gensec_security;
        NTSTATUS status;
 
        DEBUG(5, ("api_pipe_bind_auth3: decode request. %d\n", __LINE__));
 
        if (pkt->auth_length == 0) {
-               DEBUG(0, ("No auth field sent for bind request!\n"));
+               DEBUG(1, ("No auth field sent for bind request!\n"));
                goto err;
        }
 
@@ -1172,7 +894,7 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
        if (pkt->frag_length < RPC_HEADER_LEN
                                + DCERPC_AUTH_TRAILER_LENGTH
                                + pkt->auth_length) {
-                       DEBUG(0,("api_pipe_ntlmssp_auth_process: auth_len "
+                       DEBUG(1,("api_pipe_ntlmssp_auth_process: auth_len "
                                "%u is too large.\n",
                         (unsigned int)pkt->auth_length));
                goto err;
@@ -1186,7 +908,7 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
                                         &pkt->u.auth3.auth_info,
                                         &auth_info, p->endian);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to unmarshall dcerpc_auth.\n"));
+               DEBUG(1, ("Failed to unmarshall dcerpc_auth.\n"));
                goto err;
        }
 
@@ -1196,7 +918,7 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
         */
 
        if (auth_info.auth_type != p->auth.auth_type) {
-               DEBUG(0, ("Auth type mismatch! Client sent %d, "
+               DEBUG(1, ("Auth type mismatch! Client sent %d, "
                          "but auth was started as type %d!\n",
                          auth_info.auth_type, p->auth.auth_type));
                goto err;
@@ -1204,28 +926,16 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
 
        switch (auth_info.auth_type) {
        case DCERPC_AUTH_TYPE_NTLMSSP:
-               ntlmssp_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                   struct auth_ntlmssp_state);
-               status = ntlmssp_server_step(ntlmssp_ctx,
-                                            pkt, &auth_info.credentials,
-                                            &response);
-               break;
        case DCERPC_AUTH_TYPE_KRB5:
-               gse_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                               struct gse_context);
-               status = gssapi_server_step(gse_ctx,
-                                           pkt, &auth_info.credentials,
-                                           &response);
-               break;
        case DCERPC_AUTH_TYPE_SPNEGO:
-               spnego_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                  struct spnego_context);
-               status = spnego_server_step(spnego_ctx,
-                                           pkt, &auth_info.credentials,
-                                           &response);
+               gensec_security = talloc_get_type_abort(p->auth.auth_ctx,
+                                                   struct gensec_security);
+               status = auth_generic_server_step(gensec_security,
+                                            pkt, &auth_info.credentials,
+                                            &response);
                break;
        default:
-               DEBUG(0, (__location__ ": incorrect auth type (%u).\n",
+               DEBUG(1, (__location__ ": incorrect auth type (%u).\n",
                          (unsigned int)auth_info.auth_type));
                return false;
        }
@@ -1233,21 +943,21 @@ bool api_pipe_bind_auth3(struct pipes_struct *p, struct ncacn_packet *pkt)
        if (NT_STATUS_EQUAL(status,
                            NT_STATUS_MORE_PROCESSING_REQUIRED) ||
            response.length) {
-               DEBUG(0, (__location__ ": This was supposed to be the final "
+               DEBUG(1, (__location__ ": This was supposed to be the final "
                          "leg, but crypto machinery claims a response is "
                          "needed, aborting auth!\n"));
                data_blob_free(&response);
                goto err;
        }
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Auth failed (%s)\n", nt_errstr(status)));
+               DEBUG(2, ("Auth failed (%s)\n", nt_errstr(status)));
                goto err;
        }
 
        /* Now verify auth was indeed successful and extract server info */
        status = pipe_auth_verify_final(p);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Auth Verify failed (%s)\n", nt_errstr(status)));
+               DEBUG(2, ("Auth Verify failed (%s)\n", nt_errstr(status)));
                goto err;
        }
 
@@ -1275,9 +985,7 @@ static bool api_pipe_alter_context(struct pipes_struct *p,
        DATA_BLOB auth_resp = data_blob_null;
        DATA_BLOB auth_blob = data_blob_null;
        int pad_len = 0;
-       struct auth_ntlmssp_state *ntlmssp_ctx;
-       struct spnego_context *spnego_ctx;
-       struct gse_context *gse_ctx;
+       struct gensec_security *gensec_security;
 
        DEBUG(5,("api_pipe_alter_context: make response. %d\n", __LINE__));
 
@@ -1303,14 +1011,14 @@ static bool api_pipe_alter_context(struct pipes_struct *p,
                        pkt->u.bind.ctx_list[0].context_id)) {
 
                bind_ack_ctx.result = 0;
-               bind_ack_ctx.reason = 0;
+               bind_ack_ctx.reason.value = 0;
                bind_ack_ctx.syntax = pkt->u.bind.ctx_list[0].transfer_syntaxes[0];
        } else {
                p->pipe_bound = False;
                /* Rejection reason: abstract syntax not supported */
                bind_ack_ctx.result = DCERPC_BIND_PROVIDER_REJECT;
-               bind_ack_ctx.reason = DCERPC_BIND_REASON_ASYNTAX;
-               bind_ack_ctx.syntax = null_ndr_syntax_id;
+               bind_ack_ctx.reason.value = DCERPC_BIND_REASON_ASYNTAX;
+               bind_ack_ctx.syntax = ndr_syntax_id_null;
        }
 
        /*
@@ -1355,26 +1063,11 @@ static bool api_pipe_alter_context(struct pipes_struct *p,
 
                switch (auth_info.auth_type) {
                case DCERPC_AUTH_TYPE_SPNEGO:
-                       spnego_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                       struct spnego_context);
-                       status = spnego_server_step(spnego_ctx,
-                                                   pkt,
-                                                   &auth_info.credentials,
-                                                   &auth_resp);
-                       break;
-
                case DCERPC_AUTH_TYPE_KRB5:
-                       gse_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                       struct gse_context);
-                       status = gssapi_server_step(gse_ctx,
-                                                   pkt,
-                                                   &auth_info.credentials,
-                                                   &auth_resp);
-                       break;
                case DCERPC_AUTH_TYPE_NTLMSSP:
-                       ntlmssp_ctx = talloc_get_type_abort(p->auth.auth_ctx,
-                                                   struct auth_ntlmssp_state);
-                       status = ntlmssp_server_step(ntlmssp_ctx,
+                       gensec_security = talloc_get_type_abort(p->auth.auth_ctx,
+                                                   struct gensec_security);
+                       status = auth_generic_server_step(gensec_security,
                                                     pkt,
                                                     &auth_info.credentials,
                                                     &auth_resp);
@@ -1509,28 +1202,44 @@ static bool api_pipe_alter_context(struct pipes_struct *p,
        return setup_bind_nak(p, pkt);
 }
 
-/****************************************************************************
- Find the set of RPC functions associated with this context_id
-****************************************************************************/
+static bool api_rpcTNP(struct pipes_struct *p, struct ncacn_packet *pkt,
+                      const struct api_struct *api_rpc_cmds, int n_cmds,
+                      const struct ndr_syntax_id *syntax);
 
-static PIPE_RPC_FNS* find_pipe_fns_by_context( PIPE_RPC_FNS *list, uint32 context_id )
+static bool srv_pipe_check_verification_trailer(struct pipes_struct *p,
+                                               struct ncacn_packet *pkt,
+                                               struct pipe_rpc_fns *pipe_fns)
 {
-       PIPE_RPC_FNS *fns = NULL;
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct dcerpc_sec_verification_trailer *vt = NULL;
+       const uint32_t bitmask1 =
+               p->auth.client_hdr_signing ? DCERPC_SEC_VT_CLIENT_SUPPORTS_HEADER_SIGNING : 0;
+       const struct dcerpc_sec_vt_pcontext pcontext = {
+               .abstract_syntax = pipe_fns->syntax,
+               .transfer_syntax = ndr_transfer_syntax_ndr,
+       };
+       const struct dcerpc_sec_vt_header2 header2 =
+              dcerpc_sec_vt_header2_from_ncacn_packet(pkt);
+       struct ndr_pull *ndr;
+       enum ndr_err_code ndr_err;
+       bool ret = false;
 
-       if ( !list ) {
-               DEBUG(0,("find_pipe_fns_by_context: ERROR!  No context list for pipe!\n"));
-               return NULL;
+       ndr = ndr_pull_init_blob(&p->in_data.data, frame);
+       if (ndr == NULL) {
+               goto done;
        }
 
-       for (fns=list; fns; fns=fns->next ) {
-               if ( fns->context_id == context_id )
-                       return fns;
+       ndr_err = ndr_pop_dcerpc_sec_verification_trailer(ndr, frame, &vt);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               goto done;
        }
-       return NULL;
-}
 
-static bool api_rpcTNP(struct pipes_struct *p, struct ncacn_packet *pkt,
-                      const struct api_struct *api_rpc_cmds, int n_cmds);
+       ret = dcerpc_sec_verification_trailer_check(vt, &bitmask1,
+                                                   &pcontext, &header2);
+done:
+       TALLOC_FREE(frame);
+       return ret;
+}
 
 /****************************************************************************
  Find the correct RPC function to call for this request.
@@ -1541,46 +1250,53 @@ static bool api_rpcTNP(struct pipes_struct *p, struct ncacn_packet *pkt,
 static bool api_pipe_request(struct pipes_struct *p,
                                struct ncacn_packet *pkt)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        bool ret = False;
-       bool changed_user = False;
-       PIPE_RPC_FNS *pipe_fns;
-
-       if (p->pipe_bound &&
-           ((p->auth.auth_type == DCERPC_AUTH_TYPE_NTLMSSP) ||
-            (p->auth.auth_type == DCERPC_AUTH_TYPE_KRB5) ||
-            (p->auth.auth_type == DCERPC_AUTH_TYPE_SPNEGO))) {
-               if(!become_authenticated_pipe_user(p->session_info)) {
-                       data_blob_free(&p->out_data.rdata);
-                       return False;
-               }
-               changed_user = True;
-       }
+       struct pipe_rpc_fns *pipe_fns;
 
-       DEBUG(5, ("Requested \\PIPE\\%s\n",
-                 get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
+       if (!p->pipe_bound) {
+               DEBUG(1, ("Pipe not bound!\n"));
+               data_blob_free(&p->out_data.rdata);
+               TALLOC_FREE(frame);
+               return false;
+       }
 
        /* get the set of RPC functions for this context */
-
        pipe_fns = find_pipe_fns_by_context(p->contexts,
                                            pkt->u.request.context_id);
-
-       if ( pipe_fns ) {
-               TALLOC_CTX *frame = talloc_stackframe();
-               ret = api_rpcTNP(p, pkt, pipe_fns->cmds, pipe_fns->n_cmds);
+       if (pipe_fns == NULL) {
+               DEBUG(0, ("No rpc function table associated with context "
+                         "[%d]\n",
+                         pkt->u.request.context_id));
+               data_blob_free(&p->out_data.rdata);
                TALLOC_FREE(frame);
+               return false;
        }
-       else {
-               DEBUG(0, ("No rpc function table associated with context "
-                         "[%d] on pipe [%s]\n",
-                         pkt->u.request.context_id,
-                         get_pipe_name_from_syntax(talloc_tos(),
-                                                   &p->syntax)));
+
+       if (!srv_pipe_check_verification_trailer(p, pkt, pipe_fns)) {
+               DEBUG(1, ("srv_pipe_check_verification_trailer: failed\n"));
+               setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_ACCESS_DENIED));
+               data_blob_free(&p->out_data.rdata);
+               TALLOC_FREE(frame);
+               return true;
        }
 
-       if (changed_user) {
-               unbecome_authenticated_pipe_user();
+       if (!become_authenticated_pipe_user(p->session_info)) {
+               DEBUG(1, ("Failed to become pipe user!\n"));
+               data_blob_free(&p->out_data.rdata);
+               TALLOC_FREE(frame);
+               return false;
        }
 
+       DEBUG(5, ("Requested %s rpc service\n",
+                 ndr_interface_name(&pipe_fns->syntax.uuid,
+                                    pipe_fns->syntax.if_version)));
+
+       ret = api_rpcTNP(p, pkt, pipe_fns->cmds, pipe_fns->n_cmds,
+                        &pipe_fns->syntax);
+       unbecome_authenticated_pipe_user();
+
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -1589,20 +1305,28 @@ static bool api_pipe_request(struct pipes_struct *p,
  ********************************************************************/
 
 static bool api_rpcTNP(struct pipes_struct *p, struct ncacn_packet *pkt,
-                      const struct api_struct *api_rpc_cmds, int n_cmds)
+                      const struct api_struct *api_rpc_cmds, int n_cmds,
+                      const struct ndr_syntax_id *syntax)
 {
        int fn_num;
        uint32_t offset1;
+       const struct ndr_interface_table *table;
 
        /* interpret the command */
        DEBUG(4,("api_rpcTNP: %s op 0x%x - ",
-                get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
+                ndr_interface_name(&syntax->uuid, syntax->if_version),
                 pkt->u.request.opnum));
 
+       table = ndr_table_by_uuid(&syntax->uuid);
+       if (table == NULL) {
+               DEBUG(0,("unknown interface\n"));
+               return false;
+       }
+
        if (DEBUGLEVEL >= 50) {
                fstring name;
                slprintf(name, sizeof(name)-1, "in_%s",
-                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax));
+                        dcerpc_default_transport_endpoint(pkt, NCACN_NP, table));
                dump_pdu_region(name, pkt->u.request.opnum,
                                &p->in_data.data, 0,
                                p->in_data.data.length);
@@ -1635,37 +1359,30 @@ static bool api_rpcTNP(struct pipes_struct *p, struct ncacn_packet *pkt,
        /* do the actual command */
        if(!api_rpc_cmds[fn_num].fn(p)) {
                DEBUG(0,("api_rpcTNP: %s: %s failed.\n",
-                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax),
+                        ndr_interface_name(&syntax->uuid, syntax->if_version),
                         api_rpc_cmds[fn_num].name));
                data_blob_free(&p->out_data.rdata);
                return False;
        }
 
-       if (p->bad_handle_fault_state) {
-               DEBUG(4,("api_rpcTNP: bad handle fault return.\n"));
-               p->bad_handle_fault_state = False;
-               setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_CONTEXT_MISMATCH));
-               return True;
-       }
-
-       if (p->rng_fault_state) {
-               DEBUG(4, ("api_rpcTNP: rng fault return\n"));
-               p->rng_fault_state = False;
-               setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR));
-               return True;
+       if (p->fault_state) {
+               DEBUG(4,("api_rpcTNP: fault(%d) return.\n", p->fault_state));
+               setup_fault_pdu(p, NT_STATUS(p->fault_state));
+               p->fault_state = 0;
+               return true;
        }
 
        if (DEBUGLEVEL >= 50) {
                fstring name;
                slprintf(name, sizeof(name)-1, "out_%s",
-                        get_pipe_name_from_syntax(talloc_tos(), &p->syntax));
+                        dcerpc_default_transport_endpoint(pkt, NCACN_NP, table));
                dump_pdu_region(name, pkt->u.request.opnum,
                                &p->out_data.rdata, offset1,
                                p->out_data.rdata.length);
        }
 
        DEBUG(5,("api_rpcTNP: called %s successfully\n",
-                get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
+                ndr_interface_name(&syntax->uuid, syntax->if_version)));
 
        /* Check for buffer underflow in rpc parsing */
        if ((DEBUGLEVEL >= 10) &&
@@ -1707,9 +1424,9 @@ void set_incoming_fault(struct pipes_struct *p)
        data_blob_free(&p->in_data.data);
        p->in_data.pdu_needed_len = 0;
        p->in_data.pdu.length = 0;
-       p->fault_state = True;
-       DEBUG(10, ("set_incoming_fault: Setting fault state on pipe %s\n",
-                  get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
+       p->fault_state = DCERPC_FAULT_CANT_PERFORM;
+
+       DEBUG(10, ("Setting fault state\n"));
 }
 
 static NTSTATUS dcesrv_auth_request(struct pipe_auth_data *auth,
@@ -1760,6 +1477,7 @@ static bool process_request_pdu(struct pipes_struct *p, struct ncacn_packet *pkt
 {
        NTSTATUS status;
        DATA_BLOB data;
+       struct dcerpc_sec_vt_header2 hdr2;
 
        if (!p->pipe_bound) {
                DEBUG(0,("process_request_pdu: rpc request with no bind.\n"));
@@ -1767,6 +1485,16 @@ static bool process_request_pdu(struct pipes_struct *p, struct ncacn_packet *pkt
                return False;
        }
 
+       hdr2 = dcerpc_sec_vt_header2_from_ncacn_packet(pkt);
+       if (pkt->pfc_flags & DCERPC_PFC_FLAG_FIRST) {
+               p->header2 = hdr2;
+       } else {
+               if (!dcerpc_sec_vt_header2_equal(&hdr2, &p->header2)) {
+                       set_incoming_fault(p);
+                       return false;
+               }
+       }
+
        /* Store the opnum */
        p->opnum = pkt->u.request.opnum;
 
@@ -1812,91 +1540,43 @@ static bool process_request_pdu(struct pipes_struct *p, struct ncacn_packet *pkt
                }
        }
 
-       if (pkt->pfc_flags & DCERPC_PFC_FLAG_LAST) {
-               bool ret = False;
-               /*
-                * Ok - we finally have a complete RPC stream.
-                * Call the rpc command to process it.
-                */
-
-               /*
-                * Process the complete data stream here.
-                */
-               if (pipe_init_outgoing_data(p)) {
-                       ret = api_pipe_request(p, pkt);
-               }
-
-               return ret;
+       if (!(pkt->pfc_flags & DCERPC_PFC_FLAG_LAST)) {
+               return true;
        }
 
-       return True;
-}
+       /*
+        * Ok - we finally have a complete RPC stream.
+        * Call the rpc command to process it.
+        */
 
-/****************************************************************************
- Processes a finished PDU stored in p->in_data.pdu.
-****************************************************************************/
+       return api_pipe_request(p, pkt);
+}
 
-void process_complete_pdu(struct pipes_struct *p)
+void process_complete_pdu(struct pipes_struct *p, struct ncacn_packet *pkt)
 {
-       struct ncacn_packet *pkt = NULL;
-       NTSTATUS status;
-       bool reply = False;
+       bool reply = false;
 
-       if(p->fault_state) {
-               DEBUG(10,("process_complete_pdu: pipe %s in fault state.\n",
-                         get_pipe_name_from_syntax(talloc_tos(), &p->syntax)));
-               goto done;
-       }
-
-       pkt = talloc(p->mem_ctx, struct ncacn_packet);
-       if (!pkt) {
-               DEBUG(0, ("Out of memory!\n"));
-               goto done;
-       }
+       /* Store the call_id */
+       p->call_id = pkt->call_id;
 
-       /*
-        * Ensure we're using the corrent endianness for both the
-        * RPC header flags and the raw data we will be reading from.
-        */
-       if (dcerpc_get_endian_flag(&p->in_data.pdu) & DCERPC_DREP_LE) {
-               p->endian = RPC_LITTLE_ENDIAN;
-       } else {
-               p->endian = RPC_BIG_ENDIAN;
-       }
-       DEBUG(10, ("PDU is in %s Endian format!\n", p->endian?"Big":"Little"));
+       DEBUG(10, ("Processing packet type %u\n", (unsigned int)pkt->ptype));
 
-       status = dcerpc_pull_ncacn_packet(pkt, &p->in_data.pdu,
-                                         pkt, p->endian);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("Failed to unmarshal rpc packet: %s!\n",
-                         nt_errstr(status)));
+       if (!pipe_init_outgoing_data(p)) {
                goto done;
        }
 
-       /* Store the call_id */
-       p->call_id = pkt->call_id;
-
-       DEBUG(10, ("Processing packet type %d\n", (int)pkt->ptype));
-
        switch (pkt->ptype) {
        case DCERPC_PKT_REQUEST:
                reply = process_request_pdu(p, pkt);
                break;
 
        case DCERPC_PKT_PING: /* CL request - ignore... */
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "Connectionless packet type %d received on "
-                         "pipe %s.\n", (int)pkt->ptype,
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - Connectionless packet type %u received\n",
+                         (unsigned int)pkt->ptype));
                break;
 
        case DCERPC_PKT_RESPONSE: /* No responses here. */
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "DCERPC_PKT_RESPONSE received from client "
-                         "on pipe %s.\n",
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - DCERPC_PKT_RESPONSE received from client"));
                break;
 
        case DCERPC_PKT_FAULT:
@@ -1909,30 +1589,22 @@ void process_complete_pdu(struct pipes_struct *p)
        case DCERPC_PKT_CL_CANCEL:
        case DCERPC_PKT_FACK:
        case DCERPC_PKT_CANCEL_ACK:
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "Connectionless packet type %u received on "
-                         "pipe %s.\n", (unsigned int)pkt->ptype,
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - Connectionless packet type %u received\n",
+                         (unsigned int)pkt->ptype));
                break;
 
        case DCERPC_PKT_BIND:
                /*
                 * We assume that a pipe bind is only in one pdu.
                 */
-               if (pipe_init_outgoing_data(p)) {
-                       reply = api_pipe_bind_req(p, pkt);
-               }
+               reply = api_pipe_bind_req(p, pkt);
                break;
 
        case DCERPC_PKT_BIND_ACK:
        case DCERPC_PKT_BIND_NAK:
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "DCERPC_PKT_BINDACK/DCERPC_PKT_BINDNACK "
-                         "packet type %u received on pipe %s.\n",
-                         (unsigned int)pkt->ptype,
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - DCERPC_PKT_BINDACK/DCERPC_PKT_BINDNACK "
+                         "packet type %u received.\n",
+                         (unsigned int)pkt->ptype));
                break;
 
 
@@ -1940,34 +1612,24 @@ void process_complete_pdu(struct pipes_struct *p)
                /*
                 * We assume that a pipe bind is only in one pdu.
                 */
-               if (pipe_init_outgoing_data(p)) {
-                       reply = api_pipe_alter_context(p, pkt);
-               }
+               reply = api_pipe_alter_context(p, pkt);
                break;
 
        case DCERPC_PKT_ALTER_RESP:
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "DCERPC_PKT_ALTER_RESP on pipe %s: "
-                         "Should only be server -> client.\n",
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - DCERPC_PKT_ALTER_RESP received: "
+                         "Should only be server -> client.\n"));
                break;
 
        case DCERPC_PKT_AUTH3:
                /*
                 * The third packet in an auth exchange.
                 */
-               if (pipe_init_outgoing_data(p)) {
-                       reply = api_pipe_bind_auth3(p, pkt);
-               }
+               reply = api_pipe_bind_auth3(p, pkt);
                break;
 
        case DCERPC_PKT_SHUTDOWN:
-               DEBUG(0, ("process_complete_pdu: Error. "
-                         "DCERPC_PKT_SHUTDOWN on pipe %s: "
-                         "Should only be server -> client.\n",
-                        get_pipe_name_from_syntax(talloc_tos(),
-                                                  &p->syntax)));
+               DEBUG(0, ("Error - DCERPC_PKT_SHUTDOWN received: "
+                         "Should only be server -> client.\n"));
                break;
 
        case DCERPC_PKT_CO_CANCEL:
@@ -2012,21 +1674,10 @@ void process_complete_pdu(struct pipes_struct *p)
 
 done:
        if (!reply) {
-               DEBUG(3,("process_complete_pdu: DCE/RPC fault sent on "
-                        "pipe %s\n", get_pipe_name_from_syntax(talloc_tos(),
-                                                               &p->syntax)));
+               DEBUG(3,("DCE/RPC fault sent!"));
                set_incoming_fault(p);
                setup_fault_pdu(p, NT_STATUS(DCERPC_FAULT_OP_RNG_ERROR));
-               TALLOC_FREE(pkt);
-       } else {
-               /*
-                * Reset the lengths. We're ready for a new pdu.
-                */
-               TALLOC_FREE(p->in_data.pdu.data);
-               p->in_data.pdu_needed_len = 0;
-               p->in_data.pdu.length = 0;
        }
-
-       TALLOC_FREE(pkt);
+       /* pkt and p->in_data.pdu.data freed by caller */
 }