gensec_krb5: Implement smb_krb5_rd_req_decoded() with MIT Kerberos
[metze/samba/wip.git] / source4 / auth / gensec / gensec_krb5.c
index a81dfc37510ea832dadf116ce79f9e37c6ef12b2..e1ac73675429f8e64784e0569527f5aac2b58d81 100644 (file)
@@ -27,7 +27,6 @@
 #include "system/kerberos.h"
 #include "auth/kerberos/kerberos.h"
 #include "auth/auth.h"
-#include "lib/socket/socket.h"
 #include "lib/tsocket/tsocket.h"
 #include "librpc/gen_ndr/dcerpc.h"
 #include "auth/credentials/credentials.h"
@@ -42,7 +41,7 @@
 #include "lib/util/util_net.h"
 #include "../lib/util/asn1.h"
 #include "auth/kerberos/pac_utils.h"
-#include "gensec_krb5_util.h"
+#include "gensec_krb5.h"
 
 _PUBLIC_ NTSTATUS gensec_krb5_init(void);
 
@@ -71,7 +70,7 @@ static int gensec_krb5_destroy(struct gensec_krb5_state *gensec_krb5_state)
                return 0;
        }
        if (gensec_krb5_state->enc_ticket.length) { 
-               kerberos_free_data_contents(gensec_krb5_state->smb_krb5_context->krb5_context, 
+               smb_krb5_free_data_contents(gensec_krb5_state->smb_krb5_context->krb5_context,
                                            &gensec_krb5_state->enc_ticket); 
        }
 
@@ -151,6 +150,7 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
        if (tlocal_addr) {
                ssize_t socklen;
                struct sockaddr_storage ss;
+               bool ok;
 
                socklen = tsocket_address_bsd_sockaddr(tlocal_addr,
                                (struct sockaddr *) &ss,
@@ -159,12 +159,9 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
                        talloc_free(gensec_krb5_state);
                        return NT_STATUS_INTERNAL_ERROR;
                }
-               ret = krb5_sockaddr2address(gensec_krb5_state->smb_krb5_context->krb5_context,
-                               (const struct sockaddr *) &ss, &my_krb5_addr);
-               if (ret) {
-                       DEBUG(1,("gensec_krb5_start: krb5_sockaddr2address (local) failed (%s)\n", 
-                                smb_get_krb5_error_message(gensec_krb5_state->smb_krb5_context->krb5_context, 
-                                                           ret, gensec_krb5_state)));
+               ok = smb_krb5_sockaddr_to_kaddr(&ss, &my_krb5_addr);
+               if (!ok) {
+                       DBG_WARNING("smb_krb5_sockaddr_to_kaddr (local) failed\n");
                        talloc_free(gensec_krb5_state);
                        return NT_STATUS_INTERNAL_ERROR;
                }
@@ -174,6 +171,7 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
        if (tremote_addr) {
                ssize_t socklen;
                struct sockaddr_storage ss;
+               bool ok;
 
                socklen = tsocket_address_bsd_sockaddr(tremote_addr,
                                (struct sockaddr *) &ss,
@@ -182,12 +180,9 @@ static NTSTATUS gensec_krb5_start(struct gensec_security *gensec_security, bool
                        talloc_free(gensec_krb5_state);
                        return NT_STATUS_INTERNAL_ERROR;
                }
-               ret = krb5_sockaddr2address(gensec_krb5_state->smb_krb5_context->krb5_context,
-                               (const struct sockaddr *) &ss, &peer_krb5_addr);
-               if (ret) {
-                       DEBUG(1,("gensec_krb5_start: krb5_sockaddr2address (local) failed (%s)\n", 
-                                smb_get_krb5_error_message(gensec_krb5_state->smb_krb5_context->krb5_context, 
-                                                           ret, gensec_krb5_state)));
+               ok = smb_krb5_sockaddr_to_kaddr(&ss, &peer_krb5_addr);
+               if (!ok) {
+                       DBG_WARNING("smb_krb5_sockaddr_to_kaddr (remote) failed\n");
                        talloc_free(gensec_krb5_state);
                        return NT_STATUS_INTERNAL_ERROR;
                }
@@ -286,9 +281,17 @@ static NTSTATUS gensec_krb5_common_client_creds(struct gensec_security *gensec_s
        const char *error_string;
        const char *principal;
        const char *hostname;
-       krb5_data in_data;
+       krb5_data in_data = { .length = 0 };
+       krb5_data *in_data_p = NULL;
+#ifdef SAMBA4_USES_HEIMDAL
        struct tevent_context *previous_ev;
+#endif
 
+       if (lpcfg_parm_bool(gensec_security->settings->lp_ctx,
+                           NULL, "gensec_krb5", "send_authenticator_checksum", true)) {
+               in_data_p = &in_data;
+       }
+       
        gensec_krb5_state = (struct gensec_krb5_state *)gensec_security->private_data;
 
        principal = gensec_get_target_principal(gensec_security);
@@ -314,27 +317,62 @@ static NTSTATUS gensec_krb5_common_client_creds(struct gensec_security *gensec_s
                DEBUG(1, ("gensec_krb5_start: Aquiring initiator credentials failed: %s\n", error_string));
                return NT_STATUS_UNSUCCESSFUL;
        }
-       in_data.length = 0;
        
+#ifdef SAMBA4_USES_HEIMDAL
        /* Do this every time, in case we have weird recursive issues here */
        ret = smb_krb5_context_set_event_ctx(gensec_krb5_state->smb_krb5_context, ev, &previous_ev);
        if (ret != 0) {
                DEBUG(1, ("gensec_krb5_start: Setting event context failed\n"));
                return NT_STATUS_NO_MEMORY;
        }
+#endif
        if (principal) {
                krb5_principal target_principal;
                ret = krb5_parse_name(gensec_krb5_state->smb_krb5_context->krb5_context, principal,
                                      &target_principal);
                if (ret == 0) {
-                       ret = krb5_mk_req_exact(gensec_krb5_state->smb_krb5_context->krb5_context, 
-                                               &gensec_krb5_state->auth_context,
-                                               gensec_krb5_state->ap_req_options, 
-                                               target_principal,
-                                               &in_data, ccache_container->ccache, 
-                                               &gensec_krb5_state->enc_ticket);
-                       krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context, 
+                       krb5_creds this_cred;
+                       krb5_creds *cred;
+
+                       ZERO_STRUCT(this_cred);
+                       ret = krb5_cc_get_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                   ccache_container->ccache,
+                                                   &this_cred.client);
+                       if (ret != 0) {
+                               krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                   target_principal);
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+
+                       ret = krb5_copy_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                 target_principal,
+                                                 &this_cred.server);
+                       krb5_free_principal(gensec_krb5_state->smb_krb5_context->krb5_context,
                                            target_principal);
+                       if (ret != 0) {
+                               krb5_free_cred_contents(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                       &this_cred);
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+                       this_cred.times.endtime = 0;
+
+                       ret = krb5_get_credentials(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                  0,
+                                                  ccache_container->ccache,
+                                                  &this_cred,
+                                                  &cred);
+                       krb5_free_cred_contents(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                               &this_cred);
+                       if (ret != 0) {
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+
+                       ret = krb5_mk_req_extended(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                                  &gensec_krb5_state->auth_context,
+                                                  gensec_krb5_state->ap_req_options,
+                                                  in_data_p,
+                                                  cred,
+                                                  &gensec_krb5_state->enc_ticket);
                }
        } else {
                ret = krb5_mk_req(gensec_krb5_state->smb_krb5_context->krb5_context, 
@@ -342,11 +380,13 @@ static NTSTATUS gensec_krb5_common_client_creds(struct gensec_security *gensec_s
                                  gensec_krb5_state->ap_req_options,
                                  gensec_get_target_service(gensec_security),
                                  hostname,
-                                 &in_data, ccache_container->ccache, 
+                                 in_data_p, ccache_container->ccache, 
                                  &gensec_krb5_state->enc_ticket);
        }
 
+#ifdef SAMBA4_USES_HEIMDAL
        smb_krb5_context_remove_event_ctx(gensec_krb5_state->smb_krb5_context, previous_ev, ev);
+#endif
 
        switch (ret) {
        case 0:
@@ -418,14 +458,17 @@ static DATA_BLOB gensec_gssapi_gen_krb5_wrap(TALLOC_CTX *mem_ctx, const DATA_BLO
        if (!asn1_pop_tag(data)) goto err;
 
 
-       ret = data_blob_talloc(mem_ctx, data->data, data->length);
+       if (!asn1_extract_blob(data, mem_ctx, &ret)) {
+               goto err;
+       }
        asn1_free(data);
 
        return ret;
 
   err:
 
-       DEBUG(1,("Failed to build krb5 wrapper at offset %d\n", (int)data->ofs));
+       DEBUG(1, ("Failed to build krb5 wrapper at offset %d\n",
+                 (int)asn1_current_ofs(data)));
        asn1_free(data);
        return ret;
 }
@@ -450,7 +493,7 @@ static bool gensec_gssapi_parse_krb5_wrap(TALLOC_CTX *mem_ctx, const DATA_BLOB *
        data_remaining = asn1_tag_remaining(data);
 
        if (data_remaining < 3) {
-               data->has_error = true;
+               asn1_set_error(data);
        } else {
                if (!asn1_read(data, tok_id, 2)) goto err;
                data_remaining -= 2;
@@ -460,7 +503,7 @@ static bool gensec_gssapi_parse_krb5_wrap(TALLOC_CTX *mem_ctx, const DATA_BLOB *
 
        if (!asn1_end_tag(data)) goto err;
 
-       ret = !data->has_error;
+       ret = !asn1_has_error(data);
 
   err:
 
@@ -611,14 +654,17 @@ static NTSTATUS gensec_krb5_update(struct gensec_security *gensec_security,
                        inbuf.length = in.length;
                }
 
-               ret = smb_rd_req_return_stuff(gensec_krb5_state->smb_krb5_context->krb5_context,
-                                             &gensec_krb5_state->auth_context, 
-                                             &inbuf, keytab->keytab, server_in_keytab,  
-                                             &outbuf, 
-                                             &gensec_krb5_state->ticket, 
+               ret = smb_krb5_rd_req_decoded(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                             &gensec_krb5_state->auth_context,
+                                             &inbuf,
+                                             keytab->keytab,
+                                             server_in_keytab,
+                                             &outbuf,
+                                             &gensec_krb5_state->ticket,
                                              &gensec_krb5_state->keyblock);
 
                if (ret) {
+                       DBG_WARNING("smb_krb5_rd_req_decoded failed\n");
                        return NT_STATUS_LOGON_FAILURE;
                }
                unwrapped_out.data = (uint8_t *)outbuf.data;
@@ -630,7 +676,8 @@ static NTSTATUS gensec_krb5_update(struct gensec_security *gensec_security,
                } else {
                        *out = data_blob_talloc(out_mem_ctx, outbuf.data, outbuf.length);
                }
-               krb5_data_free(&outbuf);
+               smb_krb5_free_data_contents(gensec_krb5_state->smb_krb5_context->krb5_context,
+                                           &outbuf);
                return NT_STATUS_OK;
        }
 
@@ -648,8 +695,9 @@ static NTSTATUS gensec_krb5_session_key(struct gensec_security *gensec_security,
        struct gensec_krb5_state *gensec_krb5_state = (struct gensec_krb5_state *)gensec_security->private_data;
        krb5_context context = gensec_krb5_state->smb_krb5_context->krb5_context;
        krb5_auth_context auth_context = gensec_krb5_state->auth_context;
-       krb5_keyblock *skey;
        krb5_error_code err = -1;
+       bool remote = false;
+       bool ok;
 
        if (gensec_krb5_state->state_position != GENSEC_KRB5_DONE) {
                return NT_STATUS_NO_USER_SESSION_KEY;
@@ -657,27 +705,27 @@ static NTSTATUS gensec_krb5_session_key(struct gensec_security *gensec_security,
 
        switch (gensec_security->gensec_role) {
        case GENSEC_CLIENT:
-               err = krb5_auth_con_getlocalsubkey(context, auth_context, &skey);
+               remote = false;
                break;
        case GENSEC_SERVER:
-               err = krb5_auth_con_getremotesubkey(context, auth_context, &skey);
+               remote = true;
                break;
        }
-       if (err == 0 && skey != NULL) {
-               DEBUG(10, ("Got KRB5 session key of length %d\n",  
-                          (int)KRB5_KEY_LENGTH(skey)));
-               *session_key = data_blob_talloc(mem_ctx,
-                                              KRB5_KEY_DATA(skey), KRB5_KEY_LENGTH(skey));
-               dump_data_pw("KRB5 Session Key:\n", session_key->data, session_key->length);
 
-               krb5_free_keyblock(context, skey);
-               return NT_STATUS_OK;
-       } else {
+       ok = smb_krb5_get_smb_session_key(mem_ctx,
+                                         context,
+                                         auth_context,
+                                         session_key,
+                                         remote);
+       if (!ok) {
                DEBUG(10, ("KRB5 error getting session key %d\n", err));
                return NT_STATUS_NO_USER_SESSION_KEY;
        }
+
+       return NT_STATUS_OK;
 }
 
+#ifdef SAMBA4_USES_HEIMDAL
 static NTSTATUS gensec_krb5_session_info(struct gensec_security *gensec_security,
                                         TALLOC_CTX *mem_ctx,
                                         struct auth_session_info **_session_info) 
@@ -688,7 +736,7 @@ static NTSTATUS gensec_krb5_session_info(struct gensec_security *gensec_security
        struct auth_session_info *session_info = NULL;
 
        krb5_principal client_principal;
-       char *principal_string;
+       char *principal_string = NULL;
        
        DATA_BLOB pac_blob, *pac_blob_ptr = NULL;
        krb5_data pac_data;
@@ -732,7 +780,7 @@ static NTSTATUS gensec_krb5_session_info(struct gensec_security *gensec_security
        } else {
                /* Found pac */
                pac_blob = data_blob_talloc(tmp_ctx, pac_data.data, pac_data.length);
-               kerberos_free_data_contents(context, &pac_data);
+               smb_krb5_free_data_contents(context, &pac_data);
                if (!pac_blob.data) {
                        free(principal_string);
                        krb5_free_principal(context, client_principal);
@@ -785,6 +833,125 @@ static NTSTATUS gensec_krb5_session_info(struct gensec_security *gensec_security
        talloc_free(tmp_ctx);
        return NT_STATUS_OK;
 }
+#else /* MIT KERBEROS */
+static NTSTATUS gensec_krb5_session_info(struct gensec_security *gensec_security,
+                                        TALLOC_CTX *mem_ctx,
+                                        struct auth_session_info **psession_info)
+{
+       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       struct gensec_krb5_state *gensec_krb5_state =
+               (struct gensec_krb5_state *)gensec_security->private_data;
+       krb5_context context = gensec_krb5_state->smb_krb5_context->krb5_context;
+       struct auth_session_info *session_info = NULL;
+
+       krb5_principal client_principal;
+       char *principal_string = NULL;
+
+       krb5_authdata **auth_pac_data = NULL;
+       DATA_BLOB pac_blob, *pac_blob_ptr = NULL;
+
+       krb5_error_code code;
+
+       TALLOC_CTX *tmp_ctx;
+
+       tmp_ctx = talloc_new(mem_ctx);
+       if (tmp_ctx == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       code = krb5_copy_principal(context,
+                                  gensec_krb5_state->ticket->enc_part2->client,
+                                  &client_principal);
+       if (code != 0) {
+               DBG_INFO("krb5_copy_principal failed to copy client "
+                        "principal: %s\n",
+                        smb_get_krb5_error_message(context, code, tmp_ctx));
+               talloc_free(tmp_ctx);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       code = krb5_unparse_name(context, client_principal, &principal_string);
+       if (code != 0) {
+               DBG_WARNING("Unable to parse client principal: %s\n",
+                           smb_get_krb5_error_message(context, code, tmp_ctx));
+               krb5_free_principal(context, client_principal);
+               talloc_free(tmp_ctx);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       code = krb5_find_authdata(context,
+                                 gensec_krb5_state->ticket->enc_part2->authorization_data,
+                                 NULL,
+                                 KRB5_AUTHDATA_WIN2K_PAC,
+                                 &auth_pac_data);
+       if (code != 0) {
+               /* NO pac */
+               DBG_INFO("krb5_find_authdata failed to find PAC: %s\n",
+                        smb_get_krb5_error_message(context, code, tmp_ctx));
+       } else {
+               krb5_timestamp ticket_authtime =
+                       gensec_krb5_state->ticket->enc_part2->times.authtime;
+
+               /* Found pac */
+               pac_blob = data_blob_talloc(tmp_ctx,
+                                           auth_pac_data[0]->contents,
+                                           auth_pac_data[0]->length);
+               krb5_free_authdata(context, auth_pac_data);
+               if (pac_blob.data == NULL) {
+                       free(principal_string);
+                       krb5_free_principal(context, client_principal);
+                       talloc_free(tmp_ctx);
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               /* decode and verify the pac */
+               status = kerberos_decode_pac(gensec_krb5_state,
+                                            pac_blob,
+                                            context,
+                                            NULL,
+                                            gensec_krb5_state->keyblock,
+                                            client_principal,
+                                            ticket_authtime,
+                                            NULL);
+
+               if (!NT_STATUS_IS_OK(status)) {
+                       free(principal_string);
+                       krb5_free_principal(context, client_principal);
+                       talloc_free(tmp_ctx);
+                       return status;
+               }
+
+               pac_blob_ptr = &pac_blob;
+       }
+       krb5_free_principal(context, client_principal);
+
+       status = gensec_generate_session_info_pac(tmp_ctx,
+                                                 gensec_security,
+                                                 gensec_krb5_state->smb_krb5_context,
+                                                 pac_blob_ptr,
+                                                 principal_string,
+                                                 gensec_get_remote_address(gensec_security),
+                                                 &session_info);
+       SAFE_FREE(principal_string);
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(tmp_ctx);
+               return status;
+       }
+
+       status = gensec_krb5_session_key(gensec_security,
+                                        session_info,
+                                        &session_info->session_key);
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(tmp_ctx);
+               return status;
+       }
+
+       *psession_info = talloc_steal(mem_ctx, session_info);
+       talloc_free(tmp_ctx);
+
+       return NT_STATUS_OK;
+}
+#endif /* SAMBA4_USES_HEIMDAL */
 
 static NTSTATUS gensec_krb5_wrap(struct gensec_security *gensec_security, 
                                   TALLOC_CTX *mem_ctx, 
@@ -809,7 +976,7 @@ static NTSTATUS gensec_krb5_wrap(struct gensec_security *gensec_security,
                }
                *out = data_blob_talloc(mem_ctx, output.data, output.length);
                
-               krb5_data_free(&output);
+               smb_krb5_free_data_contents(context, &output);
        } else {
                return NT_STATUS_ACCESS_DENIED;
        }
@@ -840,7 +1007,7 @@ static NTSTATUS gensec_krb5_unwrap(struct gensec_security *gensec_security,
                }
                *out = data_blob_talloc(mem_ctx, output.data, output.length);
                
-               krb5_data_free(&output);
+               smb_krb5_free_data_contents(context, &output);
        } else {
                return NT_STATUS_ACCESS_DENIED;
        }
@@ -913,7 +1080,7 @@ _PUBLIC_ NTSTATUS gensec_krb5_init(void)
        ret = gensec_register(&gensec_fake_gssapi_krb5_security_ops);
        if (!NT_STATUS_IS_OK(ret)) {
                DEBUG(0,("Failed to register '%s' gensec backend!\n",
-                       gensec_krb5_security_ops.name));
+                       gensec_fake_gssapi_krb5_security_ops.name));
                return ret;
        }