dsdb: Fix CID 1034744 Dereference after null check
[metze/samba/wip.git] / source4 / dsdb / schema / schema_syntax.c
index 1458c2f92184dd6d4e8269f8e03af44ffc6598f9..b434b6b0a5f71eec690bc638dc64ac358e5cec81 100644 (file)
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "librpc/gen_ndr/ndr_security.h"
 #include "librpc/gen_ndr/ndr_misc.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
+#include <ldb.h>
+#include <ldb_errors.h>
 #include "system/time.h"
 #include "../lib/util/charset/charset.h"
 #include "librpc/ndr/libndr.h"
+#include "../lib/util/asn1.h"
 
 /**
  * Initialize dsdb_syntax_ctx with default values
@@ -41,8 +42,69 @@ void dsdb_syntax_ctx_init(struct dsdb_syntax_ctx *ctx,
 {
        ctx->ldb        = ldb;
        ctx->schema     = schema;
+
+       /*
+        * 'true' will keep current behavior,
+        * i.e. attributeID_id will be returned by default
+        */
+       ctx->is_schema_nc = true;
+
+       ctx->pfm_remote = NULL;
+}
+
+
+/**
+ * Returns ATTID for DRS attribute.
+ *
+ * ATTID depends on whether we are replicating
+ * Schema NC or msDs-IntId is set for schemaAttribute
+ * for the attribute.
+ */
+uint32_t dsdb_attribute_get_attid(const struct dsdb_attribute *attr,
+                                 bool for_schema_nc)
+{
+       if (!for_schema_nc && attr->msDS_IntId) {
+               return attr->msDS_IntId;
+       }
+
+       return attr->attributeID_id;
 }
 
+/**
+ * Map an ATTID from remote DC to a local ATTID
+ * using remote prefixMap
+ */
+static bool dsdb_syntax_attid_from_remote_attid(const struct dsdb_syntax_ctx *ctx,
+                                               TALLOC_CTX *mem_ctx,
+                                               uint32_t id_remote,
+                                               uint32_t *id_local)
+{
+       WERROR werr;
+       const char *oid;
+
+       /*
+        * map remote ATTID to local directly in case
+        * of no remote prefixMap (during provision for instance)
+        */
+       if (!ctx->pfm_remote) {
+               *id_local = id_remote;
+               return true;
+       }
+
+       werr = dsdb_schema_pfm_oid_from_attid(ctx->pfm_remote, id_remote, mem_ctx, &oid);
+       if (!W_ERROR_IS_OK(werr)) {
+               DEBUG(0,("ATTID->OID failed (%s) for: 0x%08X\n", win_errstr(werr), id_remote));
+               return false;
+       }
+
+       werr = dsdb_schema_pfm_attid_from_oid(ctx->schema->prefixmap, oid, id_local);
+       if (!W_ERROR_IS_OK(werr)) {
+               DEBUG(0,("OID->ATTID failed (%s) for: %s\n", win_errstr(werr), oid));
+               return false;
+       }
+
+       return true;
+}
 
 static WERROR dsdb_syntax_FOOBAR_drsuapi_to_ldb(const struct dsdb_syntax_ctx *ctx,
                                                const struct dsdb_attribute *attr,
@@ -146,11 +208,12 @@ static WERROR dsdb_syntax_BOOL_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx,
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -166,9 +229,11 @@ static WERROR dsdb_syntax_BOOL_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx,
                blobs[i] = data_blob_talloc(blobs, NULL, 4);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
-               if (strcmp("TRUE", (const char *)in->values[i].data) == 0) {
+               if (in->values[i].length >= 4 &&
+                   strncmp("TRUE", (const char *)in->values[i].data, in->values[i].length) == 0) {
                        SIVAL(blobs[i].data, 0, 0x00000001);
-               } else if (strcmp("FALSE", (const char *)in->values[i].data) == 0) {
+               } else if (in->values[i].length >= 5 &&
+                          strncmp("FALSE", (const char *)in->values[i].data, in->values[i].length) == 0) {
                        SIVAL(blobs[i].data, 0, 0x00000000);
                } else {
                        return WERR_FOOBAR;
@@ -184,23 +249,28 @@ static WERROR dsdb_syntax_BOOL_validate_ldb(const struct dsdb_syntax_ctx *ctx,
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
-               int t, f;
+               if (in->values[i].length == 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
 
-               t = strncmp("TRUE",
+               if (in->values[i].length >= 4 &&
+                   strncmp("TRUE",
                            (const char *)in->values[i].data,
-                           in->values[i].length);
-               f = strncmp("FALSE",
+                           in->values[i].length) == 0) {
+                       continue;
+               }
+               if (in->values[i].length >= 5 &&
+                   strncmp("FALSE",
                            (const char *)in->values[i].data,
-                           in->values[i].length);
-
-               if (t != 0 && f != 0) {
-                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                           in->values[i].length) == 0) {
+                       continue;
                }
+               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
        }
 
        return WERR_OK;
@@ -254,11 +324,12 @@ static WERROR dsdb_syntax_INT32_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -292,8 +363,8 @@ static WERROR dsdb_syntax_INT32_validate_ldb(const struct dsdb_syntax_ctx *ctx,
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -380,11 +451,12 @@ static WERROR dsdb_syntax_INT64_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -416,8 +488,8 @@ static WERROR dsdb_syntax_INT64_validate_ldb(const struct dsdb_syntax_ctx *ctx,
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -485,6 +557,11 @@ static WERROR dsdb_syntax_NTTIME_UTC_drsuapi_to_ldb(const struct dsdb_syntax_ctx
                }
 
                v = BVAL(in->value_ctr.values[i].blob->data, 0);
+               if (v == 0) {
+                       /* special case for 1601 zero timestamp */
+                       out->values[i] = data_blob_string_const("16010101000000.0Z");
+                       continue;
+               }
                v *= 10000000;
                t = nt_time_to_unix(v);
 
@@ -514,11 +591,12 @@ static WERROR dsdb_syntax_NTTIME_UTC_ldb_to_drsuapi(const struct dsdb_syntax_ctx
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -537,6 +615,11 @@ static WERROR dsdb_syntax_NTTIME_UTC_ldb_to_drsuapi(const struct dsdb_syntax_ctx
                blobs[i] = data_blob_talloc(blobs, NULL, 8);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
+               if (ldb_val_string_cmp(&in->values[i], "16010101000000.0Z") == 0) {
+                       SBVALS(blobs[i].data, 0, 0);
+                       continue;
+               }
+
                t = ldb_string_utc_to_time((const char *)in->values[i].data);
                unix_to_nt_time(&v, t);
                v /= 10000000;
@@ -553,8 +636,8 @@ static WERROR dsdb_syntax_NTTIME_UTC_validate_ldb(const struct dsdb_syntax_ctx *
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -567,9 +650,8 @@ static WERROR dsdb_syntax_NTTIME_UTC_validate_ldb(const struct dsdb_syntax_ctx *
                }
                memcpy(buf, in->values[i].data, in->values[i].length);
 
-               errno = 0;
                t = ldb_string_utc_to_time(buf);
-               if (errno != 0) {
+               if (t == 0) {
                        return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
                }
 
@@ -580,7 +662,7 @@ static WERROR dsdb_syntax_NTTIME_UTC_validate_ldb(const struct dsdb_syntax_ctx *
                }
 
                if (attr->rangeUpper) {
-                       if ((int32_t)t > (int32_t)*attr->rangeLower) {
+                       if ((int32_t)t > (int32_t)*attr->rangeUpper) {
                                return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
                        }
                }
@@ -624,6 +706,11 @@ static WERROR dsdb_syntax_NTTIME_drsuapi_to_ldb(const struct dsdb_syntax_ctx *ct
                }
 
                v = BVAL(in->value_ctr.values[i].blob->data, 0);
+               if (v == 0) {
+                       /* special case for 1601 zero timestamp */
+                       out->values[i] = data_blob_string_const("16010101000000.0Z");
+                       continue;
+               }
                v *= 10000000;
                t = nt_time_to_unix(v);
 
@@ -645,11 +732,12 @@ static WERROR dsdb_syntax_NTTIME_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ct
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -669,6 +757,11 @@ static WERROR dsdb_syntax_NTTIME_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ct
                blobs[i] = data_blob_talloc(blobs, NULL, 8);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
+               if (ldb_val_string_cmp(&in->values[i], "16010101000000.0Z") == 0) {
+                       SBVALS(blobs[i].data, 0, 0);
+                       continue;
+               }
+
                ret = ldb_val_to_time(&in->values[i], &t);
                if (ret != LDB_SUCCESS) {
                        return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
@@ -688,8 +781,8 @@ static WERROR dsdb_syntax_NTTIME_validate_ldb(const struct dsdb_syntax_ctx *ctx,
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -708,7 +801,7 @@ static WERROR dsdb_syntax_NTTIME_validate_ldb(const struct dsdb_syntax_ctx *ctx,
                }
 
                if (attr->rangeUpper) {
-                       if ((int32_t)t > (int32_t)*attr->rangeLower) {
+                       if ((int32_t)t > (int32_t)*attr->rangeUpper) {
                                return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
                        }
                }
@@ -743,7 +836,7 @@ static WERROR dsdb_syntax_DATA_BLOB_drsuapi_to_ldb(const struct dsdb_syntax_ctx
                }
 
                out->values[i] = data_blob_dup_talloc(out->values,
-                                                     in->value_ctr.values[i].blob);
+                                                     *in->value_ctr.values[i].blob);
                W_ERROR_HAVE_NO_MEMORY(out->values[i].data);
        }
 
@@ -759,11 +852,12 @@ static WERROR dsdb_syntax_DATA_BLOB_ldb_to_drsuapi(const struct dsdb_syntax_ctx
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -776,7 +870,7 @@ static WERROR dsdb_syntax_DATA_BLOB_ldb_to_drsuapi(const struct dsdb_syntax_ctx
        for (i=0; i < in->num_values; i++) {
                out->value_ctr.values[i].blob   = &blobs[i];
 
-               blobs[i] = data_blob_dup_talloc(blobs, &in->values[i]);
+               blobs[i] = data_blob_dup_talloc(blobs, in->values[i]);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
        }
 
@@ -787,8 +881,8 @@ static WERROR dsdb_syntax_DATA_BLOB_validate_one_val(const struct dsdb_syntax_ct
                                                     const struct dsdb_attribute *attr,
                                                     const struct ldb_val *val)
 {
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        if (attr->rangeLower) {
@@ -813,8 +907,8 @@ static WERROR dsdb_syntax_DATA_BLOB_validate_ldb(const struct dsdb_syntax_ctx *c
        unsigned int i;
        WERROR status;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -871,7 +965,9 @@ static WERROR _dsdb_syntax_auto_OID_drsuapi_to_ldb(const struct dsdb_syntax_ctx
                        str = talloc_strdup(out->values, a->lDAPDisplayName);
                } else {
                        WERROR werr;
-                       werr = dsdb_schema_pfm_oid_from_attid(ctx->schema->prefixmap, v, out->values, &str);
+                       SMB_ASSERT(ctx->pfm_remote);
+                       werr = dsdb_schema_pfm_oid_from_attid(ctx->pfm_remote, v,
+                                                             out->values, &str);
                        W_ERROR_NOT_OK_RETURN(werr);
                }
                W_ERROR_HAVE_NO_MEMORY(str);
@@ -900,7 +996,7 @@ static WERROR _dsdb_syntax_OID_obj_drsuapi_to_ldb(const struct dsdb_syntax_ctx *
        W_ERROR_HAVE_NO_MEMORY(out->values);
 
        for (i=0; i < out->num_values; i++) {
-               uint32_t v;
+               uint32_t v, vo;
                const struct dsdb_class *c;
                const char *str;
 
@@ -913,10 +1009,21 @@ static WERROR _dsdb_syntax_OID_obj_drsuapi_to_ldb(const struct dsdb_syntax_ctx *
                }
 
                v = IVAL(in->value_ctr.values[i].blob->data, 0);
+               vo = v;
+
+               /* convert remote ATTID to local ATTID */
+               if (!dsdb_syntax_attid_from_remote_attid(ctx, mem_ctx, v, &v)) {
+                       DEBUG(1,(__location__ ": Failed to map remote ATTID to local ATTID!\n"));
+                       return WERR_FOOBAR;
+               }
 
                c = dsdb_class_by_governsID_id(ctx->schema, v);
                if (!c) {
-                       return WERR_FOOBAR;
+                       int dbg_level = ctx->schema->resolving_in_progress ? 10 : 0;
+                       DEBUG(dbg_level,(__location__ ": %s unknown local governsID 0x%08X remote 0x%08X%s\n",
+                             attr->lDAPDisplayName, v, vo,
+                             ctx->schema->resolving_in_progress ? "resolving in progress" : ""));
+                       return WERR_DS_OBJ_CLASS_NOT_DEFINED;
                }
 
                str = talloc_strdup(out->values, c->lDAPDisplayName);
@@ -946,23 +1053,36 @@ static WERROR _dsdb_syntax_OID_attr_drsuapi_to_ldb(const struct dsdb_syntax_ctx
        W_ERROR_HAVE_NO_MEMORY(out->values);
 
        for (i=0; i < out->num_values; i++) {
-               uint32_t v;
+               uint32_t v, vo;
                const struct dsdb_attribute *a;
                const char *str;
 
                if (in->value_ctr.values[i].blob == NULL) {
+                       DEBUG(0, ("Attribute has no value\n"));
                        return WERR_FOOBAR;
                }
 
                if (in->value_ctr.values[i].blob->length != 4) {
+                       DEBUG(0, ("Attribute has a value with 0 length\n"));
                        return WERR_FOOBAR;
                }
 
                v = IVAL(in->value_ctr.values[i].blob->data, 0);
+               vo = v;
+
+               /* convert remote ATTID to local ATTID */
+               if (!dsdb_syntax_attid_from_remote_attid(ctx, mem_ctx, v, &v)) {
+                       DEBUG(1,(__location__ ": Failed to map remote ATTID to local ATTID!\n"));
+                       return WERR_FOOBAR;
+               }
 
                a = dsdb_attribute_by_attributeID_id(ctx->schema, v);
                if (!a) {
-                       return WERR_FOOBAR;
+                       int dbg_level = ctx->schema->resolving_in_progress ? 10 : 0;
+                       DEBUG(dbg_level,(__location__ ": %s unknown local attributeID_id 0x%08X remote 0x%08X%s\n",
+                             attr->lDAPDisplayName, v, vo,
+                             ctx->schema->resolving_in_progress ? "resolving in progress" : ""));
+                       return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
                }
 
                str = talloc_strdup(out->values, a->lDAPDisplayName);
@@ -982,6 +1102,14 @@ static WERROR _dsdb_syntax_OID_oid_drsuapi_to_ldb(const struct dsdb_syntax_ctx *
                                                  struct ldb_message_element *out)
 {
        unsigned int i;
+       const struct dsdb_schema_prefixmap *prefixmap;
+
+       if (ctx->pfm_remote != NULL) {
+               prefixmap = ctx->pfm_remote;
+       } else {
+               prefixmap = ctx->schema->prefixmap;
+       }
+       SMB_ASSERT(prefixmap);
 
        out->flags      = 0;
        out->name       = talloc_strdup(mem_ctx, attr->lDAPDisplayName);
@@ -1006,8 +1134,13 @@ static WERROR _dsdb_syntax_OID_oid_drsuapi_to_ldb(const struct dsdb_syntax_ctx *
 
                attid = IVAL(in->value_ctr.values[i].blob->data, 0);
 
-               status = dsdb_schema_pfm_oid_from_attid(ctx->schema->prefixmap, attid, out->values, &oid);
-               W_ERROR_NOT_OK_RETURN(status);
+               status = dsdb_schema_pfm_oid_from_attid(prefixmap, attid,
+                                                       out->values, &oid);
+               if (!W_ERROR_IS_OK(status)) {
+                       DEBUG(0,(__location__ ": Error: Unknown ATTID 0x%08X\n",
+                                attid));
+                       return status;
+               }
 
                out->values[i] = data_blob_string_const(oid);
        }
@@ -1024,7 +1157,8 @@ static WERROR _dsdb_syntax_auto_OID_ldb_to_drsuapi(const struct dsdb_syntax_ctx
         unsigned int i;
         DATA_BLOB *blobs;
 
-        out->attid= attr->attributeID_id;
+        out->attid= dsdb_attribute_get_attid(attr,
+                                            ctx->is_schema_nc);
         out->value_ctr.num_values= in->num_values;
         out->value_ctr.values= talloc_array(mem_ctx,
                                             struct drsuapi_DsAttributeValue,
@@ -1055,9 +1189,9 @@ static WERROR _dsdb_syntax_auto_OID_ldb_to_drsuapi(const struct dsdb_syntax_ctx
                } else {
                        uint32_t attid;
                        WERROR werr;
-                       werr = dsdb_schema_pfm_make_attid(ctx->schema->prefixmap,
-                                                         (const char *)v->data,
-                                                         &attid);
+                       werr = dsdb_schema_pfm_attid_from_oid(ctx->schema->prefixmap,
+                                                             (const char *)v->data,
+                                                             &attid);
                        W_ERROR_NOT_OK_RETURN(werr);
                        SIVAL(blobs[i].data, 0, attid);
                }
@@ -1077,7 +1211,8 @@ static WERROR _dsdb_syntax_OID_obj_ldb_to_drsuapi(const struct dsdb_syntax_ctx *
         unsigned int i;
         DATA_BLOB *blobs;
 
-        out->attid= attr->attributeID_id;
+        out->attid= dsdb_attribute_get_attid(attr,
+                                            ctx->is_schema_nc);
         out->value_ctr.num_values= in->num_values;
         out->value_ctr.values= talloc_array(mem_ctx,
                                             struct drsuapi_DsAttributeValue,
@@ -1118,7 +1253,8 @@ static WERROR _dsdb_syntax_OID_attr_ldb_to_drsuapi(const struct dsdb_syntax_ctx
         unsigned int i;
         DATA_BLOB *blobs;
 
-        out->attid= attr->attributeID_id;
+        out->attid= dsdb_attribute_get_attid(attr,
+                                            ctx->is_schema_nc);
         out->value_ctr.num_values= in->num_values;
         out->value_ctr.values= talloc_array(mem_ctx,
                                             struct drsuapi_DsAttributeValue,
@@ -1138,6 +1274,7 @@ static WERROR _dsdb_syntax_OID_attr_ldb_to_drsuapi(const struct dsdb_syntax_ctx
 
                obj_attr = dsdb_attribute_by_lDAPDisplayName(ctx->schema, (const char *)in->values[i].data);
                if (!obj_attr) {
+                       DEBUG(0, ("Unable to find attribute %s in the schema\n", (const char *)in->values[i].data));
                        return WERR_FOOBAR;
                }
                SIVAL(blobs[i].data, 0, obj_attr->attributeID_id);
@@ -1156,7 +1293,8 @@ static WERROR _dsdb_syntax_OID_oid_ldb_to_drsuapi(const struct dsdb_syntax_ctx *
        unsigned int i;
        DATA_BLOB *blobs;
 
-       out->attid= attr->attributeID_id;
+       out->attid= dsdb_attribute_get_attid(attr,
+                                            ctx->is_schema_nc);
        out->value_ctr.num_values= in->num_values;
        out->value_ctr.values= talloc_array(mem_ctx,
                                            struct drsuapi_DsAttributeValue,
@@ -1175,9 +1313,9 @@ static WERROR _dsdb_syntax_OID_oid_ldb_to_drsuapi(const struct dsdb_syntax_ctx *
                blobs[i] = data_blob_talloc(blobs, NULL, 4);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
-               status = dsdb_schema_pfm_make_attid(ctx->schema->prefixmap,
-                                                   (const char *)in->values[i].data,
-                                                   &attid);
+               status = dsdb_schema_pfm_attid_from_oid(ctx->schema->prefixmap,
+                                                       (const char *)in->values[i].data,
+                                                       &attid);
                W_ERROR_NOT_OK_RETURN(status);
 
                SIVAL(blobs[i].data, 0, attid);
@@ -1195,25 +1333,25 @@ static WERROR dsdb_syntax_OID_drsuapi_to_ldb(const struct dsdb_syntax_ctx *ctx,
        WERROR werr;
 
        switch (attr->attributeID_id) {
-       case DRSUAPI_ATTRIBUTE_objectClass:
-       case DRSUAPI_ATTRIBUTE_subClassOf:
-       case DRSUAPI_ATTRIBUTE_auxiliaryClass:
-       case DRSUAPI_ATTRIBUTE_systemAuxiliaryClass:
-       case DRSUAPI_ATTRIBUTE_systemPossSuperiors:
-       case DRSUAPI_ATTRIBUTE_possSuperiors:
+       case DRSUAPI_ATTID_objectClass:
+       case DRSUAPI_ATTID_subClassOf:
+       case DRSUAPI_ATTID_auxiliaryClass:
+       case DRSUAPI_ATTID_systemAuxiliaryClass:
+       case DRSUAPI_ATTID_systemPossSuperiors:
+       case DRSUAPI_ATTID_possSuperiors:
                werr = _dsdb_syntax_OID_obj_drsuapi_to_ldb(ctx, attr, in, mem_ctx, out);
                break;
-       case DRSUAPI_ATTRIBUTE_systemMustContain:
-       case DRSUAPI_ATTRIBUTE_systemMayContain:
-       case DRSUAPI_ATTRIBUTE_mustContain:
-       case DRSUAPI_ATTRIBUTE_rDNAttId:
-       case DRSUAPI_ATTRIBUTE_transportAddressAttribute:
-       case DRSUAPI_ATTRIBUTE_mayContain:
+       case DRSUAPI_ATTID_systemMustContain:
+       case DRSUAPI_ATTID_systemMayContain:
+       case DRSUAPI_ATTID_mustContain:
+       case DRSUAPI_ATTID_rDNAttId:
+       case DRSUAPI_ATTID_transportAddressAttribute:
+       case DRSUAPI_ATTID_mayContain:
                werr = _dsdb_syntax_OID_attr_drsuapi_to_ldb(ctx, attr, in, mem_ctx, out);
                break;
-       case DRSUAPI_ATTRIBUTE_governsID:
-       case DRSUAPI_ATTRIBUTE_attributeID:
-       case DRSUAPI_ATTRIBUTE_attributeSyntax:
+       case DRSUAPI_ATTID_governsID:
+       case DRSUAPI_ATTID_attributeID:
+       case DRSUAPI_ATTID_attributeSyntax:
                werr = _dsdb_syntax_OID_oid_drsuapi_to_ldb(ctx, attr, in, mem_ctx, out);
                break;
        default:
@@ -1223,7 +1361,7 @@ static WERROR dsdb_syntax_OID_drsuapi_to_ldb(const struct dsdb_syntax_ctx *ctx,
        }
 
        /* When we are doing the vampire of a schema, we don't want
-        * the inablity to reference an OID to get in the way.
+        * the inability to reference an OID to get in the way.
         * Otherwise, we won't get the new schema with which to
         * understand this */
        if (!W_ERROR_IS_OK(werr) && ctx->schema->relax_OID_conversions) {
@@ -1238,28 +1376,28 @@ static WERROR dsdb_syntax_OID_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx,
                                             TALLOC_CTX *mem_ctx,
                                             struct drsuapi_DsReplicaAttribute *out)
 {
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        switch (attr->attributeID_id) {
-       case DRSUAPI_ATTRIBUTE_objectClass:
-       case DRSUAPI_ATTRIBUTE_subClassOf:
-       case DRSUAPI_ATTRIBUTE_auxiliaryClass:
-       case DRSUAPI_ATTRIBUTE_systemAuxiliaryClass:
-       case DRSUAPI_ATTRIBUTE_systemPossSuperiors:
-       case DRSUAPI_ATTRIBUTE_possSuperiors:
+       case DRSUAPI_ATTID_objectClass:
+       case DRSUAPI_ATTID_subClassOf:
+       case DRSUAPI_ATTID_auxiliaryClass:
+       case DRSUAPI_ATTID_systemAuxiliaryClass:
+       case DRSUAPI_ATTID_systemPossSuperiors:
+       case DRSUAPI_ATTID_possSuperiors:
                return _dsdb_syntax_OID_obj_ldb_to_drsuapi(ctx, attr, in, mem_ctx, out);
-       case DRSUAPI_ATTRIBUTE_systemMustContain:
-       case DRSUAPI_ATTRIBUTE_systemMayContain:
-       case DRSUAPI_ATTRIBUTE_mustContain:
-       case DRSUAPI_ATTRIBUTE_rDNAttId:
-       case DRSUAPI_ATTRIBUTE_transportAddressAttribute:
-       case DRSUAPI_ATTRIBUTE_mayContain:
+       case DRSUAPI_ATTID_systemMustContain:
+       case DRSUAPI_ATTID_systemMayContain:
+       case DRSUAPI_ATTID_mustContain:
+       case DRSUAPI_ATTID_rDNAttId:
+       case DRSUAPI_ATTID_transportAddressAttribute:
+       case DRSUAPI_ATTID_mayContain:
                return _dsdb_syntax_OID_attr_ldb_to_drsuapi(ctx, attr, in, mem_ctx, out);
-       case DRSUAPI_ATTRIBUTE_governsID:
-       case DRSUAPI_ATTRIBUTE_attributeID:
-       case DRSUAPI_ATTRIBUTE_attributeSyntax:
+       case DRSUAPI_ATTID_governsID:
+       case DRSUAPI_ATTID_attributeID:
+       case DRSUAPI_ATTID_attributeSyntax:
                return _dsdb_syntax_OID_oid_ldb_to_drsuapi(ctx, attr, in, mem_ctx, out);
        }
 
@@ -1269,6 +1407,49 @@ static WERROR dsdb_syntax_OID_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx,
        return _dsdb_syntax_auto_OID_ldb_to_drsuapi(ctx, attr, in, mem_ctx, out);
 }
 
+static WERROR _dsdb_syntax_OID_validate_numericoid(const struct dsdb_syntax_ctx *ctx,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct ldb_message_element *in)
+{
+       unsigned int i;
+       TALLOC_CTX *tmp_ctx;
+
+       tmp_ctx = talloc_new(ctx->ldb);
+       W_ERROR_HAVE_NO_MEMORY(tmp_ctx);
+
+       for (i=0; i < in->num_values; i++) {
+               DATA_BLOB blob;
+               char *oid_out;
+               const char *oid = (const char*)in->values[i].data;
+
+               if (in->values[i].length == 0) {
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               if (!ber_write_OID_String(tmp_ctx, &blob, oid)) {
+                       DEBUG(0,("ber_write_OID_String() failed for %s\n", oid));
+                       talloc_free(tmp_ctx);
+                       return WERR_INVALID_PARAMETER;
+               }
+
+               if (!ber_read_OID_String(tmp_ctx, blob, &oid_out)) {
+                       DEBUG(0,("ber_read_OID_String() failed for %s\n",
+                                hex_encode_talloc(tmp_ctx, blob.data, blob.length)));
+                       talloc_free(tmp_ctx);
+                       return WERR_INVALID_PARAMETER;
+               }
+
+               if (strcmp(oid, oid_out) != 0) {
+                       talloc_free(tmp_ctx);
+                       return WERR_INVALID_PARAMETER;
+               }
+       }
+
+       talloc_free(tmp_ctx);
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_OID_validate_ldb(const struct dsdb_syntax_ctx *ctx,
                                           const struct dsdb_attribute *attr,
                                           const struct ldb_message_element *in)
@@ -1278,8 +1459,15 @@ static WERROR dsdb_syntax_OID_validate_ldb(const struct dsdb_syntax_ctx *ctx,
        struct ldb_message_element ldb_tmp;
        TALLOC_CTX *tmp_ctx;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
+       }
+
+       switch (attr->attributeID_id) {
+       case DRSUAPI_ATTID_governsID:
+       case DRSUAPI_ATTID_attributeID:
+       case DRSUAPI_ATTID_attributeSyntax:
+               return _dsdb_syntax_OID_validate_numericoid(ctx, attr, in);
        }
 
        /*
@@ -1287,9 +1475,7 @@ static WERROR dsdb_syntax_OID_validate_ldb(const struct dsdb_syntax_ctx *ctx,
         */
 
        tmp_ctx = talloc_new(ctx->ldb);
-       if (tmp_ctx == NULL) {
-               return WERR_NOMEM;
-       }
+       W_ERROR_HAVE_NO_MEMORY(tmp_ctx);
 
        status = dsdb_syntax_OID_ldb_to_drsuapi(ctx,
                                                attr,
@@ -1332,6 +1518,7 @@ static WERROR dsdb_syntax_UNICODE_drsuapi_to_ldb(const struct dsdb_syntax_ctx *c
        W_ERROR_HAVE_NO_MEMORY(out->values);
 
        for (i=0; i < out->num_values; i++) {
+               size_t converted_size = 0;
                char *str;
 
                if (in->value_ctr.values[i].blob == NULL) {
@@ -1346,11 +1533,11 @@ static WERROR dsdb_syntax_UNICODE_drsuapi_to_ldb(const struct dsdb_syntax_ctx *c
                                           CH_UTF16, CH_UNIX,
                                           in->value_ctr.values[i].blob->data,
                                           in->value_ctr.values[i].blob->length,
-                                          (void **)&str, NULL, false)) {
+                                          (void **)&str, &converted_size)) {
                        return WERR_FOOBAR;
                }
 
-               out->values[i] = data_blob_string_const(str);
+               out->values[i] = data_blob_const(str, converted_size);
        }
 
        return WERR_OK;
@@ -1365,11 +1552,12 @@ static WERROR dsdb_syntax_UNICODE_ldb_to_drsuapi(const struct dsdb_syntax_ctx *c
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -1385,7 +1573,7 @@ static WERROR dsdb_syntax_UNICODE_ldb_to_drsuapi(const struct dsdb_syntax_ctx *c
                if (!convert_string_talloc(blobs,
                                           CH_UNIX, CH_UTF16,
                                           in->values[i].data, in->values[i].length,
-                                          (void **)&blobs[i].data, &blobs[i].length, false)) {
+                                          (void **)&blobs[i].data, &blobs[i].length)) {
                        return WERR_FOOBAR;
                }
        }
@@ -1401,8 +1589,8 @@ static WERROR dsdb_syntax_UNICODE_validate_one_val(const struct dsdb_syntax_ctx
        size_t size;
        bool ok;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        ok = convert_string_talloc(ctx->ldb,
@@ -1410,7 +1598,7 @@ static WERROR dsdb_syntax_UNICODE_validate_one_val(const struct dsdb_syntax_ctx
                                   val->data,
                                   val->length,
                                   (void **)&dst,
-                                  &size, false);
+                                  &size);
        TALLOC_FREE(dst);
        if (!ok) {
                return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
@@ -1438,8 +1626,8 @@ static WERROR dsdb_syntax_UNICODE_validate_ldb(const struct dsdb_syntax_ctx *ctx
        WERROR status;
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -1458,9 +1646,9 @@ static WERROR dsdb_syntax_UNICODE_validate_ldb(const struct dsdb_syntax_ctx *ctx
        return WERR_OK;
 }
 
-WERROR dsdb_syntax_one_DN_drsuapi_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
-                                        const struct dsdb_syntax *syntax,
-                                        const DATA_BLOB *in, DATA_BLOB *out)
+static WERROR dsdb_syntax_one_DN_drsuapi_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
+                                               const struct dsdb_syntax *syntax,
+                                               const DATA_BLOB *in, DATA_BLOB *out)
 {
        struct drsuapi_DsReplicaObjectIdentifier3 id3;
        enum ndr_err_code ndr_err;
@@ -1577,11 +1765,12 @@ static WERROR dsdb_syntax_DN_ldb_to_drsuapi(const struct dsdb_syntax_ctx *ctx,
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -1658,8 +1847,8 @@ static WERROR dsdb_syntax_DN_validate_one_val(const struct dsdb_syntax_ctx *ctx,
 
        W_ERROR_HAVE_NO_MEMORY(tmp_ctx);
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        dsdb_dn = dsdb_dn_parse(tmp_ctx, ctx->ldb, val,
@@ -1673,7 +1862,7 @@ static WERROR dsdb_syntax_DN_validate_one_val(const struct dsdb_syntax_ctx *ctx,
        dn2 = ldb_dn_copy(tmp_ctx, dn);
        if (dn == NULL) {
                talloc_free(tmp_ctx);
-               return WERR_NOMEM;
+               return WERR_NOT_ENOUGH_MEMORY;
        }
 
        num_components = ldb_dn_get_comp_num(dn);
@@ -1741,8 +1930,8 @@ static WERROR dsdb_syntax_DN_validate_ldb(const struct dsdb_syntax_ctx *ctx,
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -1828,20 +2017,21 @@ static WERROR dsdb_syntax_DN_BINARY_drsuapi_to_ldb(const struct dsdb_syntax_ctx
                        W_ERROR_HAVE_NO_MEMORY(dn);
                }
 
-               status = GUID_to_ndr_blob(&id3.guid, tmp_ctx, &guid_blob);
-               if (!NT_STATUS_IS_OK(status)) {
-                       talloc_free(tmp_ctx);
-                       return ntstatus_to_werror(status);
-               }
+               if (!GUID_all_zero(&id3.guid)) {
+                       status = GUID_to_ndr_blob(&id3.guid, tmp_ctx, &guid_blob);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               talloc_free(tmp_ctx);
+                               return ntstatus_to_werror(status);
+                       }
 
-               ret = ldb_dn_set_extended_component(dn, "GUID", &guid_blob);
-               if (ret != LDB_SUCCESS) {
-                       talloc_free(tmp_ctx);
-                       return WERR_FOOBAR;
+                       ret = ldb_dn_set_extended_component(dn, "GUID", &guid_blob);
+                       if (ret != LDB_SUCCESS) {
+                               talloc_free(tmp_ctx);
+                               return WERR_FOOBAR;
+                       }
+                       talloc_free(guid_blob.data);
                }
 
-               talloc_free(guid_blob.data);
-
                if (id3.__ndr_size_sid) {
                        DATA_BLOB sid_blob;
                        ndr_err = ndr_push_struct_blob(&sid_blob, tmp_ctx, &id3.sid,
@@ -1882,11 +2072,12 @@ static WERROR dsdb_syntax_DN_BINARY_ldb_to_drsuapi(const struct dsdb_syntax_ctx
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -1960,8 +2151,8 @@ static WERROR dsdb_syntax_DN_BINARY_validate_ldb(const struct dsdb_syntax_ctx *c
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -2030,8 +2221,8 @@ static WERROR dsdb_syntax_DN_STRING_validate_ldb(const struct dsdb_syntax_ctx *c
 {
        unsigned int i;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        for (i=0; i < in->num_values; i++) {
@@ -2086,6 +2277,7 @@ static WERROR dsdb_syntax_PRESENTATION_ADDRESS_drsuapi_to_ldb(const struct dsdb_
 
        for (i=0; i < out->num_values; i++) {
                size_t len;
+               size_t converted_size = 0;
                char *str;
 
                if (in->value_ctr.values[i].blob == NULL) {
@@ -2105,7 +2297,7 @@ static WERROR dsdb_syntax_PRESENTATION_ADDRESS_drsuapi_to_ldb(const struct dsdb_
                if (!convert_string_talloc(out->values, CH_UTF16, CH_UNIX,
                                           in->value_ctr.values[i].blob->data+4,
                                           in->value_ctr.values[i].blob->length-4,
-                                          (void **)&str, NULL, false)) {
+                                          (void **)&str, &converted_size)) {
                        return WERR_FOOBAR;
                }
 
@@ -2124,11 +2316,12 @@ static WERROR dsdb_syntax_PRESENTATION_ADDRESS_ldb_to_drsuapi(const struct dsdb_
        unsigned int i;
        DATA_BLOB *blobs;
 
-       if (attr->attributeID_id == 0xFFFFFFFF) {
-               return WERR_FOOBAR;
+       if (attr->attributeID_id == DRSUAPI_ATTID_INVALID) {
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
-       out->attid                      = attr->attributeID_id;
+       out->attid                      = dsdb_attribute_get_attid(attr,
+                                                                  ctx->is_schema_nc);
        out->value_ctr.num_values       = in->num_values;
        out->value_ctr.values           = talloc_array(mem_ctx,
                                                       struct drsuapi_DsAttributeValue,
@@ -2147,7 +2340,7 @@ static WERROR dsdb_syntax_PRESENTATION_ADDRESS_ldb_to_drsuapi(const struct dsdb_
                if (!convert_string_talloc(blobs, CH_UNIX, CH_UTF16,
                                           in->values[i].data,
                                           in->values[i].length,
-                                          (void **)&data, &ret, false)) {
+                                          (void **)&data, &ret)) {
                        return WERR_FOOBAR;
                }
 
@@ -2186,7 +2379,8 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .ldb_to_drsuapi         = dsdb_syntax_BOOL_ldb_to_drsuapi,
                .validate_ldb           = dsdb_syntax_BOOL_validate_ldb,
                .equality               = "booleanMatch",
-               .comment                = "Boolean"
+               .comment                = "Boolean",
+               .auto_normalise         = true
        },{
                .name                   = "Integer",
                .ldap_oid               = LDB_SYNTAX_INTEGER,
@@ -2197,7 +2391,8 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .validate_ldb           = dsdb_syntax_INT32_validate_ldb,
                .equality               = "integerMatch",
                .comment                = "Integer",
-               .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32,
+               .auto_normalise         = true
        },{
                .name                   = "String(Octet)",
                .ldap_oid               = LDB_SYNTAX_OCTET_STRING,
@@ -2208,6 +2403,8 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "octetStringMatch",
                .comment                = "Octet String",
+               .userParameters         = true,
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_OCTET_STRING
        },{
                .name                   = "String(Sid)",
                .ldap_oid               = LDB_SYNTAX_OCTET_STRING,
@@ -2238,7 +2435,8 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .drsuapi_to_ldb         = dsdb_syntax_INT32_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_INT32_ldb_to_drsuapi,
                .validate_ldb           = dsdb_syntax_INT32_validate_ldb,
-               .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32,
+               .auto_normalise         = true
        },{
        /* not used in w2k3 forest */
                .name                   = "String(Numeric)",
@@ -2260,7 +2458,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
                .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
-               .ldb_syntax             = LDB_SYNTAX_OCTET_STRING,
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_OCTET_STRING,
        },{
                .name                   = "String(Teletex)",
                .ldap_oid               = "1.2.840.113556.1.4.905",
@@ -2283,7 +2481,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "caseExactIA5Match",
                .comment                = "Printable String",
-               .ldb_syntax             = LDB_SYNTAX_OCTET_STRING,
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_OCTET_STRING,
        },{
                .name                   = "String(UTC-Time)",
                .ldap_oid               = "1.3.6.1.4.1.1466.115.121.1.53",
@@ -2294,6 +2492,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .validate_ldb           = dsdb_syntax_NTTIME_UTC_validate_ldb,
                .equality               = "generalizedTimeMatch",
                .comment                = "UTC Time",
+               .auto_normalise         = true
        },{
                .name                   = "String(Generalized-Time)",
                .ldap_oid               = "1.3.6.1.4.1.1466.115.121.1.24",
@@ -2304,16 +2503,23 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .validate_ldb           = dsdb_syntax_NTTIME_validate_ldb,
                .equality               = "generalizedTimeMatch",
                .comment                = "Generalized Time",
-               .ldb_syntax             = LDB_SYNTAX_UTC_TIME,
+               .auto_normalise         = true
        },{
        /* not used in w2k3 schema */
                .name                   = "String(Case Sensitive)",
                .ldap_oid               = "1.2.840.113556.1.4.1362",
                .oMSyntax               = 27,
                .attributeSyntax_oid    = "2.5.5.3",
-               .drsuapi_to_ldb         = dsdb_syntax_FOOBAR_drsuapi_to_ldb,
-               .ldb_to_drsuapi         = dsdb_syntax_FOOBAR_ldb_to_drsuapi,
-               .validate_ldb           = dsdb_syntax_FOOBAR_validate_ldb,
+               .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
+               .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
+               .equality               = "caseExactMatch",
+               .substring              = "caseExactSubstringsMatch",
+               /* TODO (kim): according to LDAP rfc we should be using same comparison
+                * as Directory String (LDB_SYNTAX_DIRECTORY_STRING), but case sensitive.
+                * But according to ms docs binary compare should do the job:
+                * http://msdn.microsoft.com/en-us/library/cc223200(v=PROT.10).aspx */
+               .ldb_syntax             = LDB_SYNTAX_SAMBA_OCTET_STRING,
        },{
                .name                   = "String(Unicode)",
                .ldap_oid               = LDB_SYNTAX_DIRECTORY_STRING,
@@ -2336,6 +2542,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .equality               = "integerMatch",
                .comment                = "Large Integer",
                .ldb_syntax             = LDB_SYNTAX_INTEGER,
+               .auto_normalise         = true
        },{
                .name                   = "String(NT-Sec-Desc)",
                .ldap_oid               = LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR,
@@ -2407,7 +2614,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
        },{
        /* not used in w2k3 schema */
                .name                   = "Object(Access-Point)",
-               .ldap_oid               = "1.3.6.1.4.1.1466.115.121.1.2",
+               .ldap_oid               = DSDB_SYNTAX_ACCESS_POINT,
                .oMSyntax               = 127,
                .oMObjectClass          = OMOBJECTCLASS("\x2b\x0c\x02\x87\x73\x1c\x00\x85\x3e"),
                .attributeSyntax_oid    = "2.5.5.14",
@@ -2468,6 +2675,16 @@ const struct dsdb_syntax *dsdb_syntax_for_attribute(const struct dsdb_attribute
        unsigned int i;
 
        for (i=0; i < ARRAY_SIZE(dsdb_syntaxes); i++) {
+               /*
+                * We must pretend that userParameters was declared
+                * binary string, so we can store the 'UTF16' (not
+                * really string) structure as given over SAMR to samba
+                */
+               if (dsdb_syntaxes[i].userParameters &&
+                   (strcasecmp(attr->lDAPDisplayName, "userParameters") == 0))
+               {
+                       return &dsdb_syntaxes[i];
+               }
                if (attr->oMSyntax != dsdb_syntaxes[i].oMSyntax) continue;
 
                if (attr->oMObjectClass.length != dsdb_syntaxes[i].oMObjectClass.length) continue;
@@ -2488,22 +2705,95 @@ const struct dsdb_syntax *dsdb_syntax_for_attribute(const struct dsdb_attribute
        return NULL;
 }
 
+WERROR dsdb_attribute_drsuapi_remote_to_local(const struct dsdb_syntax_ctx *ctx,
+                                             enum drsuapi_DsAttributeId remote_attid_as_enum,
+                                             enum drsuapi_DsAttributeId *local_attid_as_enum,
+                                             const struct dsdb_attribute **_sa)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       const struct dsdb_attribute *sa;
+       uint32_t attid_local;
+       bool ok;
+
+       if (ctx->pfm_remote == NULL) {
+               smb_panic(__location__);
+       }
+
+       switch (dsdb_pfm_get_attid_type(remote_attid_as_enum)) {
+       case DSDB_ATTID_TYPE_PFM:
+               /* map remote ATTID to local ATTID */
+               ok = dsdb_syntax_attid_from_remote_attid(ctx, frame,
+                                                        remote_attid_as_enum,
+                                                        &attid_local);
+               if (!ok) {
+                       DEBUG(0,(__location__ ": Can't find local ATTID for 0x%08X\n",
+                                remote_attid_as_enum));
+                       TALLOC_FREE(frame);
+                       return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
+               }
+               break;
+       case DSDB_ATTID_TYPE_INTID:
+               /* use IntId value directly */
+               attid_local = remote_attid_as_enum;
+               break;
+       default:
+               /* we should never get here */
+               DEBUG(0,(__location__ ": Invalid ATTID type passed for conversion - 0x%08X\n",
+                        remote_attid_as_enum));
+               TALLOC_FREE(frame);
+               return WERR_INVALID_PARAMETER;
+       }
+
+       sa = dsdb_attribute_by_attributeID_id(ctx->schema, attid_local);
+       if (!sa) {
+               int dbg_level = ctx->schema->resolving_in_progress ? 10 : 0;
+               DEBUG(dbg_level,(__location__ ": Unknown local attributeID_id 0x%08X remote 0x%08X%s\n",
+                     attid_local, remote_attid_as_enum,
+                     ctx->schema->resolving_in_progress ? "resolving in progress" : ""));
+               TALLOC_FREE(frame);
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
+       }
+
+       /*
+        * We return the same class of attid as we were given.  That
+        * is, we trust the remote server not to use an
+        * msDS-IntId value in the schema partition
+        */
+       if (local_attid_as_enum != NULL) {
+               *local_attid_as_enum = (enum drsuapi_DsAttributeId)attid_local;
+       }
+
+       if (_sa != NULL) {
+               *_sa = sa;
+       }
+
+       TALLOC_FREE(frame);
+       return WERR_OK;
+}
+
 WERROR dsdb_attribute_drsuapi_to_ldb(struct ldb_context *ldb,
                                     const struct dsdb_schema *schema,
+                                    const struct dsdb_schema_prefixmap *pfm_remote,
                                     const struct drsuapi_DsReplicaAttribute *in,
                                     TALLOC_CTX *mem_ctx,
-                                    struct ldb_message_element *out)
+                                    struct ldb_message_element *out,
+                                    enum drsuapi_DsAttributeId *local_attid_as_enum)
 {
-       const struct dsdb_attribute *sa;
        struct dsdb_syntax_ctx syntax_ctx;
-
-       sa = dsdb_attribute_by_attributeID_id(schema, in->attid);
-       if (!sa) {
-               return WERR_FOOBAR;
-       }
+       const struct dsdb_attribute *sa = NULL;
+       WERROR werr;
 
        /* use default syntax conversion context */
        dsdb_syntax_ctx_init(&syntax_ctx, ldb, schema);
+       syntax_ctx.pfm_remote = pfm_remote;
+
+       werr = dsdb_attribute_drsuapi_remote_to_local(&syntax_ctx,
+                                                     in->attid,
+                                                     local_attid_as_enum,
+                                                     &sa);
+       if (!W_ERROR_IS_OK(werr)) {
+               return werr;
+       }
 
        return sa->syntax->drsuapi_to_ldb(&syntax_ctx, sa, in, mem_ctx, out);
 }
@@ -2519,7 +2809,7 @@ WERROR dsdb_attribute_ldb_to_drsuapi(struct ldb_context *ldb,
 
        sa = dsdb_attribute_by_lDAPDisplayName(schema, in->name);
        if (!sa) {
-               return WERR_FOOBAR;
+               return WERR_DS_ATT_NOT_DEF_IN_SCHEMA;
        }
 
        /* use default syntax conversion context */