all: reduce "inline" usage
authorJeff Darcy <jdarcy@redhat.com>
Tue, 28 Jul 2015 16:11:12 +0000 (12:11 -0400)
committerJeff Darcy <jdarcy@redhat.com>
Tue, 1 Sep 2015 11:55:15 +0000 (04:55 -0700)
commit0773ca67fdb60a142207759fa6c07a69882ce59c
tree027101fce644fe17e58c78321b1632f38aaed166
parent038dfe57cf0c5944b0392332dbf5a00bb1208150
all: reduce "inline" usage

There are three kinds of inline functions: plain inline, extern inline,
and static inline.  All three have been removed from .c files, except
those in "contrib" which aren't our problem.  Inlines in .h files, which
are overwhelmingly "static inline" already, have generally been left
alone.  Over time we should be able to "lower" these into .c files, but
that has to be done in a case-by-case fashion requiring more manual
effort.  This part was easy to do automatically without (as far as I can
tell) any ill effect.

In the process, several pieces of dead code were flagged by the
compiler, and were removed.

Change-Id: I56a5e614735c9e0a6ee420dab949eac22e25c155
BUG: 1245331
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/11769
Tested-by: NetBSD Build System <jenkins@build.gluster.org>
Reviewed-by: Dan Lambright <dlambrig@redhat.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Niels de Vos <ndevos@redhat.com>
Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
65 files changed:
cli/src/cli-cmd-parser.c
extras/test/ld-preload-test/ld-preload-lib.c
extras/test/ld-preload-test/ld-preload-test.c
libglusterfs/src/common-utils.c
libglusterfs/src/fd.c
libglusterfs/src/gfdb/gfdb_data_store.c
libglusterfs/src/gfdb/gfdb_sqlite3.c
libglusterfs/src/gfdb/gfdb_sqlite3_helper.c
libglusterfs/src/rbthash.c
libglusterfs/src/rot-buffs.c
libglusterfs/src/timer.c
rpc/rpc-lib/src/rpc-clnt.c
rpc/rpc-lib/src/rpc-transport.c
rpc/rpc-lib/src/rpcsvc.c
rpc/rpc-transport/rdma/src/rdma.c
rpc/rpc-transport/socket/src/socket.c
tests/utils/arequal-checksum.c
xlators/cluster/afr/src/afr-common.c
xlators/cluster/afr/src/afr-lk-common.c
xlators/cluster/afr/src/afr-self-heal-metadata.c
xlators/cluster/afr/src/pump.c
xlators/cluster/dht/src/dht-hashfn.c
xlators/cluster/dht/src/dht-helper.c
xlators/cluster/dht/src/dht-rebalance.c
xlators/cluster/dht/src/dht-selfheal.c
xlators/cluster/dht/src/tier.c
xlators/cluster/ec/src/ec-data.c
xlators/cluster/stripe/src/stripe.c
xlators/debug/io-stats/src/io-stats.c
xlators/debug/trace/src/trace.c
xlators/encryption/crypt/src/atom.c
xlators/encryption/crypt/src/crypt.c
xlators/features/bit-rot/src/bitd/bit-rot-scrub.c
xlators/features/bit-rot/src/bitd/bit-rot-tbf.c
xlators/features/bit-rot/src/bitd/bit-rot.c
xlators/features/bit-rot/src/stub/bit-rot-stub.c
xlators/features/changelog/lib/src/gf-changelog-reborp.c
xlators/features/changelog/src/changelog-encoders.c
xlators/features/changelog/src/changelog-ev-handle.c
xlators/features/changelog/src/changelog-helpers.c
xlators/features/changelog/src/changelog-rpc.c
xlators/features/changelog/src/changelog.c
xlators/features/changetimerecorder/src/changetimerecorder.c
xlators/features/changetimerecorder/src/ctr-xlator-ctx.c
xlators/features/index/src/index.c
xlators/features/locks/src/entrylk.c
xlators/features/locks/src/inodelk.c
xlators/features/locks/src/reservelk.c
xlators/features/marker/src/marker.c
xlators/features/quota/src/quota.c
xlators/mgmt/glusterd/src/glusterd-hooks.c
xlators/mgmt/glusterd/src/glusterd-server-quorum.c
xlators/mgmt/glusterd/src/glusterd-snapshot.c
xlators/mgmt/glusterd/src/glusterd-store.c
xlators/mgmt/glusterd/src/glusterd-utils.c
xlators/mgmt/glusterd/src/glusterd-volgen.c
xlators/mgmt/glusterd/src/glusterd.c
xlators/mount/fuse/src/fuse-bridge.c
xlators/mount/fuse/src/fuse-resolve.c
xlators/nfs/server/src/auth-cache.c
xlators/nfs/server/src/mount3.c
xlators/nfs/server/src/nfs3-helpers.c
xlators/performance/io-cache/src/io-cache.c
xlators/storage/bd/src/bd-helper.c
xlators/storage/posix/src/posix.c