git.samba.org / obnox / glusterfs.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: f2131b8) | patch
extras: reverse test for '}' vs. following 'else' placement
authorJeff Darcy <jdarcy@redhat.com>
Mon, 29 Sep 2014 21:27:14 +0000 (17:27 -0400)
committerVijay Bellur <vbellur@redhat.com>
Thu, 2 Oct 2014 14:01:15 +0000 (07:01 -0700)
commit0a8371bdfdd88e662d09def717cc0b822feb64e8
treefcb26b68c162ffcfd55d7afcf84a295aab23af93tree
parentf2131b8c79641c1bf9e20657757bcc9a62a0625acommit | diff
extras: reverse test for '}' vs. following 'else' placement

The two-line form "}\nelse {" has been more common than the one-line
form "} else {" in our code for years, and IMO for good reason (see
the comment in the diff).

Change-Id: Ic22c76fe76f0d91300daff36e755a18a8db58852
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/8888
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
extras/checkpatch.pl diff | blob | history
obnox' copy of Gluster code