CVE-2018-14629 dns: fix CNAME loop prevention using counter regression
authorStefan Metzmacher <metze@samba.org>
Wed, 28 Nov 2018 14:21:56 +0000 (15:21 +0100)
committerKarolin Seeger <kseeger@samba.org>
Fri, 7 Dec 2018 15:59:16 +0000 (16:59 +0100)
commit23b41ebe1deca762e03d4d688f0a11e11f809afd
tree9a2d90b3d3d849f728d3325fa01830566c574a66
parentafc799126853e1ce9cb498c4cc0eb17b9e0dd565
CVE-2018-14629 dns: fix CNAME loop prevention using counter regression

The loop prevention should only be done for CNAME records!

Otherwise we truncate the answer records for A, AAAA or
SRV queries, which is a bad idea if you have more than 20 DCs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec  4 08:52:29 CET 2018 on sn-devel-144

(cherry picked from commit 34f4491d79b47b2fe2457b8882f11644cf773bc4)

Autobuild-User(v4-7-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-7-test): Fri Dec  7 16:59:16 CET 2018 on sn-devel-144
selftest/knownfail.d/dns
source4/dns_server/dns_query.c