git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7f8c8d8) | patch
s3-lib: Fix push_ucs2() for-loop.
authorAndreas Schneider <asn@samba.org>
Mon, 17 Dec 2012 13:25:31 +0000 (14:25 +0100)
committerGünther Deschner <gd@samba.org>
Fri, 21 Dec 2012 12:56:00 +0000 (13:56 +0100)
commit3bd8c7dec60a26743e889df61c862516eb5bdcc3
tree04bfe7cb87e52fefd155d3524e41f309bc3b0401tree
parent7f8c8d80ef6553dc28f0bf6d9aa7a2c46ab55529commit | diff
s3-lib: Fix push_ucs2() for-loop.

ret is a bool and size is what we are looking for here, else the
statement can never be true.

Jeremy please check!

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
source3/lib/charcnv.c diff | blob | history
Samba Shared Repository