s4/rpc_server/sambr: don't mutate the return of samdb_set_password_aes
authorNoel Power <noel.power@suse.com>
Fri, 21 Oct 2022 16:40:36 +0000 (17:40 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 25 Oct 2022 09:34:33 +0000 (09:34 +0000)
commit416bf5a41827a4e486215bfc8e47abc570c6e899
tree927732dde654ebf82a414d80608f2a3923e69675
parent30ca92a8164e1c3a76cdb798ee997d27621a5abb
s4/rpc_server/sambr: don't mutate the return of samdb_set_password_aes

prior to this commit return of samdb_set_password_aes was set to
NT_STATUS_WRONG_PASSWORD on failure. Useful status that should be
returned such as NT_STATUS_PASSWORD_RESTRICTION are swallowed here
otherwise (and in this case can be partially responsible for failures
in test samba.tests.auth_log_pass_change (with later gnutls)

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/rpc_server/samr/samr_password.c