selftests: mptcp: diag: return KSFT_FAIL not test_cnt
authorGeliang Tang <tanggeliang@kylinos.cn>
Fri, 1 Mar 2024 17:11:22 +0000 (18:11 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Mar 2024 13:05:15 +0000 (13:05 +0000)
commit45bcc0346561daa3f59e19a753cc7f3e08e8dff1
tree942ec06f13330d4451749f5e558f94d17cb493dc
parent429679dcf7d918b7bb523d89bde3307fb02496c3
selftests: mptcp: diag: return KSFT_FAIL not test_cnt

The test counter 'test_cnt' should not be returned in diag.sh, e.g. what
if only the 4th test fail? Will do 'exit 4' which is 'exit ${KSFT_SKIP}',
the whole test will be marked as skipped instead of 'failed'!

So we should do ret=${KSFT_FAIL} instead.

Fixes: df62f2ec3df6 ("selftests/mptcp: add diag interface tests")
Cc: stable@vger.kernel.org
Fixes: 42fb6cddec3b ("selftests: mptcp: more stable diag tests")
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/mptcp/diag.sh