ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()
authorAndrew Bartlett <abartlet@samba.org>
Wed, 21 Aug 2019 23:09:55 +0000 (11:09 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 27 Aug 2019 04:44:41 +0000 (04:44 +0000)
commit52bd2dde5ae809ecc115f7087e367327f4771e73
treef6c4f6c1259d64493fda257d899544d92068a8cd
parent3f290e95c2c133eb2c983ecc984d3dff4809f3d3
ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()

This is beyond the normal level of clarity we expect in Samba, and is of course
rudundent, but this is a complex routine that has confusing tests, some of
pointers and some of boolean state values.

This tries to make the code as clear as possible pending a more comprehensive
rewrite.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
lib/ldb/common/ldb_dn.c