CVE-2019-10197: smbd: make sure that change_to_user_internal() always resets current_...
authorStefan Metzmacher <metze@samba.org>
Thu, 11 Jul 2019 15:01:29 +0000 (17:01 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 3 Sep 2019 08:07:37 +0000 (08:07 +0000)
commit6fae81312fad5caf948f0f0f48b84fd3f59dc944
tree81d746805b69d8324d5f529b8de56528b700c359
parente48c11896904fd063619a95d3fa7ceccbf2beb56
CVE-2019-10197: smbd: make sure that change_to_user_internal() always resets current_user.done_chdir

We should not leave current_user.done_chdir as true if we didn't call
chdir_current_service() with success.

This caused problems in when calling vfs_ChDir() in pop_conn_ctx() when
chdir_current_service() worked once on one share but later failed on another
share.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/uid.c