dsdb: Split rename case out of replmd_op_possible_conflict_callback
authorAndrew Bartlett <abartlet@samba.org>
Mon, 21 Mar 2016 00:32:55 +0000 (13:32 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 6 Jun 2016 14:36:23 +0000 (16:36 +0200)
commit8938f384b7aaeea5131eb854307787805b648f34
tree86c0ffefe0fa8029d93f23f4f7d505b8850de221
parente1dcd45d9e76ff2324750133d687ba8e952a1e47
dsdb: Split rename case out of replmd_op_possible_conflict_callback

This avoids running this code path, originally written for the add case, in
a semi-async manner in the rename case, which caused both bugs and complexity.

This does create a deal of duplicated code, but it is easier to follow because
there are no longer special cases for ADD and RENAME in the "common" code and
the behaviour of ldb_module_done() and the callbacks is well defined and expected

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz
source4/dsdb/samdb/ldb_modules/repl_meta_data.c