ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()
authorAndrew Bartlett <abartlet@samba.org>
Wed, 21 Aug 2019 23:09:55 +0000 (11:09 +1200)
committerKarolin Seeger <kseeger@samba.org>
Wed, 4 Sep 2019 08:31:25 +0000 (08:31 +0000)
commit9b0c30517834da57a436ac6a0bad1fa2c6173849
tree4b9f5c8b93ed8a6eb0b40ef37c3f548c82d9f996
parent1bc9476be79b994a3a9b0618f23f176e399c5aaa
ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()

This is beyond the normal level of clarity we expect in Samba, and is of course
rudundent, but this is a complex routine that has confusing tests, some of
pointers and some of boolean state values.

This tries to make the code as clear as possible pending a more comprehensive
rewrite.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 52bd2dde5ae809ecc115f7087e367327f4771e73)
lib/ldb/common/ldb_dn.c