Fix infinite loop for when port max range is -1
authorPeter Wu <peter@lekensteyn.nl>
Sat, 9 Jan 2016 14:27:14 +0000 (15:27 +0100)
committerAnders Broman <a.broman58@gmail.com>
Tue, 12 Jan 2016 08:25:38 +0000 (08:25 +0000)
commita5a2c3c04f131d13a296d3ddc902986ba37a4d0c
tree177dfbdc2bf341ee2de0a02c771edd3a8cc40df2
parentf83e20202f2530b5ca51969bdc5c7cf23d69e498
Fix infinite loop for when port max range is -1

Due to integer overflow (unsigned -1 + 1 = 0), a call to
dissector_add_uint_range would be stuck in an infinite loop, eventually
crashing due to out of memory.

Found when setting radius.alternate_port:-1, but could happen with any
dissector using similar ports_range constructs.

Change-Id: Ia234e94516446250e959e0f51d552bef704cddff
Reviewed-on: https://code.wireshark.org/review/13153
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
epan/packet.c