lib/addns: clang: Fix 'Assigned value is garbage or undefined'
authorNoel Power <noel.power@suse.com>
Tue, 9 Jul 2019 15:06:30 +0000 (15:06 +0000)
committerGary Lockyer <gary@samba.org>
Wed, 24 Jul 2019 21:33:21 +0000 (21:33 +0000)
commitbe2b69fecebd35d7a60057d6515e4401d3ce1294
treef6fb1b8efae067347547c75539d00b76c9a316e6
parentda4c1c5f39669274bf8ff5a0974b4111f80be798
lib/addns: clang: Fix 'Assigned value is garbage or undefined'

Fixes:

lib/addns/dnsquery.c:222:10: warning: Assigned value is garbage or undefined <--[clang]
        *numdcs = num_srvs;     /* size_t->int */
                ^
1 warning generated.

Also fixes the out param being modified even on failure

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
lib/addns/dnsquery.c