mm/slab: make __free(kfree) accept error pointers
authorDan Carpenter <dan.carpenter@linaro.org>
Sun, 28 Apr 2024 14:26:44 +0000 (17:26 +0300)
committerVlastimil Babka <vbabka@suse.cz>
Wed, 1 May 2024 15:30:06 +0000 (17:30 +0200)
commitcd7eb8f83fcf258f71e293f7fc52a70be8ed0128
treea2e47c6c9c2ab83445d7993a1c1aea44f0c98f92
parent8f828aa48812ced28aa39cb3cfe55ef2444d03dd
mm/slab: make __free(kfree) accept error pointers

Currently, if an automatically freed allocation is an error pointer that
will lead to a crash.  An example of this is in wm831x_gpio_dbg_show().

   171 char *label __free(kfree) = gpiochip_dup_line_label(chip, i);
   172 if (IS_ERR(label)) {
   173 dev_err(wm831x->dev, "Failed to duplicate label\n");
   174 continue;
   175  }

The auto clean up function should check for error pointers as well,
otherwise we're going to keep hitting issues like this.

Fixes: 54da6a092431 ("locking: Introduce __cleanup() based infrastructure")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
include/linux/slab.h