s3:smbstatus: go to cmdline_messaging_context_free
authorJones Syue <jonessyue@qnap.com>
Wed, 11 Jan 2023 08:59:42 +0000 (16:59 +0800)
committerVolker Lendecke <vl@samba.org>
Wed, 11 Jan 2023 17:08:10 +0000 (17:08 +0000)
commitde5d31f452b2445bd92b1746efb05aa096716af8
treefce3952f02a56831edd26a8e7597219b09122e34
parent7ffa732d8280c2e88daab6c3b97de71a3cdfb3ba
s3:smbstatus: go to cmdline_messaging_context_free

If the locking.tdb is not found,
(for example, fresh new installed samba server is not running yet)
smbstatus utility would exit earlier,
and lock files are left behind in the directory 'msg.sock' and 'msg.lock'.
Consider that a script to run smbstatus utility in a loop,
this might result in used space slowly growing-up on the underlying filesystem.
Since the samba server is not running yet,
there is no cleanupd daemon could delete these files to reclaim space.

Supposed to use 'ret = 0; goto done;' instead of exit(0),
this would go through the cmdline_messaging_context_free() which deletes
the lock files in the directory msg.sock and msg.lock before smbstatus
utility is exiting.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15282

Signed-off-by: Jones Syue <jonessyue@qnap.com>
Reviewed-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jan 11 17:08:10 UTC 2023 on sn-devel-184
source3/utils/status.c