git.samba.org / metze / samba / wip.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1e3bd3e) | patch
CVE-2016-2110: auth/ntlmssp: call ntlmssp_sign_init if we provide GENSEC_FEATURE_SIGN
authorStefan Metzmacher <metze@samba.org>
Mon, 16 Dec 2013 10:27:27 +0000 (11:27 +0100)
committerStefan Metzmacher <metze@samba.org>
Tue, 12 Apr 2016 17:25:23 +0000 (19:25 +0200)
commitfa8c65626e33be66c707931f7a4fc1e2798823a4
tree0ca79862a7a94dee488fedcf4821986863aac575tree
parent1e3bd3e6ac9d5bc97d6361d89abd7990bcaf91b8commit | diff
CVE-2016-2110: auth/ntlmssp: call ntlmssp_sign_init if we provide GENSEC_FEATURE_SIGN

It's important to check if got the GENSEC_FEATURE_SIGN and if the caller
wanted it.

The caller may only asked for GENSEC_FEATURE_SESSION_KEY which implicitly
negotiates NTLMSSP_NEGOTIATE_SIGN, which might indicate GENSEC_FEATURE_SIGN
to the SPNEGO glue code.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11644

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
auth/ntlmssp/ntlmssp_client.c diff | blob | history
auth/ntlmssp/ntlmssp_server.c diff | blob | history
Work in progress branches