tests: Fix creating remove_cmd.

Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Reviewed-by: Simo Sorce <idra@samba.org>

diff --git a/tests/test_ioctl.c b/tests/test_ioctl.c
index 86734cf834682e45004aba460c96ebbf1a8158a1..077e5531315517f6283b6e59cf9ad1d9df0bc32d 100644 (file)
--- a/tests/test_ioctl.c
+++ b/tests/test_ioctl.c
@@ -37,9 +37,10 @@ static void teardown(void **state)
 
        (void) state; /* unused */
 
-       if (swrap_dir != NULL) {
-               snprintf(remove_cmd, sizeof(remove_cmd), "rm -rf %s", swrap_dir);
+       if (swrap_dir == NULL) {
+               return;
        }
+       snprintf(remove_cmd, sizeof(remove_cmd), "rm -rf %s", swrap_dir);
 
        rc = system(remove_cmd);
        if (rc < 0) {