rpc: fix name-normalization in rpc_sid_to_name()
authorMichael Adam <obnox@samba.org>
Thu, 20 Feb 2014 15:55:15 +0000 (16:55 +0100)
committerStefan Metzmacher <metze@samba.org>
Tue, 25 Feb 2014 08:17:07 +0000 (09:17 +0100)
Hand the *input* name as input into the normalize call,
not the (potentially uninitialized...) *output* name...

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10463

Change-Id: I4f3fc25882c22d96329e252d0a53bbe13d533472
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de>
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/winbindd/winbindd_rpc.c

index 916013efffee8e4056461bbcd84e12c581eb7f91..739088f0dcc3ef640bedcf61c85f026f861c7f26 100644 (file)
@@ -362,7 +362,7 @@ NTSTATUS rpc_sid_to_name(TALLOC_CTX *mem_ctx,
 
        map_status = normalize_name_map(mem_ctx,
                                        domain,
-                                       *pname,
+                                       names[0],
                                        &mapped_name);
        if (NT_STATUS_IS_OK(map_status) ||
            NT_STATUS_EQUAL(map_status, NT_STATUS_FILE_RENAMED)) {