ctdb-tools: Simplify using a local variable
authorAmitay Isaacs <amitay@gmail.com>
Wed, 12 Oct 2016 04:46:17 +0000 (15:46 +1100)
committerJeremy Allison <jra@samba.org>
Thu, 27 Oct 2016 21:53:13 +0000 (23:53 +0200)
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tools/ltdbtool.c

index e30309056f7ed22498106ec29f4b7b45c4c7718e..e8465b2659fb7745708191fafeb6623d531c80e9 100644 (file)
@@ -325,12 +325,10 @@ static int write_record(TDB_CONTEXT* tdb, TDB_DATA key, TDB_DATA val,
 {
        struct write_record_ctx* ctx
                = (struct write_record_ctx*)write_record_ctx;
+       int ret;
 
        if (ctx->hsize == 0) {
-               if (tdb_store(ctx->tdb, key, val, ctx->tdb_store_flags) == -1) {
-                       fprintf(stderr, "tdb_store: %s\n", tdb_errorstr(ctx->tdb));
-                       return -1;
-               }
+               ret = tdb_store(ctx->tdb, key, val, ctx->tdb_store_flags);
        } else {
                TDB_DATA rec[2];
 
@@ -340,11 +338,14 @@ static int write_record(TDB_CONTEXT* tdb, TDB_DATA key, TDB_DATA val,
                rec[1].dsize = val.dsize;
                rec[1].dptr = val.dptr;
 
-               if(tdb_storev(ctx->tdb, key, rec, 2, ctx->tdb_store_flags) == -1) {
-                       fprintf(stderr, "tdb_store: %s\n", tdb_errorstr(ctx->tdb));
-                       return -1;
-               }
+               ret = tdb_storev(ctx->tdb, key, rec, 2, ctx->tdb_store_flags);
+       }
+
+       if (ret == -1) {
+               fprintf(stderr, "tdb_store: %s\n", tdb_errorstr(ctx->tdb));
+               return -1;
        }
+
        return 0;
 }