lib: Save intermediate NULL checks with talloc_asprintf_addbuf()
authorVolker Lendecke <vl@samba.org>
Wed, 30 Nov 2022 13:44:13 +0000 (14:44 +0100)
committerJeremy Allison <jra@samba.org>
Wed, 14 Dec 2022 04:32:34 +0000 (04:32 +0000)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
lib/ldb/common/ldb_dn.c

index bba41d0b2c68947f33be3b7ee690833dcc976310..601da57a1b1dc1a753e0afdafab6cec69eb3ed1f 100644 (file)
@@ -877,21 +877,17 @@ char *ldb_dn_get_extended_linearized(TALLOC_CTX *mem_ctx, struct ldb_dn *dn, int
                                            (int)val.length,
                                            val.data);
                } else {
-                       p = talloc_asprintf_append_buffer(p, ";<%s=%.*s>",
-                                                         name,
-                                                         (int)val.length,
-                                                         val.data);
+                       talloc_asprintf_addbuf(&p, ";<%s=%.*s>",
+                                              name,
+                                              (int)val.length,
+                                              val.data);
                }
 
                talloc_free(val.data);
-
-               if (!p) {
-                       return NULL;
-               }
        }
 
        if (dn->ext_comp_num && *linearized) {
-               p = talloc_asprintf_append_buffer(p, ";%s", linearized);
+               talloc_asprintf_addbuf(&p, ";%s", linearized);
        }
 
        if (!p) {