pytest:segfault: Add test for deleting an ldb.Control critical flag

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14845

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
[abartlet@samba.org backported from commit b1adaa517c1237a473bdcf818523f5107df3d6b0
 as @no_gdb_backtrace is not in Samba 4.14]

diff --git a/python/samba/tests/segfault.py b/python/samba/tests/segfault.py
index 24add6f3b6e72439e5f2b7c471d2cd539fe9edf6..62b51e71794982cc0a0d9e370473722824b35598 100644 (file)
--- a/python/samba/tests/segfault.py
+++ b/python/samba/tests/segfault.py
@@ -190,3 +190,10 @@ class SegfaultTests(samba.tests.TestCase):
     def test_ldb_msg_del_dn(self):
         msg = ldb.Message()
         del msg.dn
+
+    @segfault_detector
+    def test_ldb_control_del_critical(self):
+        samdb = self.get_samdb()
+
+        c = ldb.Control(samdb, 'relax:1')
+        del c.critical

diff --git a/selftest/knownfail.d/python-segfaults b/selftest/knownfail.d/python-segfaults
index d129dab7d474d0d121521c8529c7701fc90badef..0c6e52d63d4af29544c96f417c201c64954bb86f 100644 (file)
--- a/selftest/knownfail.d/python-segfaults
+++ b/selftest/knownfail.d/python-segfaults
@@ -1,3 +1,4 @@
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_net_replicate_init__3
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dnsp_string_list
 samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_dns_record
+samba.tests.segfault.samba.tests.segfault.SegfaultTests.test_ldb_control_del_critical