buildtools/wafsamba: Avoid calling lib_func without a prototype
authorFlorian Weimer <fweimer@redhat.com>
Mon, 21 Nov 2022 12:37:41 +0000 (13:37 +0100)
committerJule Anger <janger@samba.org>
Fri, 13 Jan 2023 10:54:14 +0000 (10:54 +0000)
This is a backport of commit f4c0a750d4adebcf2342a44e85f04526c34
("WAF: Fix detection of linker features")
to buildtools/wafsamba/samba_conftests.py.  It fixes the check for
rpath support with compilers in strict C99 mode.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15281

Signed-off-by: Florian Weimer <fweimer@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 75db84b1e59a42737343445c43c41494460c89f0)

buildtools/wafsamba/samba_waf18.py

index e2a078bd3a05fd789b5cb50a6b4eeb745249d6e7..cfdceea14ca4b7065c53f6c6ccf95823f3ba1b33 100644 (file)
@@ -209,7 +209,8 @@ def CHECK_LIBRARY_SUPPORT(conf, rpath=False, version_script=False, msg=None):
         lib_node.parent.mkdir()
         lib_node.write('int lib_func(void) { return 42; }\n', 'w')
         main_node = bld.srcnode.make_node('main.c')
-        main_node.write('int main(void) {return !(lib_func() == 42);}', 'w')
+        main_node.write('int lib_func(void);\n'
+                        'int main(void) {return !(lib_func() == 42);}', 'w')
         linkflags = []
         if version_script:
             script = bld.srcnode.make_node('ldscript')