According to

    http://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/Code-Gen-Options.html#Code-Gen-Options

-ftrapv "generates traps for signed overflow on addition, subtraction,
multiplication operations." and -fwrapv "instructs the compiler to
assume that signed arithmetic overflow of addition, subtraction and
multiplication wraps around using twos-complement representation."

Those seem mutually-exclusive to me, and we probably want wrapping, not
traps, as there's probably a fair bit of code out there that explicitly
or implicitly assumes wrapping.  (Actually, we really want to avoid
signed arithmetic for the cases that most matter, such as offsets and
lengths, but, unfortunately, we currently have API conventions that
allow negative values for lengths, either with -1 meaning "to the end"
or with negative values meaning "relative to the end".)  In addition,
there seem to be some bugs complaining that -ftrapv doesn't always cause
traps on signed integer overflow.

We seem to be seeing crashes in Lemon on the Solaris buildbot subsequent
to adding -ftrapv; I don't know whether that's an overflow being
detected, a bug in the compiler, or something unrelated, especially
given that we're using Sun C, not GCC, on the Solaris buildbot.
However, we'll try removing -ftrapv, to see if it fixes the problem; the
MIT CSAIL paper in question wasn't really recommending all the GCC
options it mentioned (which, as noted, wouldn't make sense, as -ftrapv
and -fwrapv appear to be mutually-exclusive).

svn path=/trunk/; revision=53556

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8b0fac7c9b3d46a75f474069482ada9608995977..025a4b81611e38bf98042a6bdd9044e7fb94bd68 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -210,7 +210,6 @@ else()
                -fwrapv
                -fno-strict-overflow
                -fno-delete-null-pointer-checks
-               -ftrapv
                # All the registration functions block these for now.
                -Wmissing-declarations
        )

diff --git a/configure.ac b/configure.ac
index 55424df8e14d16b545145848b6fba9d22f5fe37e..5eb9c1c9b6ab1dbbf85fec31035d869d6d21701d 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -819,7 +819,6 @@ AC_WIRESHARK_COMPILER_FLAGS_CHECK(-Wformat-security)
 AC_WIRESHARK_COMPILER_FLAGS_CHECK(-fwrapv)
 AC_WIRESHARK_COMPILER_FLAGS_CHECK(-fno-strict-overflow)
 AC_WIRESHARK_COMPILER_FLAGS_CHECK(-fno-delete-null-pointer-checks)
-AC_WIRESHARK_COMPILER_FLAGS_CHECK(-ftrapv)
 AC_WIRESHARK_COMPILER_FLAGS_CHECK(-Wold-style-definition, C)
 # The Qt headers generate a ton of shortening errors on 64-bit systems
 # so only enable this for C for now.