rpc/dns: reduce the CID count on temporary variables
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 2 May 2019 22:23:56 +0000 (10:23 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 May 2019 22:39:27 +0000 (22:39 +0000)
CID 1363189 and others.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source4/rpc_server/dnsserver/dnsdata.c

index 178ed7c51b1dc6ae36d48ad49249a05d6f33284c..2dc098a64a0cb724efd15714395ad9ce740987e8 100644 (file)
@@ -778,6 +778,7 @@ struct dns_tree *dns_build_tree(TALLOC_CTX *mem_ctx, const char *name, struct ld
 
        root = dns_tree_init(mem_ctx, nlist[rootcount-1], NULL);
        if (root == NULL) {
+               talloc_free(nlist);
                return NULL;
        }
 
@@ -849,6 +850,7 @@ struct dns_tree *dns_build_tree(TALLOC_CTX *mem_ctx, const char *name, struct ld
        return root;
 
 failed:
+       talloc_free(nlist);
        talloc_free(root);
        return NULL;
 }