krb5_wrap: Remove dead code in smb_krb5_renew_ticket().
authorAndreas Schneider <asn@samba.org>
Mon, 17 Dec 2012 13:03:50 +0000 (14:03 +0100)
committerGünther Deschner <gd@samba.org>
Fri, 21 Dec 2012 12:56:00 +0000 (13:56 +0100)
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
lib/krb5_wrap/krb5_samba.c

index f04f6e18370bbebc83d8a9e8f7e01aba51696195..ffb3f8d00d67ca5e0ec3fe2c255242f891528419 100644 (file)
@@ -816,7 +816,7 @@ done:
        krb5_context context = NULL;
        krb5_ccache ccache = NULL;
        krb5_principal client = NULL;
-       krb5_creds creds, creds_in, *creds_out = NULL;
+       krb5_creds creds, creds_in;
 
        ZERO_STRUCT(creds);
        ZERO_STRUCT(creds_in);
@@ -876,12 +876,7 @@ done:
 
 done:
        krb5_free_cred_contents(context, &creds_in);
-
-       if (creds_out) {
-               krb5_free_creds(context, creds_out);
-       } else {
-               krb5_free_cred_contents(context, &creds);
-       }
+       krb5_free_cred_contents(context, &creds);
 
        if (client) {
                krb5_free_principal(context, client);