ldb controls: don't ignore memory allocation failure

Thanks to Jeremy Allison for noticing this.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>

diff --git a/lib/ldb/common/ldb_controls.c b/lib/ldb/common/ldb_controls.c
index 0fdd13abc655e089188e094f4d181c271d843932..ba813ea04cf9f8df8a759851808ed1e313041d40 100644 (file)
--- a/lib/ldb/common/ldb_controls.c
+++ b/lib/ldb/common/ldb_controls.c
@@ -315,6 +315,9 @@ char *ldb_control_to_string(TALLOC_CTX *mem_ctx, const struct ldb_control *contr
                cookie = ldb_base64_encode(mem_ctx,
                                           (char *)rep_control->contextId,
                                           rep_control->ctxid_len);
+               if (cookie == NULL) {
+                       return NULL;
+               }
 
                res = talloc_asprintf(mem_ctx, "%s:%d:%d:%d:%d:%s",
                                                LDB_CONTROL_VLV_RESP_NAME,