cifs.upcall: fix crash when trying to free uninitialized var

If cifs.upcall is passed an invalid argument then it will "goto out".
The decoded_args struct however is uninitialized at that point so it
will usually segfault when trying to free fields in it. Move the
initialization up in the function.

Signed-off-by: Jeff Layton <jlayton@samba.org>

diff --git a/cifs.upcall.c b/cifs.upcall.c
index 1ffcd7cda2d96794e8fd18efd320a223c10fa122..34b0638fb39906a09aa8d62144705fced11cf172 100644 (file)
--- a/cifs.upcall.c
+++ b/cifs.upcall.c
@@ -677,6 +677,7 @@ int main(const int argc, char *const argv[])
        const char *oid;
 
        hostbuf[0] = '\0';
+       memset(&arg, 0, sizeof(arg));
 
        openlog(prog, 0, LOG_DAEMON);
 
@@ -731,8 +732,6 @@ int main(const int argc, char *const argv[])
                goto out;
        }
 
-       memset(&arg, 0, sizeof(arg));
-
        have = decode_key_description(buf, &arg);
        SAFE_FREE(buf);
        if ((have & DKD_MUSTHAVE_SET) != DKD_MUSTHAVE_SET) {