s4-rpc_server/drsuapi: Remove rudundant check for valid and non-NULL ncRoot_dn

This check was valuable before aee2039e63ceeb5e69a0461fb77e0f18278e4dc4
but now only checks things we know to be true, as the value has come
from Samba via drs_ObjectIdentifier_to_dn_and_nc_root() either on this
or a previous call.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15401

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 0550e469eda4022659718ae9a56f5deaa9f9a307)

diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
index 977a0b750690219c0bfd7f998ef223e09b202ed3..aaf8d8519abaf99ee58cc2763b777cf17dc6dfa9 100644 (file)
--- a/source4/rpc_server/drsuapi/getncchanges.c
+++ b/source4/rpc_server/drsuapi/getncchanges.c
@@ -3136,13 +3136,6 @@ allowed:
                TALLOC_FREE(res);
        }
 
-       if (!ldb_dn_validate(getnc_state->ncRoot_dn) ||
-           ldb_dn_is_null(getnc_state->ncRoot_dn)) {
-               DEBUG(0,(__location__ ": Bad DN '%s'\n",
-                        drs_ObjectIdentifier_to_debug_string(mem_ctx, ncRoot)));
-               return WERR_DS_DRA_INVALID_PARAMETER;
-       }
-
        ncRoot->guid = getnc_state->ncRoot_guid;
 
        /* we need the session key for encrypting password attributes */