tools: iio: replace seekdir() in iio_generic_buffer
authorPetre Rodan <petre.rodan@subdimension.ro>
Mon, 8 Jan 2024 10:32:20 +0000 (12:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 13 Apr 2024 11:05:16 +0000 (13:05 +0200)
[ Upstream commit 4e6500bfa053dc133021f9c144261b77b0ba7dc8 ]

Replace seekdir() with rewinddir() in order to fix a localized glibc bug.

One of the glibc patches that stable Gentoo is using causes an improper
directory stream positioning bug on 32bit arm. That in turn ends up as a
floating point exception in iio_generic_buffer.

The attached patch provides a fix by using an equivalent function which
should not cause trouble for other distros and is easier to reason about
in general as it obviously always goes back to to the start.

https://sourceware.org/bugzilla/show_bug.cgi?id=31212

Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro>
Link: https://lore.kernel.org/r/20240108103224.3986-1-petre.rodan@subdimension.ro
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/iio/iio_utils.c

index 6a00a6eecaef02bbb911741fc23e39614d8bdc90..c5c5082cb24e5cd05ed3d5f5a7f12c71d853209f 100644 (file)
@@ -376,7 +376,7 @@ int build_channel_array(const char *device_dir, int buffer_idx,
                goto error_close_dir;
        }
 
-       seekdir(dp, 0);
+       rewinddir(dp);
        while (ent = readdir(dp), ent) {
                if (strcmp(ent->d_name + strlen(ent->d_name) - strlen("_en"),
                           "_en") == 0) {