auth/credentials_krb5: let cli_credentials_get_server_gss_creds() use an early return

This will simplify the next commits.

Check with: git show -w

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12907

Signed-off-by: Stefan Metzmacher <metze@samba.org>

diff --git a/auth/credentials/credentials_krb5.c b/auth/credentials/credentials_krb5.c
index bd47113e60c3cc27d0795d48af996203ca285858..cd40b48093d4b80b17cab47f545d5302a4c1a921 100644 (file)
--- a/auth/credentials/credentials_krb5.c
+++ b/auth/credentials/credentials_krb5.c
@@ -1365,14 +1365,16 @@ _PUBLIC_ int cli_credentials_get_server_gss_creds(struct cli_credentials *cred,
                        ret = EINVAL;
                }
        }
-       if (ret == 0) {
-               cred->server_gss_creds_obtained = cred->keytab_obtained;
-               talloc_set_destructor(gcc, free_gssapi_creds);
-               cred->server_gss_creds = gcc;
-               *_gcc = gcc;
+       if (ret != 0) {
+               talloc_free(mem_ctx);
+               return ret;
        }
+       cred->server_gss_creds_obtained = cred->keytab_obtained;
+       talloc_set_destructor(gcc, free_gssapi_creds);
+       cred->server_gss_creds = gcc;
+       *_gcc = gcc;
        talloc_free(mem_ctx);
-       return ret;
+       return 0;
 }
 
 /**