compression: Use correct value for indic_pos

Previously, we were setting this to the wrong value and overwriting
existing output data.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/lib/compression/lzxpress.c b/lib/compression/lzxpress.c
index 0ecb6e23f931874ed3e285e49f497bdb865b6fd5..d3195a49435d932a2b32f2c34c8517c3f3110af2 100644 (file)
--- a/lib/compression/lzxpress.c
+++ b/lib/compression/lzxpress.c
@@ -201,8 +201,8 @@ ssize_t lzxpress_compress(const uint8_t *uncompressed,
                        if (indic_bit == 32) {
                                PUSH_LE_U32(indic_pos, 0, indic);
                                indic_bit = 0;
-                               indic_pos = &compressed[compressed_pos];
-                               compressed_pos += sizeof(uint32_t);
+                               indic_pos = &compressed[compressed_pos + metadata_size];
+                               metadata_size += sizeof(uint32_t);
                        }
 
                        compressed_pos += metadata_size;

diff --git a/selftest/knownfail.d/lzxpress b/selftest/knownfail.d/lzxpress
index 0fe7fdba6e0272e3cd9fe7061ab06ec1ba13fa51..922401eaa035ec843c4791f9fb52ca36e4457a2a 100644 (file)
--- a/selftest/knownfail.d/lzxpress
+++ b/selftest/knownfail.d/lzxpress
@@ -1,2 +1 @@
-samba4.local.compression.lzxpress5
 samba4.local.compression.lzxpress6