clk: imx: imx8-acm: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/ba373ce7341518216a4940e76ce61d759b912b3d.1709721042.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
index f68877eef87363b53048133a7908e6bdeaa2f0e4..1bdb480cc96c6bd7c4dc2a0a8c46e2024b36f0cd 100644 (file)
--- a/drivers/clk/imx/clk-imx8-acm.c
+++ b/drivers/clk/imx/clk-imx8-acm.c
@@ -394,15 +394,13 @@ err_clk_register:
        return ret;
 }
 
-static int imx8_acm_clk_remove(struct platform_device *pdev)
+static void imx8_acm_clk_remove(struct platform_device *pdev)
 {
        struct imx8_acm_priv *priv = dev_get_drvdata(&pdev->dev);
 
        pm_runtime_disable(&pdev->dev);
 
        clk_imx_acm_detach_pm_domains(&pdev->dev, &priv->dev_pm);
-
-       return 0;
 }
 
 static const struct imx8_acm_soc_data imx8qm_acm_data = {
@@ -470,7 +468,7 @@ static struct platform_driver imx8_acm_clk_driver = {
                .pm = &imx8_acm_pm_ops,
        },
        .probe = imx8_acm_clk_probe,
-       .remove = imx8_acm_clk_remove,
+       .remove_new = imx8_acm_clk_remove,
 };
 module_platform_driver(imx8_acm_clk_driver);