ctdb-vacuum: make ctdb_process_vacuum_fetch_lists() void.
authorMichael Adam <obnox@samba.org>
Sat, 15 Feb 2014 23:37:43 +0000 (00:37 +0100)
committerAmitay Isaacs <amitay@gmail.com>
Thu, 6 Mar 2014 00:31:15 +0000 (11:31 +1100)
This constantly returns 0 anyways.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/server/ctdb_vacuum.c

index 0ebbb41e0d0812b6a4b5ca88378719365d7a6106..60e3957f3a792efa859e37deb6427cad03013697 100644 (file)
@@ -761,8 +761,8 @@ static void ctdb_vacuum_traverse_db(struct ctdb_db_context *ctdb_db,
  * For records for which we are not the lmaster, tell the lmaster to
  * fetch the record.
  */
-static int ctdb_process_vacuum_fetch_lists(struct ctdb_db_context *ctdb_db,
-                                          struct vacuum_data *vdata)
+static void ctdb_process_vacuum_fetch_lists(struct ctdb_db_context *ctdb_db,
+                                           struct vacuum_data *vdata)
 {
        int i;
        struct ctdb_context *ctdb = ctdb_db->ctdb;
@@ -795,7 +795,7 @@ static int ctdb_process_vacuum_fetch_lists(struct ctdb_db_context *ctdb_db,
                }
        }
 
-       return 0;
+       return;
 }
 
 /**
@@ -1268,10 +1268,7 @@ static int ctdb_vacuum_db(struct ctdb_db_context *ctdb_db,
 
        ctdb_process_delete_queue(ctdb_db, vdata);
 
-       ret = ctdb_process_vacuum_fetch_lists(ctdb_db, vdata);
-       if (ret != 0) {
-               return ret;
-       }
+       ctdb_process_vacuum_fetch_lists(ctdb_db, vdata);
 
        ret = ctdb_process_delete_list(ctdb_db, vdata);
        if (ret != 0) {