libgpo: parse_gp_ext: do not crash upon no ext_strings
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 10 Jan 2020 02:45:45 +0000 (15:45 +1300)
committerGary Lockyer <gary@samba.org>
Mon, 13 Jan 2020 22:25:38 +0000 (22:25 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
libgpo/gpo_ldap.c

index e5a5adb723593273ae73005395404a3d9f7092df..2d95f74276ccc015263bac0812491761e39af55a 100644 (file)
@@ -98,7 +98,9 @@ bool ads_parse_gp_ext(TALLOC_CTX *mem_ctx,
                for (k = 0; ext_strings[k] != NULL; k++) {
                        /* no op */
                }
-
+               if (k == 0) {
+                       goto parse_error;
+               }
                q = ext_strings[0];
 
                if (q[0] == '{') {