smbd: Directly initialize key in smbXsrv_open_global_fetch_locked()
authorVolker Lendecke <vl@samba.org>
Wed, 11 Jan 2023 13:07:42 +0000 (14:07 +0100)
committerStefan Metzmacher <metze@samba.org>
Wed, 18 Jan 2023 11:49:38 +0000 (11:49 +0000)
Don't leave the key.dptr pointer uninitialized

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/smbd/smbXsrv_open.c

index ba4ca41975a4e957cfbf72d49018be6c62f1b335..651439cf85fa6bf5a08dcc53ab8403ef3747a56e 100644 (file)
@@ -113,11 +113,10 @@ static struct db_record *smbXsrv_open_global_fetch_locked(
                        uint32_t id,
                        TALLOC_CTX *mem_ctx)
 {
-       TDB_DATA key;
        uint8_t key_buf[SMBXSRV_OPEN_GLOBAL_TDB_KEY_SIZE];
+       TDB_DATA key = smbXsrv_open_global_id_to_key(id, key_buf);
        struct db_record *rec = NULL;
 
-       key = smbXsrv_open_global_id_to_key(id, key_buf);
 
        rec = dbwrap_fetch_locked(db, mem_ctx, key);