smbd: move tevent_req_post() out of smbd_smb2_create_after_exec()
authorRalph Boehme <slow@samba.org>
Fri, 28 Jul 2023 09:16:04 +0000 (11:16 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 28 Jul 2023 10:48:32 +0000 (10:48 +0000)
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
source3/smbd/smb2_create.c

index 5f5ccd52519ba7e937f41d9c9ed3e88f8188ba21..0b0e6701ea1f88382e60f4ae5d992b1d210627de 100644 (file)
@@ -954,7 +954,7 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
 
                smbd_smb2_create_after_exec(req);
                if (!tevent_req_is_in_progress(req)) {
-                       return req;
+                       return tevent_req_post(req, state->ev);
                }
 
                smbd_smb2_create_finish(req);
@@ -1033,7 +1033,7 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
 
                smbd_smb2_create_after_exec(req);
                if (!tevent_req_is_in_progress(req)) {
-                       return req;
+                       return tevent_req_post(req, state->ev);
                }
 
                smbd_smb2_create_finish(req);
@@ -1144,7 +1144,7 @@ static struct tevent_req *smbd_smb2_create_send(TALLOC_CTX *mem_ctx,
 
        smbd_smb2_create_after_exec(req);
        if (!tevent_req_is_in_progress(req)) {
-               return req;
+               return tevent_req_post(req, state->ev);
        }
 
        smbd_smb2_create_finish(req);
@@ -1706,7 +1706,6 @@ static void smbd_smb2_create_after_exec(struct tevent_req *req)
 fail:
        close_file_free(state->smb1req, &state->result, ERROR_CLOSE);
        tevent_req_nterror(req, status);
-       tevent_req_post(req, state->ev);
 }
 
 static void smbd_smb2_create_finish(struct tevent_req *req)