kdc: Always add the PAC if the header TGT is from an RODC
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Tue, 23 Nov 2021 07:15:41 +0000 (20:15 +1300)
committerJule Anger <janger@samba.org>
Sun, 24 Jul 2022 09:42:01 +0000 (11:42 +0200)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit 690a00a40c0a3f77da6e4dca42b630f2793a98b8)

selftest/knownfail_heimdal_kdc
source4/kdc/wdc-samba4.c

index 981d78941584c154ebb254588564cadf7490149e..94a4509f45ac9f12cc96728681c5ea2d6b4ee268 100644 (file)
 ^samba.tests.krb5.kdc_tgs_tests.samba.tests.krb5.kdc_tgs_tests.KdcTgsTests.test_tgs_requester_sid_missing_validate
 ^samba.tests.krb5.kdc_tgs_tests.samba.tests.krb5.kdc_tgs_tests.KdcTgsTests.test_tgs_requester_sid_rodc_renew
 ^samba.tests.krb5.kdc_tgs_tests.samba.tests.krb5.kdc_tgs_tests.KdcTgsTests.test_tgs_requester_sid_rodc_validate
-^samba.tests.krb5.kdc_tgs_tests.samba.tests.krb5.kdc_tgs_tests.KdcTgsTests.test_tgs_rodc_pac_request_false
 ^samba.tests.krb5.kdc_tgs_tests.samba.tests.krb5.kdc_tgs_tests.KdcTgsTests.test_validate_rodc_revealed
index ecd182702c3452f668038ce42abb81e902c181fc..8c3ce71529c85b702c9836f4d3e04e6fbe27fa6a 100644 (file)
@@ -471,7 +471,7 @@ static krb5_error_code samba_wdc_reget_pac2(krb5_context context,
                goto out;
        }
 
-       if (!server_skdc_entry->is_krbtgt) {
+       if (!is_untrusted && !server_skdc_entry->is_krbtgt) {
                /*
                 * The client may have requested no PAC when obtaining the
                 * TGT.