s3:mdssvv: don't fail the RPC request if the share name is unknown

Taken from macOS. We have to return an empty share_path and an empty policy
handle, but not fail the RPC request.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/selftest/knownfail.d/samba3.rpc b/selftest/knownfail.d/samba3.rpc
index 8e13167b53296c5e20db4f74c685af555e807ddc..53c2c709ff8e1cb3bf15dfabcdc38662b2a7d9c1 100644 (file)
--- a/selftest/knownfail.d/samba3.rpc
+++ b/selftest/knownfail.d/samba3.rpc
@@ -1,4 +1,3 @@
-^samba3.rpc.mdssvc.rpccmd.open_unknown_share\(fileserver\)
 ^samba3.rpc.mdssvc.rpccmd.open_spotlight_disabled\(fileserver\)
 ^samba3.rpc.mdssvc.rpccmd.close\(fileserver\)
 ^samba3.rpc.mdssvc.rpccmd.null_ph\(fileserver\)

diff --git a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
index 49a26fac6789fb66322ffb824104f6e1d4647ea1..f40cfc3dd85d595eab1a72328e27fef8b3de2119 100644 (file)
--- a/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
+++ b/source3/rpc_server/mdssvc/srv_mdssvc_nt.c
@@ -158,7 +158,6 @@ void _mdssvc_open(struct pipes_struct *p, struct mdssvc_open *r)
 
        snum = lp_servicenumber(r->in.share_name);
        if (!VALID_SNUM(snum)) {
-               p->fault_state = DCERPC_FAULT_CANT_PERFORM;
                return;
        }