unittest: workaround dependency problem in test_lib_util_modules
authorRalph Boehme <slow@samba.org>
Sun, 21 Apr 2019 06:38:23 +0000 (08:38 +0200)
committerJeremy Allison <jra@samba.org>
Thu, 8 Aug 2019 20:24:32 +0000 (20:24 +0000)
waf somehow screws the dependencies and the module ends up with a bunch of
missing RPC related symbols once an RPC service has special dependencies like
the mdssvc RPC service.

  $ bin/test_lib_util_modules
  test: test_samba_module_probe
  success: test_samba_module_probe
  test: test_samba_module_probe_dummy
  Error loading module '/home/samba/src/bin/modules/rpc/test_dummy_module.so':
  /home/samba/src/bin/modules/rpc/test_dummy_module.so: undefined symbol:
  rpc_service_mode
  failure: test_samba_module_probe_dummy [
  NT_STATUS_IS_OK(status)
  ../../testsuite/unittests/test_lib_util_modules.c:39: error: Failure!
  ]
  test: test_samba_module_probe_slash
  success: test_samba_module_probe_slash

This is currently not noticed as mdssvc is not enabled in selftest, but that is
going to change with a subsequent commit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
testsuite/unittests/wscript

index 561cb4bebad98d579178eeebde1d3726b3e85947..40fcb01ad574dabf77f2fd705b17e4bd513a6dee 100644 (file)
@@ -30,7 +30,7 @@ def build(bld):
 
     bld.SAMBA_MODULE('rpc_test_dummy_module',
                      source='rpc_test_dummy_module.c',
-                     deps='ndr',
+                     deps='ndr smbd_base',
                      subsystem='rpc',
                      allow_undefined_symbols=True,
                      init_function='',