lsa_server: Fix CID 1433608 Dereference after null check
authorVolker Lendecke <vl@samba.org>
Tue, 27 Mar 2018 22:03:15 +0000 (17:03 -0500)
committerJeremy Allison <jra@samba.org>
Wed, 28 Mar 2018 22:21:52 +0000 (00:21 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/rpc_server/lsa/lsa_lookup.c

index 3baff1ec11fd0cec3d6042a5dfebafbe49e684b5..becbcfc8b649835239c02272840a90aa8dc8041f 100644 (file)
@@ -88,7 +88,7 @@ static NTSTATUS dcesrv_lsa_lookup_name(struct lsa_policy_state *state,
        bool match = false;
        int ret;
 
-       if (principal == NULL && principal[0] == '\0') {
+       if ((principal == NULL) || (principal[0] == '\0')) {
                return NT_STATUS_NONE_MAPPED;
        }