lib: Fix CID 1356315 Dereference before null check

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index 9ee71f52c65f01e7071e4f632808e2e1a9075394..247b83be2f2429cf79962b05ffed2ddbac33d9b8 100644 (file)
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -1628,12 +1628,9 @@ out:
        if (memcmp(&zero_kt_entry, &kt_entry, sizeof(krb5_keytab_entry))) {
                smb_krb5_kt_free_entry(context, &kt_entry);
        }
-       if (keytab) {
-               if (memcmp(&cursor, &zero_csr, sizeof(krb5_kt_cursor)) != 0) {
-                       krb5_kt_end_seq_get(context, keytab, &cursor);
-               }
+       if (memcmp(&cursor, &zero_csr, sizeof(krb5_kt_cursor)) != 0) {
+               krb5_kt_end_seq_get(context, keytab, &cursor);
        }
-
        return ret;
 }